Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220525093702.57166-1-jiapeng.chong@linux.alibaba.com>
In-Reply-To: <20220525093702.57166-1-jiapeng.chong@linux.alibaba.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Wed, 25 May 2022 14:40:27 -0400
Message-ID: <CADnq5_Pp8gCkW1L6RVzKYALSk-Z5sQNEFDbOd9D8khwJsF+qEQ@mail.gmail.com>
Subject: Re: [PATCH] drm/amdgpu: make program_imu_rlc_ram static
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     "Deucher, Alexander" <alexander.deucher@amd.com>,
        Dave Airlie <airlied@linux.ie>,
        xinhui pan <Xinhui.Pan@amd.com>,
        Abaci Robot <abaci@linux.alibaba.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        Christian Koenig <christian.koenig@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

Alex

On Wed, May 25, 2022 at 5:37 AM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> This symbol is not used outside of imu_v11_0.c, so marks it
> static.
>
> Fixes the following w1 warning:
>
> drivers/gpu/drm/amd/amdgpu/imu_v11_0.c:302:6: warning: no previous
> prototype for =E2=80=98program_imu_rlc_ram=E2=80=99 [-Wmissing-prototypes=
].
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/imu_v11_0.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/imu_v11_0.c b/drivers/gpu/drm/amd=
/amdgpu/imu_v11_0.c
> index 5d2dfeff8fe5..d63d3f2b8a16 100644
> --- a/drivers/gpu/drm/amd/amdgpu/imu_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/imu_v11_0.c
> @@ -299,7 +299,7 @@ static const struct imu_rlc_ram_golden imu_rlc_ram_go=
lden_11_0_2[] =3D
>         IMU_RLC_RAM_GOLDEN_VALUE(GC, 0, regCPG_PSP_DEBUG, CPG_PSP_DEBUG__=
GPA_OVERRIDE_MASK, 0)
>  };
>
> -void program_imu_rlc_ram(struct amdgpu_device *adev,
> +static void program_imu_rlc_ram(struct amdgpu_device *adev,
>                                 const struct imu_rlc_ram_golden *regs,
>                                 const u32 array_size)
>  {
> --
> 2.20.1.7.g153144c
>