Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4fe4021b-1225-36a3-f13c-9fcd491f6351@theobroma-systems.com>
Date:   Wed, 25 May 2022 14:14:47 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH v3 2/4] media: ov5675: add device-tree support and support
 runtime PM
Content-Language: en-US
To:     Jacopo Mondi <jacopo@jmondi.org>,
        Quentin Schulz <foss+kernel@0leil.net>
Cc:     shawnx.tu@intel.com, mchehab@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, linux-media@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220509143226.531117-1-foss+kernel@0leil.net>
 <20220509143226.531117-2-foss+kernel@0leil.net>
 <20220510094607.2ijaw6we6jml2bv7@uno.localdomain>
From:   Quentin Schulz <quentin.schulz@theobroma-systems.com>
In-Reply-To: <20220510094607.2ijaw6we6jml2bv7@uno.localdomain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UE9RQU4zblpTNUxTMDM2Rk1JbVp2dVRybDlzTkt3cUdvQnhwY1NsdHVocFhi?=
 =?utf-8?B?RDBXU1BpNmRZWmNNSTYzekZSaFhzZTBKUzFLUkptTHJIVXVYejBHaUFYUCtW?=
 =?utf-8?B?aVN4TDVXcnVwMnNGNFlQa1dVR3lqcjJWVlQ3VmJFM0dnQ3Q4bFU2R3lUQmdr?=
 =?utf-8?B?VGt0Z1lUcS9sdEVyLzJTOVAzUDAvVVFISHAyUjBvdlRXWVFhOEpEcTFXZi9G?=
 =?utf-8?B?UExydXZQSW5icTNGc1F2ZGJwK1liWUx2S2FjNzlWUzhNTGhBdVUxYTJPREZr?=
 =?utf-8?B?YlR0MUZ3ai91Z2s4YWxJN09FOEJrcVNGd0QvZDE3ZnV1T0dFc3BTbXRxMkpw?=
 =?utf-8?B?UkcvNS9McmxSd1daa3QwWi9jSFNkNlNXWUVvWUhFUG56dlhYWTh6ejlFWmFD?=
 =?utf-8?B?aFBoN1MzZ2Nlc2hxS213VVhvWkR5QnMxSVFNeHhOdGZHWWJQZ1o3WlN1QVBt?=
 =?utf-8?B?VlQvVDhnNTJlNVpNNVpZZm5zaEc4bGNwaTVsbUNabmdwZ1FwV1Q3Z0pwblov?=
 =?utf-8?B?UFRZYmRCZzEyaGw2YTFsMnRIMDJEaUI2ZkNQWEQwVHhsdE42dFgzY1Noc3Qr?=
 =?utf-8?B?T1RFcytoQ2ppN1FkTzVFcXl4aXc3b3VsZUVMR283a2x5Z3ZuZlZrUjZYWjJI?=
 =?utf-8?B?dGhraFN0UDdMbzhOSEN3T2lodnRIYjIxeGFxcFh1aUhGbUVwUVB0cDZSL2dR?=
 =?utf-8?B?UmozR2JCMktHeng0TmVMWXBtQ0pzdFhYdzVNMy9xeUUrWElCUmtBOTZhT2tH?=
 =?utf-8?B?c1pNM212N1dsd2EvMmZyaGF4MDZ6dVZYZzMyN2tma214aGg2Ri95dmhZb2dj?=
 =?utf-8?B?TUJxb2pyVWVBWGZwVWdRT0lEMkJvaGRjVGtybjNoMzdBRGtzakhJU2Z1ZXU4?=
 =?utf-8?B?TWIrRlM3b2VacFYvVGh4Smg1OGJXY0tGTURKaWRETDJNZjB0d2x3bTZnNmpl?=
 =?utf-8?B?Wm83MTZMUUZnZ2tzMGdLQ2trMG1aRGxrTEhqby9lb2RyZ0ZycXI1NHlJamMr?=
 =?utf-8?B?c096K1IxdmtEMlNmaTB1NTNuSUYxNzJWYkF2cVhtSFZyRFJWOE5LU1dYQ1Q4?=
 =?utf-8?B?YmJKajN5MnJNdThGVnZaTXBLTXE2akVic3o3VWcwNzUrZHFMa3JHbDFoUkpB?=
 =?utf-8?B?QUlvRzdaeEU2RnRlWjV5aGhKQitra2o5bkNPa01QNnYydWJaQlprVldYczZW?=
 =?utf-8?B?T3RYN2Rab2Jrd0JXVVlHdWFyMDZORFJweGpsN0JPbUpVU0JJS1lRM1k2ZVNO?=
 =?utf-8?B?aUh1ZjZLbzR3MTkyT25DaHhCdThSUGtIZ2pmbTcwaWt4N0RhR2ZsRENVRDZS?=
 =?utf-8?B?alBiMVhJSi93REJwdFF1RDZ4QXhNNjRWVW9CS3lZZCtWb2VPTkdIK1FhN3dJ?=
 =?utf-8?B?RXdqb3oyRzM3WGdvMXVHTnloUUJuWmFVb3B1SnBVUjVYOU5rRGJId1Mvelp5?=
 =?utf-8?B?RmMvTWJteFVTRU9mMnJRTFIwM25jdEx2VnBNdFlmT2VSL1NZNGVFSUs0d3BS?=
 =?utf-8?B?TkdpRFBKWTVLeWlia0dMczFxYzVXaWVmOWQwazk2SDJWMVMxbmxxd0s2cTZL?=
 =?utf-8?B?UDBKeTRUNHQ5RUsrdnMzVVM1ajBUcjgzOWh6MmZib0x1TDZjc1JucFcvY0dn?=
 =?utf-8?B?K1Z3cVYzamI2T0tGblpzcHdLMW5DWFhpRTJzSDN5a2EycjNwZWRwRGpLeHJr?=
 =?utf-8?B?Z1VpSHBxNWpOL0ZCOFY3S2lXVHpiTjRGOTdFWC9GOXhRNk1DNnV2R1NMZGR1?=
 =?utf-8?B?cUFnV1M3M1daSk1pd2lzaGplYS9yZGVaWTRZYW5jb0hWN2pDOTdUdEx3T2Fl?=
 =?utf-8?B?OTBjWUFjWjBtTGViYzVlUzRqMk55N3ZhVENjTjJVSjNweGNqNWNVQUFKK2VU?=
 =?utf-8?B?N2FVQ3JLdTlOaDlsaklWQVhVbE13ZlkxYnd1ZGczbW9sVnFudVJYT0FjZ2Rp?=
 =?utf-8?B?MHpwVzMzSE5iUUg4NlowenpuTVVORmlDWGx0NmVpS3VWQ01rbHV1dVJPYVNz?=
 =?utf-8?B?bWZJRklMSDRiSUFxWmxjSWNnVVdFVFVRUTVkVkdYaDIrRW4wYTZLaGY1Vk5B?=
 =?utf-8?B?MFg3c29DUnY4c2RXOEJlTDZaVmdmR043OE5uS0VwTG5VMUhnUytwOVd4L1Jp?=
 =?utf-8?B?amNDWEVyWGt3cWpvNFdOdUxueDNSaVB1RTBPWWwxRXM2Y3BkMXdGTEZMQ0M5?=
 =?utf-8?B?QzNZd0xKRFdIaG5JemdoclEybzJyWGdMZC9lL3V6enlCb2lURzFXeXV2MDVN?=
 =?utf-8?B?dVBnWUJaUGVuTnRGcmlYdXBUY09GWHN0S3pXSzErSXRDQ3JOeDJvZkZ4Q0Jm?=
 =?utf-8?B?RjJwUm04YU5lNGJCQm9JRitWYUVkS3BkUVg4OGJhMEhGSWZUb1NmaHFVL2sv?=
 =?utf-8?Q?zBajPBQugMpKLbUbOqyFqQJypvP/zADvtEXac?=
X-OriginatorOrg: theobroma-systems.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bb131da3-58cc-4279-1504-08da3e482a36
X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB9378.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 12:14:49.4520
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5e0e1b52-21b5-4e7b-83bb-514ec460677e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DP1Q0HPysdE2xdFmA0LheeSRcdJJdsMss4Isu8NbeX1tQiwbUgv18chdvf6z/6/o9LV0fotMO8pV3sBpYdkFQAx0qShPqPpUyLSaW/EYdoegZuUKSk3ncLjG5eVtNrVV
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5461
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jacopo,

On 5/10/22 11:46, Jacopo Mondi wrote:
> Hi Quentin,
> 
> On Mon, May 09, 2022 at 04:32:24PM +0200, Quentin Schulz wrote:
>> From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
>>
>> Until now, this driver only supported ACPI. This adds support for
>> Device Tree too while enabling clock and regulators in runtime PM.
>>
>> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
> 
> Thanks for addressing all comments on the previous version.
> 
> Looks good to me!
> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
> 

I didn't add your Reviewed-by in the v4 because I modified the 
resume/suspend functions, hope this is ok with you.

Thanks for the reviews.

Cheers,
Quentin