Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Dmitry Rokosov <DDRokosov@sberdevices.ru>
To:     "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "jic23@kernel.org" <jic23@kernel.org>
CC:     "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        kernel <kernel@sberdevices.ru>,
        "stano.jakubek@gmail.com" <stano.jakubek@gmail.com>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "lars@metafoo.de" <lars@metafoo.de>,
        "andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
        "stephan@gerhold.net" <stephan@gerhold.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] dt-bindings: iio: accel: add dt-binding schema for
 msa311 accel driver
Thread-Topic: [PATCH v2 3/3] dt-bindings: iio: accel: add dt-binding schema
 for msa311 accel driver
Thread-Index: AQHYcGNsHieJqKs6FU67Uad334M2Aq0vuKGA
Date:   Wed, 25 May 2022 18:32:45 +0000
Message-ID: <20220525183255.lc7hmmcfj47yrxc3@CAB-WSD-L081021.sigma.sbrf.ru>
References: <20220525181532.6805-1-ddrokosov@sberdevices.ru>
 <20220525181532.6805-4-ddrokosov@sberdevices.ru>
In-Reply-To: <20220525181532.6805-4-ddrokosov@sberdevices.ru>
Accept-Language: ru-RU, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7F17E0A41BA3844FBDBE49EB9ACAC5FF@sberdevices.ru>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Precedence: bulk

Hello Jonathan and Rob,

I didn't change two places which you mentioned in the v1 review, please
find my comments below.

On Wed, May 25, 2022 at 06:15:33PM +0000, Dmitry Rokosov wrote:

> +  interrupt-names:
> +    const: irq
I stay interrupt-names node here, because otherwise dt_binding_check
command shows such a warning:

=3D=3D=3D=3D
  CHECK   Documentation/devicetree/bindings/iio/accel/memsensing,msa311.exa=
mple.dt.yaml
Documentation/devicetree/bindings/iio/accel/memsensing,msa311.example.dt.ya=
ml: accelerometer@62: 'interrupt-names' does not match any of the regexes: =
'pinctrl-[0-9]+'
=3D=3D=3D=3D

I can't delete this node from the example as well, because it's required fo=
r
msa311 dts i2c irq declaration.

Please help me to resolve this problem properly if possible. If we can
ignore such warning I'll delete interrupt-names in the next patchset's
version.

> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    i2c {
> +        #address-cells =3D <1>;
> +        #size-cells =3D <0>;
> +
Properties #address-cells and #size-cells are still located in the
schema example, because otherwise dt_binding_check raises the below=20
warnings if we delete these properties:

=3D=3D=3D=3D=3D
  DTC     Documentation/devicetree/bindings/iio/accel/memsensing,msa311.exa=
mple.dt.yaml
Documentation/devicetree/bindings/iio/accel/memsensing,msa311.example.dts:2=
7.17-30: Warning (reg_format): /example-0/i2c/accelerometer@62:reg: propert=
y has invalid length (4 bytes) (#address-cells =3D=3D 2, #size-cells =3D=3D=
 1)
Documentation/devicetree/bindings/iio/accel/memsensing,msa311.example.dt.ya=
ml: Warning (pci_device_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/iio/accel/memsensing,msa311.example.dt.ya=
ml: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/iio/accel/memsensing,msa311.example.dt.ya=
ml: Warning (simple_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/iio/accel/memsensing,msa311.example.dts:2=
4.13-32.11: Warning (i2c_bus_bridge): /example-0/i2c: incorrect #address-ce=
lls for I2C bus
Documentation/devicetree/bindings/iio/accel/memsensing,msa311.example.dts:2=
4.13-32.11: Warning (i2c_bus_bridge): /example-0/i2c: incorrect #size-cells=
 for I2C bus
Documentation/devicetree/bindings/iio/accel/memsensing,msa311.example.dt.ya=
ml: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/iio/accel/memsensing,msa311.example.dt.ya=
ml: Warning (i2c_bus_reg): Failed prerequisite 'i2c_bus_bridge'
Documentation/devicetree/bindings/iio/accel/memsensing,msa311.example.dt.ya=
ml: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/iio/accel/memsensing,msa311.example.dts:2=
5.30-31.15: Warning (avoid_default_addr_size): /example-0/i2c/accelerometer=
@62: Relying on default #address-cells value
Documentation/devicetree/bindings/iio/accel/memsensing,msa311.example.dts:2=
5.30-31.15: Warning (avoid_default_addr_size): /example-0/i2c/accelerometer=
@62: Relying on default #size-cells value
Documentation/devicetree/bindings/iio/accel/memsensing,msa311.example.dt.ya=
ml: Warning (unique_unit_address_if_enabled): Failed prerequisite 'avoid_de=
fault_addr_size'
=3D=3D=3D=3D=3D

What is best way to resolve such issues without providing #address-cells
and #size-cells values?

--=20
Thank you,
Dmitry=