Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <aa897c48-57fc-5336-e62c-333ec5cf3416@vaisala.com>
Date:   Wed, 25 May 2022 13:08:19 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH V8 4/5] iio: accel: sca3300: Add support for SCL3300
Content-Language: en-US
To:     LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>, jic23@kernel.org,
        lars@metafoo.de, robh+dt@kernel.org, andy.shevchenko@gmail.com,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     thomas.haemmerle@leica-geosystems.com, linux-iio@vger.kernel.org
References: <20220523062312.1401944-1-Qing-wu.Li@leica-geosystems.com.cn>
 <20220523062312.1401944-5-Qing-wu.Li@leica-geosystems.com.cn>
From:   Tomas Melin <tomas.melin@vaisala.com>
In-Reply-To: <20220523062312.1401944-5-Qing-wu.Li@leica-geosystems.com.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tit5d0JRRFRaL0ZFS2psYnRxL3c3c3dsTzdOZjl3cDFJVVVZa2pqUUZVNkNO?=
 =?utf-8?B?UXlVb3hKbU5aV2xFMDlQb0tkcUg5ZGRwQVFkQkkwZmFabmZsUXNnYXVTWTFa?=
 =?utf-8?B?WTZNT2ZXYW1vRURSQTZiWFFRNnRLbVVOeHJBb2xiZEhaSm9UY0lRVXJhZUNi?=
 =?utf-8?B?YzUrM25mU3V5TkZyWmhBYjRuWFhyZnE0VVYvSUNUSzhGb1RJZVNzZmNXZlRI?=
 =?utf-8?B?NDNidmV2aXpIWVAvajdsWlh4dnJrRVVvM0lxNDJVNE9wbitNTHdObFpLdTdZ?=
 =?utf-8?B?ZldsemVwVFFlRUR0RFNqY3ZmMURNdGJHaG5rYU0rZ0ZiVnBYTktYN0JSVFVu?=
 =?utf-8?B?QzhvVWtCMDBhL21HOXdoSVJQMjNaQ0hpQVh5NEIxRHdRdkdVTlZkc0dTbzZ0?=
 =?utf-8?B?WndnTFRzMWZ2L1M5TElkYytFdmE4d09WVml2UTcxWVJZSWtYVVFNYklzQURF?=
 =?utf-8?B?KzBlL2dDbDd0Y3kwMktiRDB3UmhENjMwTit0bkdCalRtajF2QzJ5Yk80aFNy?=
 =?utf-8?B?SjN4RFZXY0puTlk5YkxORTNIbW9iaXcwZHp2bm0xWTJvOExBNnVBbEdMS0t4?=
 =?utf-8?B?SFNaVDhzZWVOcERYdDNqeXUycVc4dzVWcEZHUXNjQ0Y4VHc2aWRJNm5oTjk1?=
 =?utf-8?B?OXZMb2dKOVJ3OElNcVFWSkI2YUl0RWFKT1VhblYyNGZxR3BQMm5uRS9BYlNF?=
 =?utf-8?B?RXhETEtSZGh2d2JrWVNkR1BtQmxqSURHYmZZMElnb3FQcEtWNzNzMTBlcG04?=
 =?utf-8?B?ZHUxZVJ3RFgvaG5Ydzl6ZUFjdmd5dUxxUWF2WDVUNzN3TzRoQXphOGw1Ulln?=
 =?utf-8?B?c1dzZG1jMEMxbUF0RHVoc2pPWmpFZkY1WDZGNFVScDN6NzFsY2diY1oxMkdK?=
 =?utf-8?B?LzdmcjFudEl4cFhJdGp2YU9Sc3hHcEZFWHY3OTZLaG5lTEcwb0c3b1N2UHZW?=
 =?utf-8?B?VGFmUld1dk9xc0YyOFZOWlFmMk1Lcll6ZU1jRU1RbjFWWlI3aUdRdXZPbExR?=
 =?utf-8?B?b1VINVU3TXBsUUNiOG8rQ2ZUaTBSQTdZVk5INXFTMlRTenhDQjJmb2FDS3c2?=
 =?utf-8?B?QlNUZmpQVGFlZXdjcmtxL09zVWo1TXBOT0J1Q2lUSmdHZ3ZuZkROWlowbFZq?=
 =?utf-8?B?T1hVNjVhek5DRk5rU1czdzlIdnNBTFNKWTFXWWlvY3BkOEtuQUwxZzc4QUNM?=
 =?utf-8?B?blBhNmprS3VwVm1jZDZEZjdhUngwdnlUa3E2VTQxQk15M0JWMWk1WGk5L1py?=
 =?utf-8?B?cWpjVkhRSGFXeHN6eVFzN2huM0g5OWMyYkdvQU5XbXdOR1lZOFJ4V0tmU212?=
 =?utf-8?B?S3BwRko4UFNYaHBDMWNRdzZZK2huS1llM2I1ZUdWaUw1NHFTT29OV3ZheHNQ?=
 =?utf-8?B?YXZETVpJR2tvMDdCVVZpN0t5eWR6VjhWcnNLSjNZQUtUUVhRWGtqYzhyZlVZ?=
 =?utf-8?B?eVFXSndNNDdmWGpvY3JaUm5jYzdRYzJ6QXBISGltUTNKTTIxU2FTWjF5SnZ0?=
 =?utf-8?B?cG1PT2ZtckdoTFdQT1dXNHZ2bTc0TmtkUHNyUGZwRG5hR3NGSEFxR0pVK3Zh?=
 =?utf-8?B?aDJlK2FJbCtnVFJseU1xTmpXM3V3eStrVDJkYWZXNTlqdVFIYkg3K0J4K0hF?=
 =?utf-8?B?ZDlsUmRmR0ZQdUVEZWhReERDT3Ztak0rZG5pODB5WGhQTFE3bGRWcXp3bFlO?=
 =?utf-8?B?QWZleGtpb3lKMk4xR3ZJT3pYT0NqN3VpOEg1WGJ3Z05OMUtIanNINWZSTW5a?=
 =?utf-8?B?cjk3WlJ2QjNJVWVKODV5K0E5UGlvclJHekRLdU9zUm0vcWR3RmRtOFc1VDVa?=
 =?utf-8?B?aHRUSkpYNDRZT1hqOU8xdE5Ma3grVUNnOVp2Y1JmY0V2Qm52SzNVUzdCRS9z?=
 =?utf-8?B?dkRVZUlBSnVEbFk4MjJtQ2p5Y01jYWFZTHV2RWFBNHlZTW9ZQWZ6dllTSmtN?=
 =?utf-8?B?UVNDWDhWemM4NlpPMGxjbXRyaTVBelJObFVLVS9ZMWRpLzFTRDI1QVp4YWVV?=
 =?utf-8?B?NXUvV2lLTG1IendwaGI0S1VieFI2TGQ2SnZYS3R6aWhucXZQV2wyamsxR1NH?=
 =?utf-8?B?SFBzNWJYSjRFVFdFR0xDQ1J3ZHZxbEtmcUFxdU9DM2hRY3o1ZlpyZHJGWGda?=
 =?utf-8?B?T0k5Y0U5ZEpQeTRkT3Z1OVZUTGl2Y0dUMU5BVGhMSkdWRjlVMDF2WTI2bFFL?=
 =?utf-8?B?Y1FMTHl2dW5idUVwaW1HT3Z1SDBqZXM0eUhuK1plMXRuMHdpRFlmMnpzMzFW?=
 =?utf-8?B?T2NSbXV2ODg0K2Z2UG83WDVyN2I1MkhReHlYUHVzWEh4RVR4bkppUHBpazhJ?=
 =?utf-8?B?RUJWMStOM0h4T0JKUVBiQWFobys5bGV5OTJjNDgwQ0k3VE4wNlJ3Y0JmVCtG?=
 =?utf-8?Q?Iug5ReatfmTsZRBc=3D?=
X-OriginatorOrg: vaisala.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f6f8df9d-353e-45a6-a3ad-08da3e367f92
X-MS-Exchange-CrossTenant-AuthSource: HE1PR0602MB3625.eurprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 10:08:21.7694
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 6d7393e0-41f5-4c2e-9b12-4c2be5da5c57
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DeyaYOGIyx0WHw4PkObMrK8aG9ARTQaQCiOSwYJSsEkbYUXxRE2a2JIUBT5bOxg/icI0aryezU1ILbJMEUKmnw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR06MB7489
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 23/05/2022 09:23, LI Qingwu wrote:
> Add support for Murata SCL3300, a 3-axis MEMS accelerometer.
> Same as SCA3300, it has the accelerometer and temperature output.
> 
> Datasheet: www.murata.com/en-us/products/sensor/inclinometer/overview/lineup/scl3300
> Signed-off-by: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>
> ---
>  drivers/iio/accel/sca3300.c | 31 +++++++++++++++++++++++++++++--
>  1 file changed, 29 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/accel/sca3300.c b/drivers/iio/accel/sca3300.c
> index 6463d12a9ab9..74e780a7ffcd 100644
> --- a/drivers/iio/accel/sca3300.c
> +++ b/drivers/iio/accel/sca3300.c
> @@ -38,6 +38,7 @@
>  /* Device ID */
>  #define SCA3300_REG_WHOAMI	0x10
>  #define SCA3300_WHOAMI_ID	0x51
> +#define SCL3300_WHOAMI_ID	0xC1
>  
>  /* Device return status and mask */
>  #define SCA3300_VALUE_RS_ERROR	0x3
> @@ -96,10 +97,18 @@ static const struct iio_chan_spec sca3300_channels[] = {
>  static const int sca3300_lp_freq[] = {70, 10};
>  static const int sca3300_lp_freq_map[] = {0, 0, 0, 1};
>  
> +static const int scl3300_lp_freq[] = {40, 70, 10};
> +static const int scl3300_lp_freq_map[] = {0, 1, 2};
> +
>  static const int sca3300_accel_scale[][2] = {{0, 370}, {0, 741}, {0, 185}};
>  static const int sca3300_accel_scale_map[] = {0, 1, 2, 2};
>  
> +static const int scl3300_accel_scale[][2] = {{0, 167}, {0, 333}, {0, 83}};
> +static const int scl3300_accel_scale_map[] = {0, 1, 2};
> +
>  static const int sca3300_avail_modes_map[] = {0, 1, 2, 3};
> +static const int scl3300_avail_modes_map[] = {0, 1, 3};
> +
>  static const unsigned long sca3300_scan_masks[] = {
>  	BIT(SCA3300_ACC_X) | BIT(SCA3300_ACC_Y) | BIT(SCA3300_ACC_Z) |
>  	BIT(SCA3300_TEMP),
> @@ -159,6 +168,21 @@ static const struct sca3300_chip_info sca3300_chip_tbl[] = {
>  		.num_avail_modes = 4,
>  		.chip_id = SCA3300_WHOAMI_ID,
>  	},
> +	{
> +		.name = "scl3300",
> +		.scan_masks = sca3300_scan_masks,
> +		.channels = sca3300_channels,
> +		.num_channels = ARRAY_SIZE(sca3300_channels),
> +		.num_accel_scales = ARRAY_SIZE(scl3300_accel_scale)*2,
> +		.accel_scale = scl3300_accel_scale,
> +		.accel_scale_map = scl3300_accel_scale_map,
> +		.num_freqs = ARRAY_SIZE(scl3300_lp_freq),
> +		.freq_table = scl3300_lp_freq,
> +		.freq_map = scl3300_lp_freq_map,
> +		.avail_modes_table = scl3300_avail_modes_map,
> +		.num_avail_modes = 3,
> +		.chip_id = SCL3300_WHOAMI_ID,
> +	},
>  };
>  
>  DECLARE_CRC8_TABLE(sca3300_crc_table);
> @@ -443,9 +467,11 @@ static int sca3300_init(struct sca3300_data *sca_data,
>  
>  	/*
>  	 * Wait 1ms after SW-reset command.
> -	 * Wait 15ms for settling of signal paths.
> +	 * Wait for the settling of signal paths,
> +	 * 15ms for SCA3300 and 25ms for SCL3300,

> +	 * take the max of the then.
There is now a typo here, but I think this line could be left out
altogether. i.e.

> +	 * Wait for the settling of signal paths,
> +	 * 15ms for SCA3300 and 25ms for SCL3300.


Thanks,
Tomas

>  	 */
> -	usleep_range(16e3, 50e3);
> +	usleep_range(26e3, 50e3);
>  
>  	ret = sca3300_read_reg(sca_data, SCA3300_REG_WHOAMI, &value);
>  	if (ret)
> @@ -572,6 +598,7 @@ static int sca3300_probe(struct spi_device *spi)
>  
>  static const struct of_device_id sca3300_dt_ids[] = {
>  	{ .compatible = "murata,sca3300"},
> +	{ .compatible = "murata,scl3300"},
>  	{}
>  };
>  MODULE_DEVICE_TABLE(of, sca3300_dt_ids);