Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933884AbXEPTfA (ORCPT ); Wed, 16 May 2007 15:35:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757309AbXEPTew (ORCPT ); Wed, 16 May 2007 15:34:52 -0400 Received: from mailer.gwdg.de ([134.76.10.26]:56680 "EHLO mailer.gwdg.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756332AbXEPTev (ORCPT ); Wed, 16 May 2007 15:34:51 -0400 Date: Wed, 16 May 2007 21:28:07 +0200 (MEST) From: Jan Engelhardt To: Bharata B Rao cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jan Blunck Subject: Re: [RFC][PATCH 8/14] Union-mount lookup In-Reply-To: <20070516050851.GB4403@in.ibm.com> Message-ID: References: <20070514093722.GB4139@in.ibm.com> <20070514094218.GJ4139@in.ibm.com> <20070516050851.GB4403@in.ibm.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Report: Content analysis: 0.0 points, 6.0 required _SUMMARY_ Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 762 Lines: 27 On May 16 2007 10:38, Bharata B Rao wrote: >> >> >+lookup_union: >> >+ do { >> >+ struct vfsmount *mnt = find_mnt(topmost); >> >+ UM_DEBUG_DCACHE("name=\"%s\", inode=%p, device=%s\n", >> >+ topmost->d_name.name, topmost->d_inode, >> >+ mnt->mnt_devname); >> >+ mntput(mnt); >> >+ } while (0); >> >> Why the extra do{}while? [elsewhere too] > >Not sure, may be to get a scope to define 'mnt' here. Jan ? What I was implicitly suggesting that mnt could be moved into the normal 'function scope'. Jan -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/