Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a41683f3-8d47-2b51-2034-d7b19caf702f@oracle.com>
Date:   Thu, 26 May 2022 04:12:15 +1000
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.9.1
Subject: Re: [PATCH v4 0/4] kernfs: make ->attr.open RCU protected.
Content-Language: en-US
From:   Imran Khan <imran.f.khan@oracle.com>
To:     tj@kernel.org, viro@zeniv.linux.org.uk, gregkh@linuxfoundation.org
Cc:     linux-kernel@vger.kernel.org
References: <20220519072658.736370-1-imran.f.khan@oracle.com>
In-Reply-To: <20220519072658.736370-1-imran.f.khan@oracle.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UHh3dTN6eENTNnh5czJMMXpXaktTYy92RXlwR3BianRNZWk2ZVRQTjFjWENL?=
 =?utf-8?B?cCtNR0pqUTdkTlZGdHFxRG1ScXcxUkF0Zy9YMXRhWG1aVGFHY3NQY01jb2FG?=
 =?utf-8?B?ZWIzbmhSZ2Ntakk3cFdtVGtmZW11U1J3OFhGLzNKbldkV09lajJXcmNXTFh0?=
 =?utf-8?B?OGdVYXFhbGtUYVQwbW9iTDBEdkl6U3NkZE5ZaXhRakxsUElTdGFnM0FWSDRJ?=
 =?utf-8?B?WDIvL3VPOXVoQjBWdFlHUkFHYlJYZDVtYjdXSURvWjBoRy9MZkthVXVzc3BF?=
 =?utf-8?B?Ly80ZmcrOFhoSEdrTXNRSkdvallwYWlHUXk2L3FibFZyOTdzN2lCWWcvQy9m?=
 =?utf-8?B?UUpIRDNIV2ZQdVU2QzlvMGltb0hjeTNOMW51TWpQTWJmeUUrTll6Y0VSemw3?=
 =?utf-8?B?SXYrWmNSTVhFZ2pST1htdk9RN0xWemRDaTEzYnUyNVpvTzBSaVdEY1o5YXow?=
 =?utf-8?B?SUhrdUZMcXNQYW9Uc0xBSlNDL3JzTmRiQVpFZ2xhd3ZPUnhMYWpabTdWOFk4?=
 =?utf-8?B?MlZxVGRuV256byt0Z2gzUjNJQjY0VVgzQk1tUXE4SXAzMWZsdmdwWUJXOXdx?=
 =?utf-8?B?TnRwZzJsS2J5WmVDZm1VY1ZyNjFKT0QrQzFGc1l3ZHFja1crL1BKRk9Uc0Fi?=
 =?utf-8?B?alI5ZXlEUWl6SFBSd2pDOTNCTStrR21tVU9GbUdHNHFlRkVrTENsMU9Cc3Fw?=
 =?utf-8?B?a2grZFIvOGhRUEQ1UmJJb3BmcTdvM2o0c0xzb2M3QTNVbWx3ejZvVG5ZRm55?=
 =?utf-8?B?djZPbnJtNmhNalQwY3ovSXdzSm11YWRoSy9DZmxSNzgyTkFyWnFGaDF5Y1Jy?=
 =?utf-8?B?S3BiRmFINzJINElGMk5CQng2TEFobEYvT3A3K0ZsLyt5S3Y3WU94SGozZ051?=
 =?utf-8?B?SUNjZytOcXpJaTdleW5VYU9VZkVmem1jREQ4dFdsaXJZN211aGxPWlBjVU5S?=
 =?utf-8?B?T3ozRGtpc3VNblVEdlgvK09VMVR0L3prdHNGaFluc21xbmlUbHhDRDNpSHJs?=
 =?utf-8?B?QlVPL2h4c3JEdXUxb2NLYUxtdVI1c044a1FCZGRqbWcvUXYvMGhQV3BsT3BD?=
 =?utf-8?B?RDB4TFRQc21CcEZnVWFlZWp4SGMrNVAwSXEyOVQza091aXJrQitsNGJvVWRU?=
 =?utf-8?B?ZHNPc1pPbVVWSzZtRkNCSEJ4TnRRSGhCRzRzQ3VlUEtiajBtTlMwa2Z1d1BQ?=
 =?utf-8?B?MnIvcElQY2w0UWh1aWJ0L3ZHWHpGTFVjUUdqOEVYUjVDNW9ocHNraTl1S05D?=
 =?utf-8?B?N0txelp6TGRuQ0pNVGxZZGpCWmRNUkY4MXl0YWJlcWxVY0trdmNaV0xRSklu?=
 =?utf-8?B?NmFTbFpVMGd3QWpBTkl4ZFpnYldPZzU2VWJpMnpKdFo2U1YyTGVtM0ZjVFFU?=
 =?utf-8?B?dVM4MVpKRUp1a1loQm5lRFVOVUZ6OHE2djNkSE8xbVJYSXUvSktsZ243d0FO?=
 =?utf-8?B?MkJPWWhFcVcrTWgvaW44eFEvNkdxUTEzUngyQ1hzVCtIMUttemlHVitaNWho?=
 =?utf-8?B?aGFpNHozM0NSWExMNFI2aFJGeElmTEFLL21LYllsOTlNa2hFdGs0TkMyM1Nv?=
 =?utf-8?B?dnMzbitOL2pFK1ZUaWJhVjQ3MVExME5ld29YaVloWlJFOTRaUVROLzlNS1lm?=
 =?utf-8?B?SVZzY3JOM3RlVFR1ZnUzdmRqQ3dGeldyZFhnYlUrY1BsYmZEZnVNK3BvNE8z?=
 =?utf-8?B?b1FOZmpNNStPOVJlclJqYktLLzFBOUpYY2h1MytXYkhnR1hQb1hreWN4OFA5?=
 =?utf-8?B?b2hLb3hadEtLRGJNNnAxb2RJdmphQml0NmI5Wng3Qy84a0x0NnIybDlmOFNO?=
 =?utf-8?B?bHQwU1I3S1JBdm1FVjZRYndVUzZMVHVHQmJHekNDZU9zcUwyZFB6VWovSG81?=
 =?utf-8?B?L0NWMTlDTFErbFFVQlFIY1ZpOEEySHlFd0JlVVR6OTJabytFODJBWUtSNEUy?=
 =?utf-8?B?a0tCcFNTMGRGdXNyL0dnSHkwcHVLbERVTzgwTUpLdUhKTnBwYzh1SDBnbXF4?=
 =?utf-8?B?d1dpaS8rWXN5OXhxVnNiUGs5WnZzNm1ZSm14SDBHM3JIMjk2WmNvRng5UEVv?=
 =?utf-8?B?R20vOWlYeHZlNXh3MUcxT2lrcmk2Y1BzMThTZEtGWmhubjBtbHN6Wkk5UjZt?=
 =?utf-8?B?K0NQQ0ErWVV5dXA1cGJoejkxYzBiV0pVNnR4SHAxaXpzYVQ2RGNncCtaM0Vt?=
 =?utf-8?B?aUVxY0xteTNRQkluL3d5MW50UHREUHZ0NzRHeHdQaVpIRDN2dGtCVzNmN2Vo?=
 =?utf-8?B?KzYrTEVpRnV5c3Y4akJ6NXF3dldsUHRISjNlV0VjMjV6c0dJNVdnaEJwMWo5?=
 =?utf-8?B?MGsvcTZLNDd4MTJqSDc1K2RyM1VzNEg3dlBXbEVxZHJDSWtlcTZ2WnBBZzNa?=
 =?utf-8?Q?dFZwxWEvUBR0eHtg=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d1dc232-2f9f-48e6-b7d5-08da3e7a1de5
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4468.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 18:12:23.8167
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8zsWwWaIoeKwhKeQ4d0BCn3xDbsF+Pkt6gg3Io3GMepiLRSFRol8GbTnDebepbhX7wSe8VUxl986peesTq1tiw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3048
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.874
 definitions=2022-05-25_04:2022-05-25,2022-05-25 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=919 malwarescore=0
 adultscore=0 bulkscore=0 suspectscore=0 phishscore=0 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2205250089
X-Proofpoint-ORIG-GUID: 7O3LMI42M2JZql-7rIg3RPcd7nIXSMlA
X-Proofpoint-GUID: 7O3LMI42M2JZql-7rIg3RPcd7nIXSMlA
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Tejun,

On 19/5/22 5:26 pm, Imran Khan wrote:
> The patches in this version of the patch set are as follows:
> 
> PATCH-1: Make kernfs_open_node->attr.open RCU protected.
> 
> PATCH-2: Change kernfs_notify_list to llist.
> 
> PATCH-3: Introduce interface to access kernfs_open_file_mutex.
> 
> PATCH-4: Replace global kernfs_open_file_mutex with hashed mutexes.
> 
> Changes since v3:
>  - Rebase on tag next-20220518
>  - Rename RCU access related helpers and update their description
>  - Address errors reported by kernel test robot
>  - Include Acked-by tags from Tejun for the acked patches (PATCH-2,3,4)
> 

I have updated the description of RCU access helpers and have addressed CI
errors as well. Could you please check this and let me know if it looks okay.
Patches 2,3 and 4 have already been acked in earlier version of this this patch
set and they have not changed in this version. It is just Patch 1 that needs
further review. Thanks again for your help.

-- Imran