Date: Wed, 16 May 2007 20:41:01 +0100
From: Al Viro <viro@ftp.linux.org.uk>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Richard Henderson <rth@twiddle.net>,
       Andrew Morton <akpm@linux-foundation.org>,
       linux-kernel-list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALPHA: TITAN - check for allocated memory
Message-ID: <20070516194101.GK4095@ftp.linux.org.uk>
References: <20070516181332.GB16348@cvg>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070516181332.GB16348@cvg>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 986
Lines: 26

On Wed, May 16, 2007 at 10:13:32PM +0400, Cyrill Gorcunov wrote:
> This patch adds checking for allocated memory
> which is used to hold AGP info. Also some whitespace
> cleanup.

Could you please not do that again?  Whitespace cleanup is nice as a separate
followup, but as it is it just obscures the real changes in patch.  Digging
out

> @@ -767,6 +767,11 @@ titan_agp_info(void)
>  	 * Allocate the info structure.
>  	 */
>  	agp = kmalloc(sizeof(*agp), GFP_KERNEL);
> +	if (agp == NULL) {
> +		printk(KERN_ERR "TITAN - cannot allocate struct of size %d bytes\n",
> +		       sizeof(*agp));
> +		return NULL;
> +	}

out of hundreds of lines in patch just makes review harder.  Incidentally,
%d is not size_t, it's int.  Use %zu, please.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/