Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <159491e5-942f-cec0-7ab7-2ff331916225@oracle.com>
Date:   Wed, 25 May 2022 13:44:04 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH] mm/x86: Remove dead code for hugetlbpage.c
Content-Language: en-US
To:     Peter Xu <peterx@redhat.com>, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org
Cc:     Andrew Morton <akpm@linux-foundation.org>
References: <20220525195220.10241-1-peterx@redhat.com>
From:   Mike Kravetz <mike.kravetz@oracle.com>
In-Reply-To: <20220525195220.10241-1-peterx@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MEltRTYvUUQ1MzZ6cFUrVDhtM1pHNk8zZURVY0Izd3FFdEVra3ROaGZKcm9R?=
 =?utf-8?B?bXRUN3BwN3pHaGhtc3d6eHc3U2RlOXpZQlRJQnloZ0ZuUWpTeWl4UlgzaEdn?=
 =?utf-8?B?RGU3QWIvN0lkeDdVWUVzQVhqYkdFYWVFbjhES3FBUzBHUHVxejB2bTYyZW9R?=
 =?utf-8?B?cjBwV3BqcGpkWldpb2tiSWJuc3I2c1BIeGRtMkw5UGxqb1dzbXFNR1VKaGpZ?=
 =?utf-8?B?bnFhZ040TFBvUnlRbkxEcTVGQWVtSXJkQnBDL2ZUK0gwL2RCdVk5WVRMbWMr?=
 =?utf-8?B?amRyd0ZoSWJxdFltQ0NEcTdhSmZqWXpsTytGaTViMmk5Q0hkNTEzaTRhU0FC?=
 =?utf-8?B?VzlDK09MUGJ3ZUxqcFczR0V0eXByZHdSSy90T2VKSXdBTVJTN0ZaeTNqNFJK?=
 =?utf-8?B?ektURFl6azNQNW5XQnBiNFk0b29VT2d5ZGNXZklQcVVURjYvd2VIWi9yUTVo?=
 =?utf-8?B?R0NZalllTlh2ckFnTEJMRTE0R0dRVVA2QXpManRUM0tZS21wTmlKOVdjRDBh?=
 =?utf-8?B?ZHZJQlRPQ0dLNGxDOE8rd0dERWNSd2E5ejA4dmpXdEtEZE9JaGtQdWsvUjFD?=
 =?utf-8?B?eGtWSmFKZVVhK3ZuZUpYVkFlRjN1L1lMR0tFcmV4emwwTm9zYnNoZHhpenVr?=
 =?utf-8?B?Z0xsQ0JrQzdKWS9QUDdEK2hHSE9vdVJkSkd2MTJsWE00VzFJSEYvMnAzdjVI?=
 =?utf-8?B?TEZHTnV0blRWVGJtbVZLaTlSK3RVTzA5SWVNVTBBUXFvaitnMnl1TXNjMXY3?=
 =?utf-8?B?elIzMTR1eU9zdlBqMW5DWWluWkc0M2g3S2hnb0tyTVFHL0RERjdhS2JQaEhS?=
 =?utf-8?B?SHJpYkRLM1E5ZUxRMkFNYmNiN1R6NzZacTJpcis4cFFPVEVpZU03czZRbHRZ?=
 =?utf-8?B?cUdrMjJhSVo3WUREQkY0eDdCMUtteGhQOWFrdE04a1pCc3BJSTZQeWUrTXkv?=
 =?utf-8?B?cUpzUXFaeVFYdXMzc24rYXczV3FXV3k0b1l3R25Fb2U4QnFBYXIwYWZYYWNP?=
 =?utf-8?B?V1lqV3E4OGxCMUdyWjZWb1RSQkJiQ25ZOE9wRjBidS9JU05TT2JEM2pRQXhY?=
 =?utf-8?B?M1dvd2tJSEtJQit5WVhpSWgvT1liWHJLd1d2UWN0bU9YRENuWVNWaUd5REVI?=
 =?utf-8?B?elhBeFcybnJTcVB5R1BJZWVQM2R6OXlHMmtFS2dhS2xUUm4vSms1enNGVXJH?=
 =?utf-8?B?aE5UVkd3NkZ2dDJsR2hhN1p4blFxdVgxU0dwZ2RScXphNCtNNUF6WGVqT3dF?=
 =?utf-8?B?V1NIK1RzVjRPTml0dHAvVDhxS0RYMnRKVllGU29ySWhhWnN6eE1aYW5XdFhW?=
 =?utf-8?B?TGd2cGtHanMrakJwMUNVVUVKTXgrZDhwVWxyYUM2ejBxb3BwWXJxcFdNK2k2?=
 =?utf-8?B?N0gzUjRDanpZSE85QTQyQWdOM0ErVDgrYU5RZ2xHRG1VKzY4NXJheTBsUm1T?=
 =?utf-8?B?UUFhZG94RDhkWElHMnFUSERaMFZPTUt5Wi93VHBmZ3NCNUszemdyNXd5dFRP?=
 =?utf-8?B?dVJvK2I2aXh1TW80QzhFd2hsMERoNE5SZ3BGL1ErY3QwcE8zZGtTMVRjK0N3?=
 =?utf-8?B?Qi8vWjl5M01oVnFzZndQczZFSEk5WEptMHhtL2x6MWRUV1pNcjd3a0gvK0JW?=
 =?utf-8?B?eXZab2YrKzdSRG9RdEt4UXdLamdVNzRJVXZTRGFVUXVxQVhZTUVvaC92dUZt?=
 =?utf-8?B?UHYvalVCMHdWdlkvdGZVZWp0M20vM3VlRkxhVnlHcUFUSUdYdXFWMjlzWjVP?=
 =?utf-8?B?YTVwUGVUVUluTEVTY3JWQ0JWeXZ4Uzl0M01CRzVoQVA2UUhicDhsZUtXUGNo?=
 =?utf-8?B?a2lmcklsSk04SlFIeVd3TWNEYUt5NWIrajdxaXBQVmhRdVFYdU5ydjRWT2pP?=
 =?utf-8?B?bnlVQm9SZEdIWFJnVDNWa1BTSkN5dk1tYTd6R2pwb0lCdTlNRVcwd0c3RkJa?=
 =?utf-8?B?NHZIMEdSSElUaUVWcDdrWjZTclNqbXZPYm5CVTFoQnU0Q1RYL1lPSE1qaUpJ?=
 =?utf-8?B?d2p1VVRJWXRPQ3JyemxHY2dtUzNLcTRwdXpMcVlDMkJEV1ZaS0h6UE5oN094?=
 =?utf-8?B?NGRCb0R0QW1oN3p4ZWU1TkdubE4vVEp2SlY3L2dqY05YdnhxWTI4YmQ5UkNF?=
 =?utf-8?B?b2RWd3dENmFJTGZ0R28xOEJ1T2FFNWV0MG8vRVpCaldtVVpEa2NtTXhkNVR2?=
 =?utf-8?B?ZlFhbVRPeDFDU2l0NUsvV0lLLzNIK2FDcllIQWNIdTZ4bjBPMjJNQVFMalVM?=
 =?utf-8?B?M0tBNnZOMmhpU0Q0N2ZPMnNuY2tiaTZQNm54dldBd2pZSzJ4NkZzWjlhYnlj?=
 =?utf-8?B?Q0s3WDFsbVpYd1RPOUpTSHR1dEw5LzFIV1g1SUJrbG5VTk94ak5Wd1dnVjJX?=
 =?utf-8?Q?q5a+JQT+ZR2tv9os=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2b010df9-6bc0-4ba4-93b8-08da3e8f4f63
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 20:44:06.2173
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3cUJ0llPrXthjTbS9QbdRzt7UlhRvkNO51Di3CA4iCL3b3mIpNDEpiBIZXHPJXXYY+mGL3RLtimjKeNM1ZjDqw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4619
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.874
 definitions=2022-05-25_06:2022-05-25,2022-05-25 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 mlxscore=0
 phishscore=0 spamscore=0 mlxlogscore=976 bulkscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2205250097
X-Proofpoint-GUID: iQ9p9kGBONQ7pOPs0NBQXnf3OefpoJnm
X-Proofpoint-ORIG-GUID: iQ9p9kGBONQ7pOPs0NBQXnf3OefpoJnm
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/25/22 12:52, Peter Xu wrote:
> It seems to exist since the old times and never used once.  Remove them.

Yes, and the code even assumes hugetlb pages are prefaulted.  i.e. No
page fault support exists.

> 
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  arch/x86/mm/hugetlbpage.c | 39 ---------------------------------------
>  1 file changed, 39 deletions(-)

Acked-by: Mike Kravetz <mike.kravetz@oracle.com>

-- 
Mike Kravetz