Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <be333969-560d-36da-79cc-9d223ad675a2@amd.com>
Date:   Tue, 24 May 2022 17:22:29 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH] drm/amdgpu/discovery: make amdgpu_discovery_get_mall_info
 static
Content-Language: en-CA
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        alexander.deucher@amd.com
Cc:     christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@linux.ie,
        daniel@ffwll.ch, Likun.Gao@amd.com, flora.cui@amd.com,
        yifan1.zhang@amd.com, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
References: <20220524081154.35061-1-jiapeng.chong@linux.alibaba.com>
From:   Luben Tuikov <luben.tuikov@amd.com>
In-Reply-To: <20220524081154.35061-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OW9UbTB3QnRHa0Yrd2kxT1NyaGdyVFU5bHQ2NmpSeGVzb2x4Q2l4VjZ3aVB0?=
 =?utf-8?B?cWJPZCtIOUZBNytKeVlrNUljUnVKNzN2VjZJU3I2VWZPM0RBTnBlVXpSZjFM?=
 =?utf-8?B?N3l1YUZFK29UTVNZZFBhM21ZZHpqcGkwZDNjenQyRmtYZ0NEZ2pIRjBUTEpi?=
 =?utf-8?B?QmExa2VBS0ZzUHVobE5SZ0xmdzR5RVFlVmJXSjF3R1lhWE5pdlZCa2xDcnRM?=
 =?utf-8?B?alovVTd2TjhDcnBQaHVxK3VYYWg3cmlOdjlPcXFhTHdxYmp3NWY2QmRZKzRC?=
 =?utf-8?B?aUNKM0FWdC9XK0JkZmFYeUJrdFpxZGhmNXdUSXZzZzVzbDNwVFVOeGNFS0wy?=
 =?utf-8?B?eUtSOVBFcjNOTFVOK2FoQThJUTNWUmxQVDV1NmVnMDlRdWtVL2F6RWZyYWpm?=
 =?utf-8?B?dUViUWZrZWc4UHhSQzlRWDRPaHMyWS9Fb0VaWEhwQUxTMXNvT2ptaTFDRW1y?=
 =?utf-8?B?SGtpazhIMU1UeUxTTGhrMXNvTFd4akRaVTFtM1RlSXZRTktFb1JnWXoyQ083?=
 =?utf-8?B?bTFaN1dPaWJFc1A1WjAyTVhyK3BIWjNyVTZibDhyRlVhb2sxN2NlL3BZMUZ0?=
 =?utf-8?B?OXdybEY0dXRDSWhhSk5uODBMdk5QeTQzNjhJRDM0bjdHdU5qMjYrTnB2eng0?=
 =?utf-8?B?TDREeHJScXI5VURNaFRkcnI3RkpmbHNnZEJDWnRHa0NpSVcrMHJDcFliSEdl?=
 =?utf-8?B?cWpQdlZiUGxUaW1DbGpaaEdGVk5ENWcrM251Q3M1WDVCMGdUTEVjT1FtSXpx?=
 =?utf-8?B?SXg2WVhaeU5tSXM4cGY3bGhaSjVHaWQ0MkgzTWVFVE1LcDNZblZqQlZFc0R6?=
 =?utf-8?B?aTAyV0hEejJ3Y3NQQ2tacngwbU55RCtPU0JuTFNkOVdhZWkrWlA5MDVaVmhl?=
 =?utf-8?B?ckpCdzBVMDF4TzNoaDFxTUpSN21zMkt6QUpJVHBSTGVURFMyQXRzV250Ukc1?=
 =?utf-8?B?Tm5vd3lQNEgxSU1yVjV6bWNqa01vWDdGcERHQWVwbWh0dGVJTmFsbmFDUmJF?=
 =?utf-8?B?VlMvZmZ3dE53U1hrU1lvNzRIc3Q2VHAyTndPcjJQUG5aWTZtZUVkWVpWZjQz?=
 =?utf-8?B?dTRvN3UrOElTd2hoVG9rTmFtRUkyRUdWMkRyRnIyaVR1b1R6elhGOUg4YWF4?=
 =?utf-8?B?NE5qQnhYMDBTOHhoSnFweXhEU3pZVnFQQ015WlY1azB6OEtWOXpwYlFYVFFO?=
 =?utf-8?B?MDJrTXg2OGhwVXRyUG9JZVdsek9JbHZkbGluZjRSRmhYdHRFckdSa1NHRHFF?=
 =?utf-8?B?cE9XWG9NSk5meCtneVN3ckV4MEJGQ21IdlV3U2swdEhhbG9iWDNiaHMrRURm?=
 =?utf-8?B?ZVdlWjVlUTZUWmxFWmpCMWhZS0FHN3pnMk9ZZ0NaVEFqMW5zVWdUSEVadkw4?=
 =?utf-8?B?T1VTZG1WYWQwSXBKeUM0OFV0aUUxVC9ZN3BEa2dPbXlteE92Y3lNNVZFbDNK?=
 =?utf-8?B?ZmhIaCtTTG12cEZhTHJvbjZscEJqT2drT3NHOTBUS0w5QU4yUWk1S0ZWdExs?=
 =?utf-8?B?eThpaXNsK3pRKzVjQlFCUi90V3lnbG5JRmUxanRtc2lXSnkrMnZ1SW1wVFpo?=
 =?utf-8?B?dkZCK0tmdnA1T2lrUlpWakhPYkpJb29rVlZwY2U3dFpWZkFiTEhrZStDN0U3?=
 =?utf-8?B?ajB5ZGpVNnNnYVZ5QUNodVhaeDRhQVJDVllWWWYyYytNZWpsaEVqKzBqa095?=
 =?utf-8?B?QStsUnhYWXRzeHlyWmJMUG43b3JnS1lmbE5YWmZDUXc1TVVuZjdLMG8wckxC?=
 =?utf-8?B?U2RmVTFUczJQMGRFNDBiemRVeUhQb0RlMk1rSmJzalphUjgrb3hScEl1Rzcv?=
 =?utf-8?B?YW5VdUVZd0VlNWpqSG5yQlJVUVhoc04zWnVnR1lkM3QrT2hDZzIyYTZOZlRG?=
 =?utf-8?B?cmRxRmpxeFh6dFRnMlp3RldwMGI5R3YrUlBlbDJjbTF4cDlsY29tbk1CRE1l?=
 =?utf-8?B?SFpzNDJsYSs3d2VpS2RtbmJZTS9mdmZ2bi9XQitXM0xxa3hhQnQ2MnZBUHJ5?=
 =?utf-8?B?ZSttazkrYTlrK0VGTWVlNU9ZR1k1RHBPaURwazMvdm5QcDNoa0JoT294ZjdG?=
 =?utf-8?B?QnR2eU1pYnBCTXYwMy9UejM2ekQ4RE9EV2FWSnlnNCsyYUhmekY4WkxTT2J0?=
 =?utf-8?B?TDArL3hjM2xRUW9RK1JDclBxZ2YxU3ozNGZqSkdxN1hGaVZIMzlaaStzNzY1?=
 =?utf-8?B?aFVXQzZuTjczYk5mdldJcGtpV2NiQUtwL0lBQk8rU1RPTkJUTWtHbFRkZ0JR?=
 =?utf-8?B?TW4wbjZHSi9JODJtMlRjaG9YcmhHSHBwMmVQUlYzZDB4NXZBb05HZUtCVDFR?=
 =?utf-8?B?Y0xOL2NlOFFrWmZxZUJpd0J2ZHM3WE9PdklmSWlqenhlcDBEYWZ1Zz09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1919e209-3750-4eba-7586-08da3dcb8581
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3370.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 21:22:35.5886
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RBRKFvwvaTCRUu7dTvNMQGPIdJyztqKpgenOL3u+eZYCQeTjix7/Hwuh7tlx5bOZ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4110
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This is already static, in our local branch, from this commit:

commit 6852e61a0917a2
Author: Evan Quan <evan.quan@amd.com>
Date:   Thu May 19 17:28:12 2022 +0800

    drm/amdgpu: suppress some compile warnings
    
    Suppress two compile warnings about "no previous prototype".
    
    Reported-by: kernel test robot <lkp@intel.com>
    Signed-off-by: Evan Quan <evan.quan@amd.com>
    Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

Regards,
Luben


On 2022-05-24 04:11, Jiapeng Chong wrote:
> This symbol is not used outside of amdgpu_discovery.c, so marks it static.
> 
> Fixes the following w1 warning:
> 
> drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1364:5: warning: no
> previous prototype for ‘amdgpu_discovery_get_mall_info’
> [-Wmissing-prototypes].
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> index 881570dced41..16cdfb30b013 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> @@ -1361,7 +1361,7 @@ union mall_info {
>  	struct mall_info_v1_0 v1;
>  };
>  
> -int amdgpu_discovery_get_mall_info(struct amdgpu_device *adev)
> +static int amdgpu_discovery_get_mall_info(struct amdgpu_device *adev)
>  {
>  	struct binary_header *bhdr;
>  	union mall_info *mall_info;

Regards,
-- 
Luben