Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 26 May 2022 13:32:19 +0200
From:   Jakub Jelinek <jakub@redhat.com>
To:     Peter Zijlstra <peterz@infradead.org>, Jan Hubicka <jh@suse.cz>
Cc:     "Paul E. McKenney" <paulmck@kernel.org>,
        linux-kernel@vger.kernel.org, Josh Poimboeuf <jpoimboe@redhat.com>,
        linux-toolchains@vger.kernel.org
Subject: Re: objtool warning, branch, patch, and .config (GCC bug)
Message-ID: <Yo9lQxpj9U+fQTKH@tucnak>
Reply-To: Jakub Jelinek <jakub@redhat.com>
References: <20220525173332.GA4008581@paulmck-ThinkPad-P17-Gen-1>
 <20220525173444.GA4010526@paulmck-ThinkPad-P17-Gen-1>
 <20220526080313.GM2578@worktop.programming.kicks-ass.net>
 <20220526080849.GF6479@worktop.programming.kicks-ass.net>
 <Yo9CCoEF7nOd6lQI@tucnak>
 <20220526094124.GN2578@worktop.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20220526094124.GN2578@worktop.programming.kicks-ass.net>
Precedence: bulk

On Thu, May 26, 2022 at 11:41:24AM +0200, Peter Zijlstra wrote:
> On Thu, May 26, 2022 at 11:02:02AM +0200, Jakub Jelinek wrote:
> > On Thu, May 26, 2022 at 10:08:49AM +0200, Peter Zijlstra wrote:
> > > On Thu, May 26, 2022 at 10:03:13AM +0200, Peter Zijlstra wrote:
> > >=20
> > > > Which is just bloody weird/broken if you ask me. What's worse, GCC-=
10
> > > > does the same. Only when I use GCC-11 do I get sensible code again:
> > >=20
> > > Just to clarify, I can reproduce using:
> > >=20
> > > gcc-9 (Debian 9.4.0-5) 9.4.0
> > > gcc-10 (Debian 10.3.0-15) 10.3.0
> > >=20
> > > The good compiler is:
> > >=20
> > > gcc-11 (Debian 11.3.0-1) 11.3.0
> >=20
> > Such fallthrough into another function is typically the result
> > of __builtin_unreachable (), either explicit somewhere in the code,
> > or invoking undefined behavior somewhere and __builtin_unreachable ()
> > replacing the UB code.
> > I'd need preprocessed source + full gcc command line to tell more
> > (as long as it is not LTO, with LTO that isn't enough of course).
>=20
>  $ make O=3Dbuild/ CC=3Dgcc-9 kernel/rcu/update.o V=3D1
>=20
> gives the compile command as:
>=20
>   gcc-9 -Wp,-MMD,kernel/rcu/.update.o.d -nostdinc -I../arch/x86/include -=
I./arch/x86/include/generated -I../include -I./include -I../arch/x86/includ=
e/uapi -I./arch/x86/include/generated/uapi -I../include/uapi -I./include/ge=
nerated/uapi -include ../include/linux/compiler-version.h -include ../inclu=
de/linux/kconfig.h -include ../include/linux/compiler_types.h -D__KERNEL__ =
-fmacro-prefix-map=3D../=3D -Wall -Wundef -Werror=3Dstrict-prototypes -Wno-=
trigraphs -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE -Werror=
=3Dimplicit-function-declaration -Werror=3Dimplicit-int -Werror=3Dreturn-ty=
pe -Wno-format-security -std=3Dgnu11 -mno-sse -mno-mmx -mno-sse2 -mno-3dnow=
 -mno-avx -fcf-protection=3Dnone -m64 -falign-jumps=3D1 -falign-loops=3D1 -=
mno-80387 -mno-fp-ret-in-387 -mpreferred-stack-boundary=3D3 -mskip-rax-setu=
p -mtune=3Dgeneric -mno-red-zone -mcmodel=3Dkernel -Wno-sign-compare -fno-a=
synchronous-unwind-tables -mindirect-branch=3Dthunk-extern -mindirect-branc=
h-register -fno-jump-tables -fno-delete-null-pointer-checks -Wno-frame-addr=
ess -Wno-format-truncation -Wno-format-overflow -Wno-address-of-packed-memb=
er -O2 --param=3Dallow-store-data-races=3D0 -Wframe-larger-than=3D2048 -fst=
ack-protector-strong -Werror -Wimplicit-fallthrough=3D5 -Wno-main -Wno-unus=
ed-but-set-variable -Wno-unused-const-variable -fomit-frame-pointer -fno-st=
ack-clash-protection -Wdeclaration-after-statement -Wvla -Wno-pointer-sign =
-Wcast-function-type -Wno-stringop-truncation -Wno-stringop-overflow -Wno-r=
estrict -Wno-maybe-uninitialized -Wno-alloc-size-larger-than -fno-strict-ov=
erflow -fno-stack-check -fconserve-stack -Werror=3Ddate-time -Werror=3Dinco=
mpatible-pointer-types -Werror=3Ddesignated-init -Wno-packed-not-aligned -I=
 ../kernel/rcu -I ./kernel/rcu    -DKBUILD_MODFILE=3D'"kernel/rcu/update"' =
-DKBUILD_BASENAME=3D'"update"' -DKBUILD_MODNAME=3D'"update"' -D__KBUILD_MOD=
NAME=3Dkmod_update -c -o kernel/rcu/update.o ../kernel/rcu/update.c
>=20
> I've attached the output of:
>=20
>  $ make O=3Dbuild/ CC=3Dgcc-9 kernel/rcu/update.i

Filed https://gcc.gnu.org/PR105739 for this, the replacement
happens during inlining, so I've CCed Honza Hubicka who knows
that code best.

It is unlikely anything can be done about this for GCC 9,
because the final GCC 9.5 release is to be released tomorrow,
there is no chance of getting it fixed by then, especially
when it doesn't look like a recent regression.

	Jakub