Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220525140410.1706851-1-zhengjun.xing@linux.intel.com>
In-Reply-To: <20220525140410.1706851-1-zhengjun.xing@linux.intel.com>
From:   Ian Rogers <irogers@google.com>
Date:   Wed, 25 May 2022 07:27:08 -0700
Message-ID: <CAP-5=fUm4G043v6-pToBiT-psxt-_r4kxtsWwkjLh=ARmhmP_A@mail.gmail.com>
Subject: Re: [PATCH] perf jevents: Fix event syntax error caused by ExtSel
To:     zhengjun.xing@linux.intel.com
Cc:     acme@kernel.org, peterz@infradead.org, mingo@redhat.com,
        alexander.shishkin@intel.com, jolsa@redhat.com,
        linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        adrian.hunter@intel.com, ak@linux.intel.com,
        kan.liang@linux.intel.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, May 25, 2022 at 7:04 AM <zhengjun.xing@linux.intel.com> wrote:
>
> From: Zhengjun Xing <zhengjun.xing@linux.intel.com>
>
> In the origin code, when "ExtSel" is 1, the eventcode will change to
> "eventcode |=3D 1 << 21=E2=80=9D. For event =E2=80=9CUNC_Q_RxL_CREDITS_CO=
NSUMED_VN0.DRS",
> its "ExtSel" is "1", its eventcode will change from 0x1E to 0x20001E,
> but in fact the eventcode should <=3D0x1FF, so this will cause the parse
> fail:
>
>   # perf stat -e "UNC_Q_RxL_CREDITS_CONSUMED_VN0.DRS" -a sleep 0.1
> event syntax error: '.._RxL_CREDITS_CONSUMED_VN0.DRS'
>                                   \___ value too big for format, maximum =
is 511
>
> On the perf kernel side, the kernel assumes the valid bits are continuous=
.
> It will adjust the 0x100 (bit 8 for perf tool) to bit 21 in HW.
>
> DEFINE_UNCORE_FORMAT_ATTR(event_ext, event, "config:0-7,21");
>
> So the perf tool follows the kernel side and just set bit8 other than bit=
21.
>
> Fixes: fedb2b518239 ("perf jevents: Add support for parsing uncore json f=
iles")
> Signed-off-by: Zhengjun Xing <zhengjun.xing@linux.intel.com>
> Reviewed-by: Kan Liang <kan.liang@linux.intel.com>

Acked-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/pmu-events/jevents.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jeve=
nts.c
> index cee61c4ed59e..e597e4bac90f 100644
> --- a/tools/perf/pmu-events/jevents.c
> +++ b/tools/perf/pmu-events/jevents.c
> @@ -605,7 +605,7 @@ static int json_events(const char *fn,
>                         } else if (json_streq(map, field, "ExtSel")) {
>                                 char *code =3D NULL;
>                                 addfield(map, &code, "", "", val);
> -                               eventcode |=3D strtoul(code, NULL, 0) << =
21;
> +                               eventcode |=3D strtoul(code, NULL, 0) << =
8;
>                                 free(code);
>                         } else if (json_streq(map, field, "EventName")) {
>                                 addfield(map, &je.name, "", "", val);
> --
> 2.25.1
>