Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 26 May 2022 18:23:09 +0200
From:   Marek =?UTF-8?B?QmVow7pu?= <kabel@kernel.org>
To:     Miaoqian Lin <linmq006@gmail.com>
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] net: dsa: mv88e6xxx: Fix refcount leak in
 mv88e6xxx_mdios_register
Message-ID: <20220526182309.2412106d@dellmb>
In-Reply-To: <20220526145208.25673-1-linmq006@gmail.com>
References: <20220526145208.25673-1-linmq006@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, 26 May 2022 18:52:08 +0400
Miaoqian Lin <linmq006@gmail.com> wrote:

> of_get_child_by_name() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when done.
>=20
> mv88e6xxx_mdio_register() pass the device node to of_mdiobus_register().
> We don't need the device node after it.
>=20
> Add missing of_node_put() to avoid refcount leak.
>=20
> Fixes: a3c53be55c95 ("net: dsa: mv88e6xxx: Support multiple MDIO busses")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> changes in v2:
> - Add fixes tag.
> changes in v3:
> - Move of_node_put() statement to cover normal path.
> - Update commit message.
>=20
> I do cross-check to determine we should release the node after
> of_mdiobus_register(), refer to functions like lan78xx_mdio_init(),
> ave_init() and ag71xx_mdio_probe().
>=20
> v1 link: https://lore.kernel.org/r/20220526083748.39816-1-linmq006@gmail.=
com/
> v2 link: https://lore.kernel.org/all/20220526112415.13835-1-linmq006@gmai=
l.com/
> ---
>  drivers/net/dsa/mv88e6xxx/chip.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx=
/chip.c
> index 5d2c57a7c708..0b49d243e00b 100644
> --- a/drivers/net/dsa/mv88e6xxx/chip.c
> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
> @@ -3960,6 +3960,7 @@ static int mv88e6xxx_mdios_register(struct mv88e6xx=
x_chip *chip,
>  	 */
>  	child =3D of_get_child_by_name(np, "mdio");
>  	err =3D mv88e6xxx_mdio_register(chip, child, false);
> +	of_node_put(child);
>  	if (err)
>  		return err;
> =20

Reviewed-by: Marek Beh=C3=BAn <kabel@kernel.org>