Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933760AbXEPUsv (ORCPT ); Wed, 16 May 2007 16:48:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757979AbXEPUso (ORCPT ); Wed, 16 May 2007 16:48:44 -0400 Received: from mx1.redhat.com ([66.187.233.31]:34510 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756641AbXEPUsn (ORCPT ); Wed, 16 May 2007 16:48:43 -0400 Date: Wed, 16 May 2007 16:48:07 -0400 From: Dave Jones To: Duane Griffin Cc: Prakash Punnoor , Joshua Hoblitt , LKML , Daniel Drake Subject: Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver Message-ID: <20070516204807.GA23751@redhat.com> Mail-Followup-To: Dave Jones , Duane Griffin , Prakash Punnoor , Joshua Hoblitt , LKML , Daniel Drake References: <20070516011711.GE15763@ifa.hawaii.edu> <200705162039.02379.prakash@punnoor.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1285 Lines: 37 On Wed, May 16, 2007 at 08:53:13PM +0100, Duane Griffin wrote: > On 16/05/07, Prakash Punnoor wrote: > > Maybe you want to give a hint in the p states driver help text? > > I think a hint is the right thing to do, but in the PowerNow! driver > rather than the p states one. How about adding something like this to > the X86_POWERNOW_K8 (and X86_POWERNOW_K7?) help text: The mobile K7s which had powernow support weren't SMP capable, so they're irrelevant. > "ACPI support is required for non-UP systems and requires ACPI_PROCESSOR > to be selected. If ACPI_PROCESSOR is compiled as a module then this > option must be too in order for ACPI support to be available." X86_POWERNOW_K8_ACPI is already 'default y'. I think the problem lies in that people aren't enabling its dependancy, ACPI_PROCESSOR. We want something along the lines of.. config X86_POWERNOW_K8_ACPI bool if SMP & X86_POWERNOW_K8_ACPI select ACPI_PROCESSOR kconfig language quirks aside.. Dave -- http://www.codemonkey.org.uk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/