Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 26 May 2022 23:54:35 +0900
From:   Masami Hiramatsu (Google) <mhiramat@kernel.org>
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Gautam Menghani <gautammenghani201@gmail.com>, mingo@redhat.com,
        linux-kernel@vger.kernel.org,
        linux-kernel-mentees@lists.linuxfoundation.org,
        skhan@linuxfoundation.org, Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: [PATCH] kernel/trace: Initialize integer variable to prevent
 garbage return value
Message-Id: <20220526235435.59a1b3074ecfb30825824948@kernel.org>
In-Reply-To: <20220525112551.37e86da6@gandalf.local.home>
References: <20220522061826.1751-1-gautammenghani201@gmail.com>
        <20220525112551.37e86da6@gandalf.local.home>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 25 May 2022 11:25:51 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Sat, 21 May 2022 23:18:26 -0700
> Gautam Menghani <gautammenghani201@gmail.com> wrote:
> 
> > Initialize the integer variable to 0 to fix the clang scan warning:
> > Undefined or garbage value returned to caller 
> > [core.uninitialized.UndefReturn]
> >         return ret;
> > 
> > Signed-off-by: Gautam Menghani <gautammenghani201@gmail.com>
> > ---
> >  kernel/trace/trace_boot.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/kernel/trace/trace_boot.c b/kernel/trace/trace_boot.c
> > index 0580287d7a0d..778200dd8ede 100644
> > --- a/kernel/trace/trace_boot.c
> > +++ b/kernel/trace/trace_boot.c
> > @@ -300,7 +300,7 @@ trace_boot_hist_add_handlers(struct xbc_node *hnode, char **bufp,
> >  {
> >  	struct xbc_node *node;
> >  	const char *p, *handler;
> > -	int ret;
> > +	int ret = 0;
> 
> Looks good to me. Masami, care to ack it?

Thanks! This looks good to me.

Fixes: 8993665abcce ("tracing/boot: Support multiple handlers for per-event histogram")
Cc: stable@vger.kernel.org
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>

Thank you!

> 
> -- Steve
> 
> >  
> >  	handler = xbc_node_get_data(hnode);
> >  
> 


-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>