Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <91e7651e-6937-ab20-2b1c-01f8be7933e1@amd.com>
Date:   Thu, 26 May 2022 16:29:22 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH 06/13] perf/x86/amd: Support PERF_SAMPLE_PHY_ADDR using
 IBS_DC_PHYSADDR
Content-Language: en-US
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     acme@kernel.org, jolsa@kernel.org, namhyung@kernel.org,
        eranian@google.com, irogers@google.com, jmario@redhat.com,
        leo.yan@linaro.org, alisaidi@amazon.com, ak@linux.intel.com,
        kan.liang@linux.intel.com, dave.hansen@linux.intel.com,
        hpa@zytor.com, mingo@redhat.com, mark.rutland@arm.com,
        alexander.shishkin@linux.intel.com, tglx@linutronix.de,
        bp@alien8.de, x86@kernel.org, linux-perf-users@vger.kernel.org,
        linux-kernel@vger.kernel.org, sandipan.das@amd.com,
        ananth.narayan@amd.com, kim.phillips@amd.com,
        santosh.shukla@amd.com, Ravi Bangoria <ravi.bangoria@amd.com>
References: <20220525093938.4101-1-ravi.bangoria@amd.com>
 <20220525093938.4101-7-ravi.bangoria@amd.com>
 <Yo4RSY2L80N5muJ9@hirez.programming.kicks-ass.net>
 <e10c3d1b-90a9-2f14-987b-9c0d2471ee53@amd.com>
 <20220526095633.GO2578@worktop.programming.kicks-ass.net>
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <20220526095633.GO2578@worktop.programming.kicks-ass.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UlE1OUNSMkpQNzNRUnpJblNpU2llSkNvYjByZEVsUTUwVnRQRjljanVIV2RS?=
 =?utf-8?B?QjZXcGRGUnV1d09sNVZGSHhCMWtoMnc5WURpbnJ4M2oyL2FPWUdBZi94azJ2?=
 =?utf-8?B?T3JrRitSYkIyQlV2eGdXRGVQVXR0TGw5RXBKNFlLV1F2Rlo4N2pLRy9KSUEy?=
 =?utf-8?B?b0pPZ0Fjc3JKUVdkQVBRaUJUeVNXREtKY0lxcVE0U3hJZmJSMCs3bzdkbFQ2?=
 =?utf-8?B?K1BRVzFKMUQwUlFSeHZ1dzV5MVU0TnVoQ3FiUUxzZ0Q4eUtIeFgvUHFSUHVM?=
 =?utf-8?B?V2pIb0RSR3VBUkkweU1OdFE0REIyRVMzNEw0MnJMTjNwZENkSFg0d1pydTNS?=
 =?utf-8?B?WlZpZk1SK2lremE1eHdXMCsyUVJGWUIzMURtR3lHeWVJUHJCNFRGWjN1N2ta?=
 =?utf-8?B?cEFtb0hMSlNWL21qazhiOEZqbFAvNWJ5SGtMT0FnK3hpTW84alF3YjVnZFc1?=
 =?utf-8?B?REVzSlhsMkdIaGtXNzNyaDl6eXUwaFlyaWR6REVVbGliVysvdFB6SmpJR0RF?=
 =?utf-8?B?QjljNEVJRzN0Z1dhaFdCOG1KZVhpaEhQWFMydkIwUFE5blhKc0hKWFEwYkVj?=
 =?utf-8?B?OEVlOXhZaWg0clRLK1g5ekFESFNWYVpFVVN0UjNZaW5CbjhVRjIrd0NaUVRs?=
 =?utf-8?B?V2xROTNpdDBkQmxuSGJFWUR3OXg3cXhHVGMrZHZNa3o4NHRPbkdBL3BBckE4?=
 =?utf-8?B?VVVBeHR4eEg5aFA0WmNON2dkTG1sem9lU1A5UHdHdS9Wbll6ak4xdDRMVDZN?=
 =?utf-8?B?dVh5dTJieUoyRWE5eGJaUTVJdzBvK1ZucWhyd0xLOEMvSGF5VDVyUTgyWHAv?=
 =?utf-8?B?ak4yK2hZcHNtOE9NRitJeHpxcExTMjF6SFAyMmtkWkpmWU13M1l6VnlyRVJx?=
 =?utf-8?B?NDFDaWhmSlBHa2EyL0RYb01ReEE3K0kvSHJaTU5jMm1DTEp1R1lacGloL21s?=
 =?utf-8?B?bEZ0MEI4U09mdFBDNEZCZWZ6N3VUOFVaOE9KMnhhNTZobG8wL2NLZ2JQaGsx?=
 =?utf-8?B?eVZhcmhTelpyalpFSWhTSzNEbWgrMmFPa2VIMmxJbktvL0gxWE5PTlA0SlVM?=
 =?utf-8?B?aVZnOGs2NGt2dkpIQ3J4S1ZEZ1dBajRWYTZlTkJIeit0YlQ1L2tqMnYvSk80?=
 =?utf-8?B?b1dyeGU5SXZlbzFKOEpUTnYzWW52Q1Jrbmc1c3NnUmIydTJjUndYYyszYmdq?=
 =?utf-8?B?RTZpenN0L3ZLWDh3YnJJcTQzWk1LUVk2cWhEd045QU5WWGs0SDJWak5KK1Z1?=
 =?utf-8?B?MnJrQTNTYjRkVCs2Q1VqaU10Tyt6Z1ptYkNEc3NmdE5SU2VIVlptQlJPUnhM?=
 =?utf-8?B?Z29VNDZDS2RIc2V5TFdYdVlLZzZ5aHJQc0RZSDZGVXV5dVBpVURzVVd2Y2RF?=
 =?utf-8?B?TUxrMHpiZHZZODIzcDNDM2pFUFhSUUk4YThIS0Ixc1hWbzhxTDIrTUJqdWVY?=
 =?utf-8?B?M2dFQnh4WmdkRG5ZS1JFTmpseENKSlp2WnJtd3d2SGNVK2R6K3VFT2RiajB2?=
 =?utf-8?B?c21zVjYwSEVPczNwT1czbGx3d3BXd0M5RG8xRis1cS9hNUZmMVNlZmVYeHBB?=
 =?utf-8?B?RlBoY3J3Q08rSGZMK0RNQlhveURIZms2WUVUL1JHbW14K1k1dnF0emxodXEz?=
 =?utf-8?B?ZDV4TzFHMGJ4T3lxdEEvMWNQRVVJd3phSkwrakNHOFBXb3pQeDQrMHJCV0ww?=
 =?utf-8?B?YzhiL0JiUEpuSDBmcUREYUY1UWFIV0EwNlhzTFBBS215dzhsUStzUGJURGxp?=
 =?utf-8?B?dFA3c1pGcUZHMnVFeWc5KzBkd05WT0N3MDBuY21oMFhqQkJBRnFYUjFPQVk1?=
 =?utf-8?B?UFBENDg2ZmhoWHM5S0JyOVlWMzlNYWVQNDEwTU1LRWtBcWVPQkVvTXR1MmFO?=
 =?utf-8?B?b2J2eUR6U0tnRzRpWFpWd1dyMGhzL0JJZ3Y2Q2FRRHB4Wk44T2RuZzZET0dO?=
 =?utf-8?B?U1E5dTM2cFdYNWRpMGt6WDZEMFl1YzJDNkJPcFhxRWNjZnVRdFMyeHdtSFBM?=
 =?utf-8?B?OE9OL3FUWHFJdENrU0RsdzZoZlNKSUxVODRtQjd4c2QrRlEzOUFNOUo2YStS?=
 =?utf-8?B?YTg0TGY0a2hPaEtBQnlmbGVBeWEwNUZVQjJFWWVRc0ozQnphSkdGNi9OUU80?=
 =?utf-8?B?SWFtd3dxMzR4V2lJWlg0eis2aDQ0S1RVRHJINUpZbm5aNTZOK3dtWkk4MGJz?=
 =?utf-8?B?aS8wZ1pVYXlqMDZTZktSNkVjZUcxOEd2OXZjeW9HSTA1NDFQbEFkNGd5T1V5?=
 =?utf-8?B?Q3g2am5aR0tNWURrMDAvNGQ2dkJnVjNobHEvb2FzRURIMGt6YzVxRjNEODN4?=
 =?utf-8?B?SHFhUHdBSjh3bDBrRitWazRCakNZenczNElSMHh1Mm1XMVdpNFlHZz09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 17ab6a2d-579f-4d96-fc50-08da3f06d5ee
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2022 10:59:42.2147
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KHlxyRe99A+xgEz2EdDolXzb/AX8N9uD2NASBrAcfgzZiRaKUTJdADO89nvoZohiML3fBgp9AtXJyQLrEPzWwA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1201MB0117
X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 26-May-22 3:26 PM, Peter Zijlstra wrote:
> On Thu, May 26, 2022 at 02:16:28PM +0530, Ravi Bangoria wrote:
>> On 25-May-22 4:51 PM, Peter Zijlstra wrote:
>>> On Wed, May 25, 2022 at 03:09:31PM +0530, Ravi Bangoria wrote:
>>>> IBS_DC_PHYSADDR provides the physical data address for the tagged load/
>>>> store operation. Populate perf sample physical address using it.
>>>>
>>>> Signed-off-by: Ravi Bangoria <ravi.bangoria@amd.com>
>>>> ---
>>>>  arch/x86/events/amd/ibs.c | 26 +++++++++++++++++++++++++-
>>>>  1 file changed, 25 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/x86/events/amd/ibs.c b/arch/x86/events/amd/ibs.c
>>>> index b57736357e25..c719020c0e83 100644
>>>> --- a/arch/x86/events/amd/ibs.c
>>>> +++ b/arch/x86/events/amd/ibs.c
>>>> @@ -986,13 +986,35 @@ static void perf_ibs_get_data_addr(struct perf_event *event,
>>>>  	data->addr = ibs_data->regs[ibs_op_msr_idx(MSR_AMD64_IBSDCLINAD)];
>>>>  }
>>>>  
>>>> +static void perf_ibs_get_phy_addr(struct perf_event *event,
>>>> +				  struct perf_ibs_data *ibs_data,
>>>> +				  struct perf_sample_data *data)
>>>> +{
>>>> +	union perf_mem_data_src *data_src = &data->data_src;
>>>> +	u64 op_data3 = ibs_data->regs[ibs_op_msr_idx(MSR_AMD64_IBSOPDATA3)];
>>>> +	u64 phy_addr_valid = op_data3 & IBS_DC_PHY_ADDR_VALID_MASK;
>>>> +
>>>> +	if (!(event->attr.sample_type & PERF_SAMPLE_DATA_SRC))
>>>> +		perf_ibs_get_mem_op(op_data3, data);
>>>> +
>>>> +	if ((data_src->mem_op != PERF_MEM_OP_LOAD &&
>>>> +	    data_src->mem_op != PERF_MEM_OP_STORE) ||
>>>> +	    !phy_addr_valid) {
>>>> +		data->phys_addr = 0x0;
>>>> +		return;
>>>> +	}
>>>> +
>>>> +	data->phys_addr = ibs_data->regs[ibs_op_msr_idx(MSR_AMD64_IBSDCPHYSAD)];
>>>> +}
>>>
>>> perf_prepare_sample() will unconditionally overwrite data->phys_addr.
>>> There is currently no facility to let the driver set this field.
>>
>> Thanks for pointing it Peter. Would you mind if I add:
> 
> I think it's best if you extend/mimic the __PERF_SAMPLE_CALLCHAIN_EARLY
> hack. It's more or less the same problem and then at least the solution
> is consistent.

I've one more identical optimization in my list. IBS_OP_DATA3[IbsDcPgSz]
can provide PERF_SAMPLE_DATA_PAGE_SIZE. I hope consuming two more bits
for internal purpose is okay.

Thanks,
Ravi