Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d599e48c-1821-164e-619d-dcfd8a689192@theobroma-systems.com>
Date:   Wed, 25 May 2022 14:24:35 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH v3 2/4] media: ov5675: add device-tree support and support
 runtime PM
Content-Language: en-US
From:   Quentin Schulz <quentin.schulz@theobroma-systems.com>
To:     Jacopo Mondi <jacopo@jmondi.org>,
        Quentin Schulz <foss+kernel@0leil.net>
Cc:     shawnx.tu@intel.com, mchehab@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, linux-media@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220509143226.531117-1-foss+kernel@0leil.net>
 <20220509143226.531117-2-foss+kernel@0leil.net>
 <20220510094607.2ijaw6we6jml2bv7@uno.localdomain>
 <49e53ae4-1be9-fae1-6c93-3ce7c16f3ada@theobroma-systems.com>
In-Reply-To: <49e53ae4-1be9-fae1-6c93-3ce7c16f3ada@theobroma-systems.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bEw3aVFYR0VRNjZySmEyaEpWSUs3Mjcya1NMcXUzc3N6eFJRYk9ySGlCZ25F?=
 =?utf-8?B?dkEwREs1N3pWeS9MTU91SGNGa2swSlo5S0hCNGN4ZWtQWnNlNmZzOGozSWhP?=
 =?utf-8?B?dzdRUXQrMVJoWllwdTY4bW0yaEdYa1g4SHE1Ris0NEYwVS9zMnd2d255UjAx?=
 =?utf-8?B?dEFsdHBVSnhrbmtwbEtGU0w1TmYwWkYyRk9iOHNvUnR5aXJjTHo3U0NoakRw?=
 =?utf-8?B?OTlqOVV3cWtSaDBZN1RtUndpYjJIVzhxRE5tNCtONHRWRWVaWjVtZjhXZE9P?=
 =?utf-8?B?cGVTcnVtRVV5UWNwdTZtNE91bnVtZGg1Z0NyeVlYVitIc1p2RmRBOU5qM2FG?=
 =?utf-8?B?L2dxcGZadXV0ZHJ2ZHFHSnp3UlR6dDlzRDhTMVc5Y1ppUFhWaHhNQzEycExH?=
 =?utf-8?B?Mm9Yd3NBdFdFY1YzZndSWVIza1dtNUpuWkdGNkh1SFBTajIzdFlxOE9iKzNs?=
 =?utf-8?B?a1hmZlV2TEw5OEZGV2MzMm5zdyttcEsyMTZNWTltOW91S2ZYUm5MSjRyazcr?=
 =?utf-8?B?S2hWVjl1TDNxYVI1UytMeEVsTTZYbFVvZE1IcG5yU0Z3VXBZdW52SzFEUWpV?=
 =?utf-8?B?MDdjekZqTkZxWjB6Q1lvSEEzZE9pQVoxa2ZQdVo5SEszZlBpOWVuYVd0T3Ns?=
 =?utf-8?B?TEZ3OXorOGNkSTk1elpnN0FWV0NUb0pOMnYvWnhwU2JHdnFRaTc2V1ZLVFhQ?=
 =?utf-8?B?QURrak9kdXFXS1pRZmJLZzY3aGNSWjlVVXhIZ3ZXNnFCUGhTVVdzMmMwMDhx?=
 =?utf-8?B?UlBHbXhnV1N5cUhic0xuRHdwcXNVNzNsK3VLRFI1RndURldQd01lUjVrWWdI?=
 =?utf-8?B?djJCNC9ZRnJMTU8vYzdkYm4wTTczaXlReGZjZFc3S2NzZUo0dEI5c0NaTjlh?=
 =?utf-8?B?NTZYclpwK0JJOXFCTFAxQVBPTmdOMVV1NTBKckJPTWUrL05JT0RFTmxxMnk2?=
 =?utf-8?B?YzQvSnU4VXZxMlJXamJ1M3BZWjdHaEYrdWM4TjRaT0lxSHUwRGw1T1ZBWUdU?=
 =?utf-8?B?UzY4YndDNFAzbldtZkdiL3djUkJJeSs3UE5ibkJJYmFaOHZPSlF2ZEYrOGdG?=
 =?utf-8?B?bnNsMGRxcFM1c2JxTHpVQ3ZXMGxCK3FyeExVRDB3a0V1VnVjZFJIMHBzZVFB?=
 =?utf-8?B?MVBnMFlxU09RY3RUUUt5cDdVbEV6TVZtdGlEOGx0cHB6YlRnTmZ2Sm9sbldX?=
 =?utf-8?B?UGt6Y3dIYk1PQ0NiNk04MTBkZURzdFFvL3lJUUFaZmQ1ZTJTWlVnNFhUa1NW?=
 =?utf-8?B?L1ZvY0pnbXFUeFlVQ3N1aGRqRFlXUU9wc0QvNDB0TytycVlVLzl4ZUFndHRk?=
 =?utf-8?B?a2NYdHJlYkV1bjBlMmh1T0F6bWlGbmQ3ZVU4NXRzcVFUd2RxYng2dXlCM2xB?=
 =?utf-8?B?NjZFc2srdVBVYkpwU04ySkVSQTd0VUdlem5oOTRHWDdhSlpuOFhBK2dSTVlZ?=
 =?utf-8?B?UzBvN1N3eDFDbmZwSitIelRGemZnMlkwdU5GVVVrQjhoWVdweit5VFhmV2h0?=
 =?utf-8?B?OWZhUHBGY2tBUzJHYlJJWW5yWVFBd1VLL0w0OFpvKzl0bExpMFovMWZ3cWhk?=
 =?utf-8?B?TENWZmtSWVV4S0JHaGNGVzUxbkF4SWNjTSs1UUk2SkM1UUFiSmdKTGwrb1la?=
 =?utf-8?B?TVZTWGRpWS8vVU1wUlQ3bXA4SkRqOXg2aUowMGNZUDVaUFBlWS9ZMFl6Tkdv?=
 =?utf-8?B?SlpQYVdnTkFiQmphS2lsL1Y5dWJsM2pROTYzUTdXalVsa2g5WnA1TzNmV2JF?=
 =?utf-8?B?SGJyWkNlY1VubCtzTnY5VlhMOFdzTkErcDJCb2lTekhJOHY5RnBZWjVUOGV3?=
 =?utf-8?B?ZnROSjF0VmdJQ0xQdXhuQ2VNNUxUM25KMlhMODhVN2FPNEJaTTFlaWkvNnMr?=
 =?utf-8?B?THhDR2NKdmIxeHl4NUdCK1NJMEtIRDhGb0JDWldKYnRmblNVQy9KTGxNanR2?=
 =?utf-8?B?YlYrTVh2NVVQdkU3bnJvcENnVm01eUgzTVFiYlREYmU2a0tnOS9lUkx6Nytu?=
 =?utf-8?B?eTVrejlnbGZzcTVHekhFVjU1ZHc0V0l4ZkZHQkFla0NMdjZFeFZQWmJLcjNT?=
 =?utf-8?B?VmdnUGh6bGtrYVJNMjlSQ2hDa0ZlZnZ0cDVTeFJjZExxVzltNzlFUXBVUzZh?=
 =?utf-8?B?MVdwQVlwbnRqR3p4anFrU096Q1NtVk1taTB1ckU2MnRLbHRPY1VwQ2VqMUd4?=
 =?utf-8?B?dlp0bkFkRHphek9UVzVUai94V3cvaHJyMlFoT3lKeXZwckh3b2lJUXRnOG9q?=
 =?utf-8?B?WFMwZzVVcDlWSk1aR2RCSlIyVEIyc014Q0F2bUwyYzhsUy9pZUdBWTlrSTdU?=
 =?utf-8?B?Y2ZaLzRMTURmaE1Ca1NxbDB0YmcrOERTcWhYSFpoK2pzbHVMTFNDNDYvS3FV?=
 =?utf-8?Q?kDSzgNGNGCMFVhI23DRYj5xHbz7w7RvCo+UAH?=
X-OriginatorOrg: theobroma-systems.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4923f759-4f36-4b40-d337-08da3e49887f
X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB9378.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 12:24:37.1521
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5e0e1b52-21b5-4e7b-83bb-514ec460677e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vXn9fu+s4zVzB5XAaZeShKiWG6hSwHkr/8qvylU8nZkf6/UpT7bp0QgU0kfL09gOHNeoR7CNklEiV9SyB8/51lVDR7RkkG/D0VBjfG9RYRNCwxOA+bNWdSMlaNg4uU4n
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8674
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi all,

On 5/10/22 15:42, Quentin Schulz wrote:
> Hi all,
> 
> On 5/10/22 11:46, Jacopo Mondi wrote:
>> Hi Quentin,
>>
>> On Mon, May 09, 2022 at 04:32:24PM +0200, Quentin Schulz wrote:
>>> From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
>>>
>>> Until now, this driver only supported ACPI. This adds support for
>>> Device Tree too while enabling clock and regulators in runtime PM.
>>>
>>> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
>>
>> Thanks for addressing all comments on the previous version.
>>
>> Looks good to me!
> 
> Unfortunately the sensor disagrees :/
> 
> For some reasons, the first three power-on + power-off are successful 
> (sometimes only the first two) and then the sensor is not working until 
> next cold boot. I got lucky when I tested the patch before sending, much 
> less now. >

For your information, there were actually two issues:

  - the MCLK of our camera sensor is connected to a pin on a Rockchip 
PX30 SoC whose iodomain is not enabled prior to booting the Linux 
kernel. This means that the whole block was not supplied with power 
(something around 100-150mV instead of the expected 1.8V) and the i2c 
transfers during some device probing were broken because the iodomains 
driver could be probed after the OV5675 driver (and also, since it 
persists on CPU reset, a reboot would fix this too since the iodomain 
would have been configured by the preceding boot). We currently handle 
this the hackish way by configuring the iodomain in U-Boot before 
booting the kernel. I have talked with Heiko, the Rockchip maintainer, 
who mentioned there's no way to explicit a dependency to an iodomain in 
Device Tree right now but suggested we expose regulators from the 
iodomain driver. I'll come up with something to fix this properly in the 
kernel in the next few months. This is not related to the camera driver 
in any way but wanted to mention it.

  - the camera sensor was actually faulty. After many attempts at HW 
reworking, looking at the scope, re-reading the datasheet, trying to 
read between the lines, etc... we swapped the camera sensor for a 
fresh-out-of-the-box one and it worked for 30min (then we stopped it) 
with a runtime/suspend every few seconds. I tried with two different 
camera sensors and it worked fine.

Cheers,
Quentin