Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220512112347.18717-1-andrew@daynix.com> <CACGkMEvH1yE0CZYdstAK32DkEucejNO+V7PEAZD_641+rp2aKA@mail.gmail.com>
 <CABcq3pFJcsoj+dDf6tirT_hfTB6rj9+f6KNFafwg+usqYwTdDA@mail.gmail.com>
In-Reply-To: <CABcq3pFJcsoj+dDf6tirT_hfTB6rj9+f6KNFafwg+usqYwTdDA@mail.gmail.com>
From:   Jason Wang <jasowang@redhat.com>
Date:   Thu, 26 May 2022 14:56:18 +0800
Message-ID: <CACGkMEtaigzuwy25rE-7N40TQGvXVmJVQivavmuwrCuw0Z=LUQ@mail.gmail.com>
Subject: Re: [RFC PATCH v2 0/5] TUN/VirtioNet USO features support.
To:     Andrew Melnichenko <andrew@daynix.com>
Cc:     davem <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, mst <mst@redhat.com>,
        netdev <netdev@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        virtualization <virtualization@lists.linux-foundation.org>,
        Yan Vugenfirer <yan@daynix.com>,
        Yuri Benditovich <yuri.benditovich@daynix.com>
Content-Type: multipart/mixed; boundary="0000000000007d4a8d05dfe4b040"
Precedence: bulk

--0000000000007d4a8d05dfe4b040
Content-Type: text/plain; charset="UTF-8"

On Tue, May 24, 2022 at 7:07 PM Andrew Melnichenko <andrew@daynix.com> wrote:
>
> Hi all,
>
> The issue is that host segments packets between guests on the same host.
> Tests show that it happens because SKB_GSO_DODGY skb offload in
> virtio_net_hdr_from_skb().
> To do segmentation you need to remove SKB_GSO_DODGY or add SKB_GSO_PARTIAL
> The solution with DODGY/PARTIAL offload looks like a dirty hack, so
> for now, I've lived it as it is for further investigation.

Ok, I managed to find the previous discussion. It looks to me the
reason is that __udp_gso_segment will segment dodgy packets
unconditionally.

I wonder if the attached patch works? (compile test only).

Thanks

>
>
> On Tue, May 17, 2022 at 9:32 AM Jason Wang <jasowang@redhat.com> wrote:
> >
> > On Thu, May 12, 2022 at 7:33 PM Andrew Melnychenko <andrew@daynix.com> wrote:
> > >
> > > Added new offloads for TUN devices TUN_F_USO4 and TUN_F_USO6.
> > > Technically they enable NETIF_F_GSO_UDP_L4
> > > (and only if USO4 & USO6 are set simultaneously).
> > > It allows to transmission of large UDP packets.
> > >
> > > Different features USO4 and USO6 are required for qemu where Windows guests can
> > > enable disable USO receives for IPv4 and IPv6 separately.
> > > On the other side, Linux can't really differentiate USO4 and USO6, for now.
> > > For now, to enable USO for TUN it requires enabling USO4 and USO6 together.
> > > In the future, there would be a mechanism to control UDP_L4 GSO separately.
> > >
> > > Test it WIP Qemu https://github.com/daynix/qemu/tree/Dev_USOv2
> > >
> > > New types for VirtioNet already on mailing:
> > > https://lists.oasis-open.org/archives/virtio-comment/202110/msg00010.html
> > >
> > > Also, there is a known issue with transmitting packages between two guests.
> >
> > Could you explain this more? It looks like a bug. (Or any pointer to
> > the discussion)
> >
> > Thanks
> >
> > > Without hacks with skb's GSO - packages are still segmented on the host's postrouting.
> > >
> > > Andrew (5):
> > >   uapi/linux/if_tun.h: Added new offload types for USO4/6.
> > >   driver/net/tun: Added features for USO.
> > >   uapi/linux/virtio_net.h: Added USO types.
> > >   linux/virtio_net.h: Support USO offload in vnet header.
> > >   drivers/net/virtio_net.c: Added USO support.
> > >
> > >  drivers/net/tap.c               | 10 ++++++++--
> > >  drivers/net/tun.c               |  8 +++++++-
> > >  drivers/net/virtio_net.c        | 19 +++++++++++++++----
> > >  include/linux/virtio_net.h      |  9 +++++++++
> > >  include/uapi/linux/if_tun.h     |  2 ++
> > >  include/uapi/linux/virtio_net.h |  4 ++++
> > >  6 files changed, 45 insertions(+), 7 deletions(-)
> > >
> > > --
> > > 2.35.1
> > >
> >
>

--0000000000007d4a8d05dfe4b040
Content-Type: application/octet-stream; 
	name="0001-udp-allow-header-check-for-dodgy-GSO_UDP_L4-packets.patch"
Content-Disposition: attachment; 
	filename="0001-udp-allow-header-check-for-dodgy-GSO_UDP_L4-packets.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_l3mnw1q30>
X-Attachment-Id: f_l3mnw1q30

RnJvbSA0Y2VkNmZmM2E4ZWExM2IwNjlkZDMwODdhYjIyZDI1MjY5NmUxZGVmIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKYXNvbiBXYW5nIDxqYXNvd2FuZ0ByZWRoYXQuY29tPgpEYXRl
OiBUaHUsIDI2IE1heSAyMDIyIDE0OjI5OjE3ICswODAwClN1YmplY3Q6IFtQQVRDSF0gdWRwOiBh
bGxvdyBoZWFkZXIgY2hlY2sgZm9yIGRvZGd5IEdTT19VRFBfTDQgcGFja2V0cwpDb250ZW50LXR5
cGU6IHRleHQvcGxhaW4KClNpZ25lZC1vZmYtYnk6IEphc29uIFdhbmcgPGphc293YW5nQHJlZGhh
dC5jb20+Ci0tLQogbmV0L2lwdjQvdWRwX29mZmxvYWQuYyB8IDEwICsrKysrKysrKysKIDEgZmls
ZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvbmV0L2lwdjQvdWRwX29m
ZmxvYWQuYyBiL25ldC9pcHY0L3VkcF9vZmZsb2FkLmMKaW5kZXggNmQxYTRiZWMyNjE0Li45NTc5
ODg2Y2U1NTcgMTAwNjQ0Ci0tLSBhL25ldC9pcHY0L3VkcF9vZmZsb2FkLmMKKysrIGIvbmV0L2lw
djQvdWRwX29mZmxvYWQuYwpAQCAtMjgwLDYgKzI4MCwxNSBAQCBzdHJ1Y3Qgc2tfYnVmZiAqX191
ZHBfZ3NvX3NlZ21lbnQoc3RydWN0IHNrX2J1ZmYgKmdzb19za2IsCiAJaWYgKGdzb19za2ItPmxl
biA8PSBzaXplb2YoKnVoKSArIG1zcykKIAkJcmV0dXJuIEVSUl9QVFIoLUVJTlZBTCk7CiAKKwlp
ZiAoc2tiX2dzb19vayhnc29fc2tiLCBmZWF0dXJlcyB8IE5FVElGX0ZfR1NPX1JPQlVTVCkpIHsK
KwkJLyogUGFja2V0IGlzIGZyb20gYW4gdW50cnVzdGVkIHNvdXJjZSwgcmVzZXQgZ3NvX3NlZ3Mu
ICovCisKKwkJc2tiX3NoaW5mbyhnc29fc2tiKS0+Z3NvX3NlZ3MgPSBESVZfUk9VTkRfVVAoZ3Nv
X3NrYi0+bGVuLCBtc3MpOworCisJCXNlZ3MgPSBOVUxMOworCQlnb3RvIG91dDsKKwl9CisKIAlz
a2JfcHVsbChnc29fc2tiLCBzaXplb2YoKnVoKSk7CiAKIAkvKiBjbGVhciBkZXN0cnVjdG9yIHRv
IGF2b2lkIHNrYl9zZWdtZW50IGFzc2lnbmluZyBpdCB0byB0YWlsICovCkBAIC0zNjEsNiArMzcw
LDcgQEAgc3RydWN0IHNrX2J1ZmYgKl9fdWRwX2dzb19zZWdtZW50KHN0cnVjdCBza19idWZmICpn
c29fc2tiLAogCQllbHNlCiAJCQlXQVJOX09OX09OQ0UocmVmY291bnRfc3ViX2FuZF90ZXN0KC1k
ZWx0YSwgJnNrLT5za193bWVtX2FsbG9jKSk7CiAJfQorb3V0OgogCXJldHVybiBzZWdzOwogfQog
RVhQT1JUX1NZTUJPTF9HUEwoX191ZHBfZ3NvX3NlZ21lbnQpOwotLSAKMi4yNS4xCgo=
--0000000000007d4a8d05dfe4b040--