Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cc7ee242-31dd-5df5-7685-219b38b6f499@intel.com>
Date:   Thu, 26 May 2022 13:18:23 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCHv3 2/3] x86/tdx: Clarify RIP adjustments in #VE handler
Content-Language: en-US
To:     "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc:     tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        luto@kernel.org, peterz@infradead.org, ak@linux.intel.com,
        dan.j.williams@intel.com, david@redhat.com, hpa@zytor.com,
        linux-kernel@vger.kernel.org,
        sathyanarayanan.kuppuswamy@linux.intel.com, seanjc@google.com,
        thomas.lendacky@amd.com, x86@kernel.org
References: <20220524221012.62332-1-kirill.shutemov@linux.intel.com>
 <20220524221012.62332-3-kirill.shutemov@linux.intel.com>
 <89f55141-a71c-1fd8-e1be-96355c63c03a@intel.com>
 <20220526201354.v5a6fsi4aiuet2d7@black.fi.intel.com>
From:   Dave Hansen <dave.hansen@intel.com>
In-Reply-To: <20220526201354.v5a6fsi4aiuet2d7@black.fi.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/26/22 13:13, Kirill A. Shutemov wrote:
>> I'm not super happy with how this comment ended up.  First, let's put
>> the comment next to the code to which it applies, like:
>>
>> 	/*
>> 	 * ve->instr_len is not defined for EPT violations.  For those,
>> 	 * the kernel must decode instructions manually and should not
>> 	 * be using this function.
>> 	 */
>> 	if (WARN_ON_ONCE(ve->exit_reason == EXIT_REASON_EPT_VIOLATION))
>> 		return 0;
>>
>> 	/*
>> 	 * Assume that the #VE occurred due to instruction execution.
>> 	 */
>> 	return ve->instr_len;
> Would it be helpful if the function has a whitelist of exit resons where
> using ve->instr_len is safe? WARN_ONCE() and return 0 otherwise.

Maybe.  I was hoping to avoid mostly duplicating the
virt_exception_kernel() switch().