Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <dac2c654-cb9c-6554-0afd-9e8db012374a@amd.com>
Date:   Thu, 26 May 2022 10:29:09 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.9.0
Subject: Re: [PATCH v2] iommu/amd: Set translation valid bit only when IO page
 tables are in used
Content-Language: en-US
To:     Joerg Roedel <joro@8bytes.org>
Cc:     linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
        vasant.hegde@amd.com, jon.grimm@amd.com
References: <20220509074815.11881-1-suravee.suthikulpanit@amd.com>
 <Yn5YIfzmerwAM30M@8bytes.org> <1dfaf07e-040e-848b-db7c-86a107fd5cb3@amd.com>
 <YodMvV/8eii4KCLg@8bytes.org>
From:   Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
In-Reply-To: <YodMvV/8eii4KCLg@8bytes.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dXFIWnNDZnBuL3AreWhOMFpBN3IrRWNWQ29XL3F5QWxIdHovd05UbGtDQXlT?=
 =?utf-8?B?b3ByMXQ1THFjaml0dTBNWWhIQlFYRGVxOVVyR25EaW1oZEo1NWtvZXdnR3Az?=
 =?utf-8?B?ZHdBSDN6azJZOVhmcTM3Zjl1dm1XdklBWHRTZmtKcXZhZU1ydEM5aUQrMkhV?=
 =?utf-8?B?TDB4QmJxckhEQ0ZRS0pqTC9zYnVubUQybk5qZ0hhSlllZm9acEhPWGltd1Iy?=
 =?utf-8?B?QnJTQVNDZElncHIrbkFsVEh4eitsVEYxeS9SV1RMZXBuVDdFVit1OUlNV3pV?=
 =?utf-8?B?d2UrTk1Qam1tclFQdDYxdTFxRG5SbUJlc21tcHhGU0RSbzk5SFJlZy8rcmJS?=
 =?utf-8?B?YzF2YmVFL0xmRVNIZWJKT3RJTDJiTGNiVkFmOXRxUzlOeGxweC8rQjJLZ3hR?=
 =?utf-8?B?WjB3Mnk4NjFZeXdBbXorMEhzVDZpS0ovb1ZKOVFySWlEKzNiU3ZhMDRteXJE?=
 =?utf-8?B?ais4OThyMjNyOEhndmVCVXkzTmczM1VqRjNxT3U0eU83TURuRTd6R3had2Zo?=
 =?utf-8?B?dnRxSGVyKzB2WmJNcU0zTXd4eDJ0NDIyRFBHZlhJOHFPRGJtRDlDVTlFV1J4?=
 =?utf-8?B?SEo2RVFYdGhjbUM1UHdBT2lQRU5zR1ZiWjNwS3I5TUVxL1l2bGZQNHN4VEJm?=
 =?utf-8?B?c2tEUmhYZnlEWGRQUUF4OFlSZisxK0RIMWcyT2ZEVVR6eHl5TE5LZGRSUVZQ?=
 =?utf-8?B?cEY2WUI3V0xEcEsvUVJEeTE2WldvR28rRUtHeVl4RmswY2xadVNtTm1kT0V1?=
 =?utf-8?B?SSt5WThsY1NwYklyZUJwaUhvMHZWMVRJVHBrWUdZTEN2UE53dk5HQ1hvZ1Na?=
 =?utf-8?B?UTdsdG9TVlM2TmU5QW5WZVo2blg4bkZab1NvRllaekF5TzBXLzZBUE1hV21l?=
 =?utf-8?B?R2hDRDFvU0h4RUErY1hJVkpPUkJSUzJoT2FJT0RBTjgxa3dnTFhRUVhTclhG?=
 =?utf-8?B?THJRZVdxZE9QK0VrS2FwbzVCV0RmNFJIRE1uRUVsWkpMRmZ4R3F0NE1rR2hQ?=
 =?utf-8?B?dG9CNUhaMVBUZHM2Q28yVjYvVTdqUFk2WlNiRi9wV0l4MmRDODlBMnhvUm5L?=
 =?utf-8?B?eTJRN2pVdktma0JRQWxuVG41SVRxNExTVEppMGl2TmV2cmd2MHA5T3R1Y0E3?=
 =?utf-8?B?WjZSRXdGT1ZhMEZ2UXlZeG8xYXJnK2FxTEVvWEJ3R2dMVnhBWGJhaytBZ0NV?=
 =?utf-8?B?ZlpEa1RqQWIwMnc2RittZ0huUURnK0pPNXNuMWxmaXBkc0dZRSs1MGw4U1A4?=
 =?utf-8?B?WngwOTdRdUZYbWZYTWVRNVJSN2tJU3dyZUtSR0tMZEI3Vmk4TlpJWWg2Q1Z6?=
 =?utf-8?B?aVdhTW5aMGdicjg4eXZmNWN4aHVaVGhyZXZEZWNWT2ZuQ0Fvd0lJZWZVZ2xM?=
 =?utf-8?B?THZIUUhSVDQ2Y0o5WllqNTJHTVA2cWJqNWRHdEZDUnMvTHN6YWhBVzZ1Wkx4?=
 =?utf-8?B?NFlpYi9GekxmUURLYklUWkJ4YmlmNUFwNFFZa1hMNlZ2cjZjMzIrMUxOTlV1?=
 =?utf-8?B?d1QrTnlaOVVwVytBa053VXBXWmd1amRMS2c2cDZkWjZhRjhOaDFmRVg4Z1ZQ?=
 =?utf-8?B?ZFV4cEExSnEvY2FoUUNkUzdrVVd1UkY1QnVHYWRmT0RSZkhJQmhBZmdGT2pN?=
 =?utf-8?B?cTMvMGhKbkwvMytYWTJwSENZUHdZdXRvaEJTRDRXWmpLWFQ0eGFDV0kycUNB?=
 =?utf-8?B?WGxwRnFnRm9qNGpzYldWSnc3R2xrVXVLNGU0YTdxTUtlemtUeGJxcnVsaDZB?=
 =?utf-8?B?WmZHczdHN1VDKzRObXdTckduN3lMc28yeUVYQzlRRERGa21EMEhlazZBV3Vl?=
 =?utf-8?B?OWNSaHRCSklXL3dMWG14Y1ZyMnZjZzNLcExDNWdETnorZ3FuZDJzMnQvcFZq?=
 =?utf-8?B?Q0ROdFl0MWl3bnRSRlhyU2RNWHNXWVZUR0tVbzMvcS83T2J5eGxhdXh3V2I1?=
 =?utf-8?B?aW83SERtSFd6Nkh6cW1lYkN6MXRPelZpdUg3aE40SWV0dkJKWHpLOE1QajN3?=
 =?utf-8?B?VHFOYzAyaWY5M25wcmE2Nld3a2IvdkdQaHVsQnYrcXdncXlzVTZKdjMvd0Zo?=
 =?utf-8?B?VjNBWEMxY1lRbVFHQ21vQjVPRU9NZEUzSVd5cEEwV0FuTksyekk3VVFTM2J5?=
 =?utf-8?B?alNadUlYa1hTZG8rbzNJMWhUVUdCZkR1eVIyWVNBczNBZkpMaDdIT0dsVCtn?=
 =?utf-8?B?SjNjcGJ2cXZ4MFpXRWIxc3czdElnRTJXcWwycTVWWHlkSE5zUHJBeURRZ25N?=
 =?utf-8?B?cUZoZWtObGVVT01KcXQ0dHpQc0pPdUNsbTY0TGM2OGdRMFdPMFJMbEJaWU5O?=
 =?utf-8?B?T0doOUppOEl1Tm0wUUNQdjV6cnRKS01INmd4eGtmVndIWFVqYWM1dz09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8fb3c4ce-9bd1-4675-1c08-08da3ec7e9c1
X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5445.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2022 03:29:17.0766
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /8LbmZ3uNSL8LJwc6dd3e2Pp+zM5RBHriiGMchIph+Jqa1petpDOP2Vosub/WiY8Z4jz9zkR9hvChXWeOvNpBw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5461
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Joerg,

On 5/20/22 3:09 PM, Joerg Roedel wrote:
> Hi Suravee,
> 
> On Mon, May 16, 2022 at 07:27:51PM +0700, Suravee Suthikulpanit wrote:
> 
>> - Also, it seems that the current iommu v2 page table use case, where GVA->GPA=SPA
>> will no longer be supported on system w/ SNPSup=1. Any thoughts?
> 
> Support for that is not upstream yet, it should be easy to disallow this
> configuration and just use the v1 page-tables when SNP is active. This
> can be handled entirely inside the AMD IOMMU driver.
> 

Actually, I am referring to when user uses the IOMMU v2 table for shared virtual address
in current iommu_v2 driver (e.g. amd_iommu_init_device(), amd_iommu_bind_pasid).

Best Regards,
Suravee