Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220525205626.2482584-1-robh@kernel.org> <Yo6u6jcVSsTQvRiU@pendragon.ideasonboard.com>
In-Reply-To: <Yo6u6jcVSsTQvRiU@pendragon.ideasonboard.com>
From:   Robert Foss <robert.foss@linaro.org>
Date:   Thu, 26 May 2022 13:54:34 +0200
Message-ID: <CAG3jFyvynnMfkHFcfLUE=g9pswy1OYiAYi4KVy+aZjGd=NmtGg@mail.gmail.com>
Subject: Re: [PATCH] dt-bindings: display: ingenic,jz4780-hdmi: Drop
 undocumented 'ddc-i2c-bus'
To:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc:     Rob Herring <robh@kernel.org>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        "H. Nikolaus Schaller" <hns@goldelico.com>,
        dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, 26 May 2022 at 00:34, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hi Rob,
>
> Thank you for the patch.
>
> On Wed, May 25, 2022 at 03:56:26PM -0500, Rob Herring wrote:
> > While 'ddc-i2c-bus' is a common property, it should be in a connector
> > node rather than the HDMI bridge node as the I2C bus goes to a
> > connector and not the HDMI block. Drop it from the example.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> > ---
> >  .../devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml  | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml
> > index b8219eab4475..89490fdffeb0 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml
> > +++ b/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml
> > @@ -55,7 +55,6 @@ examples:
> >          compatible = "ingenic,jz4780-dw-hdmi";
> >          reg = <0x10180000 0x8000>;
> >          reg-io-width = <4>;
> > -        ddc-i2c-bus = <&i2c4>;
> >          interrupt-parent = <&intc>;
> >          interrupts = <3>;
> >          clocks = <&cgu JZ4780_CLK_AHB0>, <&cgu JZ4780_CLK_HDMI>;
>
> --
> Regards,
>
> Laurent Pinchart

Applied to drm-misc-next