Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 27 May 2022 10:36:55 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Eugenio Perez Martin <eperezma@redhat.com>
Cc:     Stefano Garzarella <sgarzare@redhat.com>,
        "Dawar, Gautam" <gautam.dawar@amd.com>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "virtualization@lists.linux-foundation.org" 
        <virtualization@lists.linux-foundation.org>,
        Jason Wang <jasowang@redhat.com>,
        Zhu Lingshan <lingshan.zhu@intel.com>,
        "martinh@xilinx.com" <martinh@xilinx.com>,
        "ecree.xilinx@gmail.com" <ecree.xilinx@gmail.com>,
        Eli Cohen <elic@nvidia.com>, Parav Pandit <parav@nvidia.com>,
        Wu Zongyong <wuzongyong@linux.alibaba.com>,
        "dinang@xilinx.com" <dinang@xilinx.com>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Xie Yongji <xieyongji@bytedance.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "martinpo@xilinx.com" <martinpo@xilinx.com>,
        "pabloc@xilinx.com" <pabloc@xilinx.com>,
        Longpeng <longpeng2@huawei.com>,
        "Piotr.Uminski@intel.com" <Piotr.Uminski@intel.com>,
        "Kamde, Tanuj" <tanuj.kamde@amd.com>,
        Si-Wei Liu <si-wei.liu@oracle.com>,
        "habetsm.xilinx@gmail.com" <habetsm.xilinx@gmail.com>,
        "lvivier@redhat.com" <lvivier@redhat.com>,
        Zhang Min <zhang.min9@zte.com.cn>,
        "hanand@xilinx.com" <hanand@xilinx.com>
Subject: Re: [PATCH v3 2/4] vhost-vdpa: introduce STOP backend feature bit
Message-ID: <20220527073654.GM2168@kadam>
References: <20220525105922.2413991-1-eperezma@redhat.com>
 <20220525105922.2413991-3-eperezma@redhat.com>
 <BL1PR12MB582520CC9CE024149141327499D69@BL1PR12MB5825.namprd12.prod.outlook.com>
 <CAJaqyWc9_ErCg4whLKrjNyP5z2DZno-LJm7PN=-9uk7PUT4fJw@mail.gmail.com>
 <20220526090706.maf645wayelb7mcp@sgarzare-redhat>
 <CAJaqyWf7PumZXy1g3PbbTNCdn3u1XH3XQF73tw2w8Py5yLkSAg@mail.gmail.com>
 <20220526132038.GF2168@kadam>
 <CAJaqyWe4311B6SK997eijEJyhwnAxkBUGJ_0iuDNd=wZSt0DmQ@mail.gmail.com>
 <20220526190630.GJ2168@kadam>
 <CAJaqyWdfWgC-uthR0aCjitCrBf=ca=Ee1oAB=JumffK=eSLgng@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJaqyWdfWgC-uthR0aCjitCrBf=ca=Ee1oAB=JumffK=eSLgng@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JmhiIiYeWK0ceLp3fpPEzWxsp6D4JCgYWRsoCvyI8fPtLuHMKX/ViDy4SC3a?=
 =?us-ascii?Q?eV4+Z63sW4TGM2j2MIPwLYZ+0AklHRQbZkJyGffJlJEdcvBoZXnAAIsriAuM?=
 =?us-ascii?Q?95p+tfNeMTOtCCXg/f/ZXgpyU2my78J9GqAsoXluVUe+vM6xi1PlyLVFK1zf?=
 =?us-ascii?Q?qg+oud0zNGuBWc5WkayzoTXOfoo4Wg4FVocnQKt103QHdLlcMmL4O0B389kl?=
 =?us-ascii?Q?3GAn6gisqRF50+qez3hcfYd5YeEVdi12kflTa5qSaXlyJj83wkPOArn0sz3J?=
 =?us-ascii?Q?Ln7EWad5QOU56/UpngXJVJ+MHTh9RIYPz6dKKQSNFj3JybWkYb8xl780lU51?=
 =?us-ascii?Q?wce0VV9IMqq3mmyYOmYU9vKDFYsYIQCV3A0FEX9pyfkE/pCoejGO36j8LcRA?=
 =?us-ascii?Q?nJP5eTA6oNzcY0vazNuT26Q7/GTgllcuR0TdU7NUAXKH0OxMUaavGQt1ghjw?=
 =?us-ascii?Q?iBR+Mi+EdXEeAhSOjHXPH9v7fSrLXL9fcO0ghHj7BY60XYkARog3WZe7EhU9?=
 =?us-ascii?Q?cP9kvgr7jZRcCbaJMu40HMfGlL5mEYEdoWXKz6B5TN8qKTwaGZnWpo9o4rIt?=
 =?us-ascii?Q?XeHj8OUgQuh829bhq2cEsQbNFiQTAjF47r21q3VLR8fwzoPdL0vRGM7TeADP?=
 =?us-ascii?Q?EGvuxv8LV1LJTovkJZ5SNpnhTNhBCPLOgrQY8oHjpsvnc56Xu9nRkl6dDmP6?=
 =?us-ascii?Q?21jhgkDE+IAji4pxO/TpHIio7YDO6l6wlSxY7K6JBDEqyHcGy/f9rDtslneB?=
 =?us-ascii?Q?WcHc1ukglXxyDMukVX3VtUSnEPiebXBWu+wMYYS9RtCaeyhn56O7IEeTACOl?=
 =?us-ascii?Q?K18oaOLf3EyWaIZBKW9jQbxwO4/I0Y9q64jcnZLO1+dn2wujADVLyRk7Kygv?=
 =?us-ascii?Q?ZUCQiuCzYDveN3/kkTCjXlzKYVYqluMO7KiL9NEsqGhAh09Uky8hEQAofDUm?=
 =?us-ascii?Q?BIzEVXIucmqMhkJv7uJ3A974CpSLIBQcPkt954BOR+5mL21h2hJMWVElS3pd?=
 =?us-ascii?Q?cjo8OR8PZIQAjrTTIUfvUkiLpKVmrjrJISH2i4EJPjehsGyu816ZfIEtY9uy?=
 =?us-ascii?Q?H9ArhCINJ1g7HSo7dFbVPFFOEUWldh5raTZ1VEru4GEa3X4KO8UxF4ixwmzJ?=
 =?us-ascii?Q?jFMmVGR5GMzwEoSHEPc2cOsUoZW0oumkcDMQjSt4zneIjaCDCjIA/bt8ZOk0?=
 =?us-ascii?Q?WOoxakO8+gctdb5c7HTdwHYthQyRfFwoKjMD3mIiqrVbVPiup9sa1Pq+eXpA?=
 =?us-ascii?Q?f40YxP3RyiXqhAHo+nZ3ySKfWw9z1RxgSZWHU9PL7vRCAnqZ5qmguXVQ2Xnr?=
 =?us-ascii?Q?0qYZv5YQ9dcgD52UtgjQ/rYkRcOZXRvBRPxZg2mVhfJ/IVN6HYmRpS9GvvO3?=
 =?us-ascii?Q?vDkk8rvNIgv/dYZRQwPrCGAU/GuTQbg07KDPgbuJKKH+YPhcwgbovBxRLDO5?=
 =?us-ascii?Q?YQLgfHU4YtMZ1gnHe3UVe/3NRSTWwHDQnUpiZQr7xJ0w5P2SbjI+i4N2Pji1?=
 =?us-ascii?Q?RoSqlKfhazkdd6Q1xz3SYzDgjhRHzROhTWrVHa2dFMhne7p/d6DUMWSQAFEQ?=
 =?us-ascii?Q?IOAzIcmLq9vashVBr1rnZVSSdqi+FU2PMda+kerfwO1UWOXGyXyH9VUlqZb0?=
 =?us-ascii?Q?rqyiLRFWVo82TUgazjVRznoM82eJwmqcteY2Ky2gRx7iQtexeO2ZsserM+9Q?=
 =?us-ascii?Q?q2BAITTj3vAHX7f1FvhRoVwgvGYg4tOwfilozyZO/q9Vf85cClNnpf4gDxO1?=
 =?us-ascii?Q?6WvV/CaFeQNc4afuxxNnigjgaElxZAE=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 37b11589-85bb-462d-74fe-08da3fb3be44
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2022 07:37:25.2387
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qrQDI716L5CVwrFqG9HRdSf12K0UcTeKyr4YuAWHFHoLygwJEP2IdNKZsMcOdtUVQOghImwuOTRX40q+uOBFy06OUmR0K+yzxq0bTDUJAC0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5257
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.874
 definitions=2022-05-27_02:2022-05-25,2022-05-27 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 malwarescore=0
 mlxlogscore=999 bulkscore=0 suspectscore=0 adultscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2205270037
X-Proofpoint-GUID: qMVQANjfSk5cMv_82jJE4PkXdHKLEP70
X-Proofpoint-ORIG-GUID: qMVQANjfSk5cMv_82jJE4PkXdHKLEP70
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, May 27, 2022 at 08:50:16AM +0200, Eugenio Perez Martin wrote:
> On Thu, May 26, 2022 at 9:07 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >
> > On Thu, May 26, 2022 at 07:00:06PM +0200, Eugenio Perez Martin wrote:
> > > > It feels like returning any literal that isn't 1 or 0 should trigger a
> > > > warning...  I've written that and will check it out tonight.
> > > >
> > >
> > > I'm not sure this should be so strict, or "literal" does not include pointers?
> > >
> >
> > What I mean in exact terms, is that if you're returning a known value
> > and the function returns bool then the known value should be 0 or 1.
> > Don't "return 3;".  This new warning will complain if you return a known
> > pointer as in "return &a;".  It won't complain if you return an
> > unknown pointer "return p;".
> >
> 
> Ok, thanks for the clarification.
> 
> > > As an experiment, can Smatch be used to count how many times a
> > > returned pointer is converted to int / bool before returning vs not
> > > converted?
> >
> > I'm not super excited to write that code...  :/
> >
> 
> Sure, I understand. I meant if it was possible or if that is too far
> beyond its scope.

To be honest, I misread what you were asking.  GCC won't let you return
a pointer with an implied cast to int.  It has to be explicit.  So there
are zero of those.  It's not hard to look for pointers with an implied
cast to bool.

static void match_pointer(struct expression *ret_value)
{
        struct symbol *type;
        char *name;

        type = cur_func_return_type();
        if (!type || sval_type_max(type).value != 1)
                return;

        if (!is_pointer(ret_value))
                return;

        name = expr_to_str(ret_value);
        sm_msg("'%s' return pointer cast to bool", name);
        free_string(name);
}

regards,
dan carpenter