Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp1641566ioo; Fri, 27 May 2022 13:07:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzS18eexmlD7sovlmIBvJOqQAa7KuPeIblN0TqraliXy+0S7jhqp/z1z4+r0ZiTG+g4LLDg X-Received: by 2002:a17:907:3d88:b0:6fe:bcb3:9609 with SMTP id he8-20020a1709073d8800b006febcb39609mr30373296ejc.555.1653682023136; Fri, 27 May 2022 13:07:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653682023; cv=none; d=google.com; s=arc-20160816; b=tHdfCVIoZABNUnTZm43WT5gERyi2+iCG/RMQiPSE0yEhlygitooKFPVBKl5zZgo0Eu nK1eNaFZu8unJJePx1EC0zq3w/9AYxx3tmvGf0dWFuLXILBPoUHws5bWQkog9YX1oEbd JrUe+dl5VAWTx4MSVmdzR4+igUO0DvjMJMwkTZKajRrWUuNYApspvibaGUr1Vhcv0KH8 j5RT9q2o/N0ct5NWxklxH20D7LD1Fd4GIY5zHcdhkHq1mfOGlXpvD1Fe9hqA4cX+18K2 Mfuu1RATDmSub6JJ0sFkjhka/6MMMm2U+l07wJzb7l7dvAJs5W3vIObnxl1opqvbg3fF vLjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=lDIN0F8mvUcIGsiOah6JCrzsC64603zfSeEz/dKmMio=; b=K6VW1ffM/BGjuFipunou/3YLblgVdFoY6wuSx/95geSgY+ataWOWMaE2WPXJ0oAvSj CUsqGne5FTm/KCMyFpfZ6q8jmhntOVK3e2W+yllDgsktCuNjzIhGZJqJ7pCLto5psWZ1 jEU80ARb8/lNwL3OV3L2Cp+R9RK7RCl/T5SXHG+z6Nj+m4S9AAewTNqliteu+0aiw3NE XwOqJCOgDOaoaaASSqOEOdstdjSqVF5tu2x/8nxgHMi1u6Ptc/yXwfrF1arsdKEXwIbc ZtuEvjolagrolM9cme0xz7bnRWt9jdDjyLqftpG/rCmIoY8NSOaX1ODr4VUH87XvoIZZ rNkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b="olZ/4QEj"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m18-20020a056402511200b0042aece2ebf2si6317262edd.276.2022.05.27.13.06.35; Fri, 27 May 2022 13:07:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b="olZ/4QEj"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348066AbiEZQKL (ORCPT + 99 others); Thu, 26 May 2022 12:10:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235654AbiEZQKK (ORCPT ); Thu, 26 May 2022 12:10:10 -0400 Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E9A15DBDF for ; Thu, 26 May 2022 09:10:08 -0700 (PDT) Received: by mail-qk1-x735.google.com with SMTP id 135so1839166qkm.4 for ; Thu, 26 May 2022 09:10:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=lDIN0F8mvUcIGsiOah6JCrzsC64603zfSeEz/dKmMio=; b=olZ/4QEjQFmPMP59XTnjcoZ/IIDwnh9ZjBNh4mITNRa2SGio88rIvmn77mWSmsyhnS 1+My7HsltQdc2zU6sKYLAIOvlxtEKbLNq2RZTXfRw0rh+WjeBDqAoOQ7QuUvnqwko4zG Bp7b8/ThHTGaoJx7noACCWKr7TdO/piuRapEvKlkkx65IDM6tZN7NCywfKkjvdid0Gzh jYLbsfouWZFQoOxa4OaCfLwhg7wXO1UtTCzjzuaZ0+6TmoEwsfvfyl3vi7ZpufE2/uSf 7U9QTSX8VJbSStJcKOUtySPIl/D9jnDea58T6Pa7IWCpmu/uPqbo0d0KPakyfxrK3MrG W8bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lDIN0F8mvUcIGsiOah6JCrzsC64603zfSeEz/dKmMio=; b=JOIXXSmiL1G9mPzzbU4Jmhu4E8MGxjBZUBaU4S/9b9/iyBqENQKtMgRWUBJPTfK0O2 J2o6A+J/PWTn3UmHWX4K7fEtUU/R0PMw8duuR71osrIEAghs4BaV6HarGv1ebeC0eeEj Jr1muKCxhiWdyCdQpBuadBHay/LnHDJYoAesfcGY1OveUWljKrDHzqstHYTBgBb0dBEh g7c8hNHQ1K+bVSi64ZUHjQAxQOb6fJ0E1ms+059UvyWAv6uHrhvn4opy5qdA24eO1MYG mTfAup97jzfRNVVDzrc8EjInEG1FZm77bhg4dGAVjD2lBeaU7vBNJXoZ47IqQduB8pLA hPZQ== X-Gm-Message-State: AOAM533K3ZQiqhXDXv85PUfMkVK603lXIVi+BWu0ModIuODf5HmOUENr lrXjtrEb9QhQqelFSbOmt1k/5wssLHXd1w== X-Received: by 2002:a37:be06:0:b0:6a1:429:a49f with SMTP id o6-20020a37be06000000b006a10429a49fmr24912713qkf.6.1653581407480; Thu, 26 May 2022 09:10:07 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:741f]) by smtp.gmail.com with ESMTPSA id 2-20020a370802000000b0069fc13ce204sm1353030qki.53.2022.05.26.09.10.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 May 2022 09:10:06 -0700 (PDT) Date: Thu, 26 May 2022 12:10:05 -0400 From: Johannes Weiner To: Chen Wandun Cc: tj@kernel.org, lizefan.x@bytedance.com, surenb@google.com, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] psi: dont alloc memory for psi by default Message-ID: References: <20220526122656.256274-1-chenwandun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220526122656.256274-1-chenwandun@huawei.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 26, 2022 at 08:26:56PM +0800, Chen Wandun wrote: > Memory about struct psi_group is allocated by default for > each cgroup even if psi_disabled is true, in this case, these > allocated memory is waste, so alloc memory for struct psi_group > only when psi_disabled is false. > > Signed-off-by: Chen Wandun Looks good to me, Acked-by: Johannes Weiner Tejun, would you mind taking this through the cgroup tree?