Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Eiichi Tsukata <eiichi.tsukata@nutanix.com>
To:     rafael@kernel.org, daniel.lezcano@linaro.org, rostedt@goodmis.org,
        mingo@redhat.com, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, joao.m.martins@oracle.com,
        mtosatti@redhat.com
Cc:     Eiichi Tsukata <eiichi.tsukata@nutanix.com>
Subject: [PATCH v4] cpuidle: haltpoll: Add trace points for guest_halt_poll_ns grow/shrink
Date:   Fri, 27 May 2022 00:53:45 +0000
Message-Id: <20220527005345.189906-1-eiichi.tsukata@nutanix.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wP4L+zDkL/k9GWLtF2Xu+PR1w7ol9MhqeKhh2wf21lNEhsGkt48rsI6TQ9a/?=
 =?us-ascii?Q?aZYYAq7w9B5GTeRR0wgYelvKF8LIN68kxeLLdPnCWynknk1mV/zIumtdIJpo?=
 =?us-ascii?Q?2YGCRuFWD2LEpmSabzXPt97IVOsSZsUlVoIbKjUjI7Ul0q3aj30Q5GdKvdQn?=
 =?us-ascii?Q?c59HxxXthuns5n8WJZ3iOF2lCPp7O2pK04+3xDFQTRDx6oYi72rKBxmtHKNp?=
 =?us-ascii?Q?NtxeZJWf9dlQi563HRLCXdNY2EX+WUYhnrEKHGFGHFoIMVovnc1/K/pEU5eQ?=
 =?us-ascii?Q?/5agNYhJ6+hGNCvTGC3K5yrEZXJyxZZv8YCvQsYZZKMszrRsYJiVjMOwi5zB?=
 =?us-ascii?Q?wdL0cxp+cGT1CfDBtIVXzCL87ptmhKQpzZp6dap5ANejHiZNKRu4EVsRiYci?=
 =?us-ascii?Q?4iCa72g5ouyR8keqagB3FJwih3dvwalpU5e/bHNB22I2q0Co8oHt35egFbEo?=
 =?us-ascii?Q?w2nCDEyopInlI0laBRGmt8Pwsl0cDf3VzWyPng28qjSJ5699UowuLcHOCct5?=
 =?us-ascii?Q?IRxc74zXscg/HkeuqPJ7m3jAvsI8j/8Cu5KgHOFX3z7stYFAkFpeIFrPcWGs?=
 =?us-ascii?Q?mnKVJBbIAZC/5ch2eGKp+1ds4z0yhWNAcxdphrHd4pTMr6Gn1Ycji8MtbK8l?=
 =?us-ascii?Q?thheieQ9bkIdllgkchAJAIzeJGe0wSfSpLVljurUf5eJidy+bWX+KC6ZhSQf?=
 =?us-ascii?Q?Y48apd5Ile0bTmpCOffCv5O5VAv1KwSWPZX8JJRQymjzNGtf0KclC7qF/4LE?=
 =?us-ascii?Q?zUQiVIe8C2faHmKkzy9MrKyuKYKyAP3f2c/ZsNZtCMT4n43WwbvSDfhkCK8V?=
 =?us-ascii?Q?rkg6d/N4VotzRhVmheG05PHazFXZlDFrIktS9iTMfUWcUF6ixgGQ1OWfiODS?=
 =?us-ascii?Q?Rydzfb5bBp5XyrXNyPqf3BRuTyDMqiRYHldTivjBMDWEPiz8lXl2M2dR+EEZ?=
 =?us-ascii?Q?eGaBUCiUanBGGuGBAYc5o6WfG/pSprMcUJLcwFzuWQw+vDRBQFGYwqi6aX8o?=
 =?us-ascii?Q?usbC6miwTcHuRPDaZrNokQIGc1hVSuSZf3woZnvxrU9veCbHiVd9htRKeR1Q?=
 =?us-ascii?Q?8iOo52kWvS8M7LVD22HQT8oGVUSLFkjkZXaqDUWIxHPC8O/j2m2o5F5FZjCE?=
 =?us-ascii?Q?p7CiLKpRMqfYYSBokWcbgwk3ND3WOiH3kRqvVyjHmC1tNTdAzqfF8Oz5FRBN?=
 =?us-ascii?Q?mMri6kHn0qgdIRoKAe3PjvDcB1E02nSGkYQz2OdbebEki3FEeutfFsLGoLER?=
 =?us-ascii?Q?dtI8oaNXH6fjPx2zrCBH57RS2IGs1Tpoc8hEwWRwSxxctXp43a3zlqYhiaRy?=
 =?us-ascii?Q?QSYWm9UtMNSPEpsnIVD/OLkTIg7vmvdPFmvM2LSM+oYzgOsUjLHp1LmpucvP?=
 =?us-ascii?Q?hRK8FKTWmE9XuzgYnPWXUiBZpnGr+3ySWBZ5L837DaIoe/TgphfOeIeblhgK?=
 =?us-ascii?Q?jAvpRIO56FkW4rfDuMT0hFGI42+tOI3Uh5ocU47no9xs9sOpNF1QT0V1eQTo?=
 =?us-ascii?Q?dA+XKSdrowLvostI3fVQC4r3svlsWUha9L8DyrdJwTQSp2qdNCY7q5kWVRr1?=
 =?us-ascii?Q?tZMJSCxBqL5Jene6ts42gA69mBrWm/29b0ZhnD87adnk82OwHNOzWBevGz++?=
 =?us-ascii?Q?pvwmbVu7prE1PErR/tbmR+Xp7TnbcCO/p3Q1E/ibnvyUD/NPqueWEjZdfRnK?=
 =?us-ascii?Q?kh49WIhf9fobMel+aZOzYNntmwqM6G1FuJSqwy/GRUcNPX95xa688pqjRzvy?=
 =?us-ascii?Q?x0uMMjgLnXApnPjxsj0jFXAvw8FoCH8=3D?=
X-OriginatorOrg: nutanix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ce5551f-d2dd-4aad-b7e1-08da3f7b5fda
X-MS-Exchange-CrossTenant-AuthSource: CH0PR02MB8041.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2022 00:53:54.9306
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ivBDoLWfY6e4m7Ztp4GOkkEiDrcG8wLmvt4cD//mW4i/DYtuM6SvylueyqicxahpFdRI34B88gDe1/4HSqJhLQNtoXFbvfmnVM7LWRhdMwA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR02MB8982
X-Proofpoint-GUID: APKy6j5gwdFqqnSkGztNAmHmLcsx27LU
X-Proofpoint-ORIG-GUID: APKy6j5gwdFqqnSkGztNAmHmLcsx27LU
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514
 definitions=2022-05-26_12,2022-05-25_02,2022-02-23_01
X-Proofpoint-Spam-Reason: safe
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Add trace points as are implemented in KVM host halt polling.
This helps tune guest halt polling params.

Signed-off-by: Eiichi Tsukata <eiichi.tsukata@nutanix.com>
---
 drivers/cpuidle/governors/haltpoll.c |  3 +++
 include/trace/events/power.h         | 29 ++++++++++++++++++++++++++++
 2 files changed, 32 insertions(+)

diff --git a/drivers/cpuidle/governors/haltpoll.c b/drivers/cpuidle/governors/haltpoll.c
index cb2a96eafc02..1dff3a52917d 100644
--- a/drivers/cpuidle/governors/haltpoll.c
+++ b/drivers/cpuidle/governors/haltpoll.c
@@ -19,6 +19,7 @@
 #include <linux/sched.h>
 #include <linux/module.h>
 #include <linux/kvm_para.h>
+#include <trace/events/power.h>
 
 static unsigned int guest_halt_poll_ns __read_mostly = 200000;
 module_param(guest_halt_poll_ns, uint, 0644);
@@ -90,6 +91,7 @@ static void adjust_poll_limit(struct cpuidle_device *dev, u64 block_ns)
 		if (val > guest_halt_poll_ns)
 			val = guest_halt_poll_ns;
 
+		trace_guest_halt_poll_ns_grow(val, dev->poll_limit_ns);
 		dev->poll_limit_ns = val;
 	} else if (block_ns > guest_halt_poll_ns &&
 		   guest_halt_poll_allow_shrink) {
@@ -100,6 +102,7 @@ static void adjust_poll_limit(struct cpuidle_device *dev, u64 block_ns)
 			val = 0;
 		else
 			val /= shrink;
+		trace_guest_halt_poll_ns_shrink(val, dev->poll_limit_ns);
 		dev->poll_limit_ns = val;
 	}
 }
diff --git a/include/trace/events/power.h b/include/trace/events/power.h
index af5018aa9517..c708521e4ed5 100644
--- a/include/trace/events/power.h
+++ b/include/trace/events/power.h
@@ -500,6 +500,35 @@ DEFINE_EVENT(dev_pm_qos_request, dev_pm_qos_remove_request,
 
 	TP_ARGS(name, type, new_value)
 );
+
+TRACE_EVENT(guest_halt_poll_ns,
+
+	TP_PROTO(bool grow, unsigned int new, unsigned int old),
+
+	TP_ARGS(grow, new, old),
+
+	TP_STRUCT__entry(
+		__field(bool, grow)
+		__field(unsigned int, new)
+		__field(unsigned int, old)
+	),
+
+	TP_fast_assign(
+		__entry->grow   = grow;
+		__entry->new    = new;
+		__entry->old    = old;
+	),
+
+	TP_printk("halt_poll_ns %u (%s %u)",
+		__entry->new,
+		__entry->grow ? "grow" : "shrink",
+		__entry->old)
+);
+
+#define trace_guest_halt_poll_ns_grow(new, old) \
+	trace_guest_halt_poll_ns(true, new, old)
+#define trace_guest_halt_poll_ns_shrink(new, old) \
+	trace_guest_halt_poll_ns(false, new, old)
 #endif /* _TRACE_POWER_H */
 
 /* This part must be outside protection */
-- 
2.36.1