Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220526113350.30806-1-linmiaohe@huawei.com> <Yo+B4b0nF+kI35pG@casper.infradead.org>
 <CA+CK2bBBLjr3kGqc=zA6M5773G6gj83LB_kwwOCNuFX8YoUp+w@mail.gmail.com> <20220526111546.50102da288cccbe913cadbf4@linux-foundation.org>
In-Reply-To: <20220526111546.50102da288cccbe913cadbf4@linux-foundation.org>
From:   Pasha Tatashin <pasha.tatashin@soleen.com>
Date:   Thu, 26 May 2022 14:31:06 -0400
Message-ID: <CA+CK2bBJ3baj2Qt+9Wy1r==_Uym_UZJ+S-HRwFAsspPamctk_Q@mail.gmail.com>
Subject: Re: [PATCH] mm/page_table_check: fix accessing unmapped ptep
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Matthew Wilcox <willy@infradead.org>,
        Miaohe Lin <linmiaohe@huawei.com>,
        David Rientjes <rientjes@google.com>,
        linux-mm <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

> > Miaohe, please store the ptep, or maybe drop this patch entirely.
>
> I think it's best to fix it.  I rewrote the changelog as
>
> : ptep is unmapped too early, so ptep could theoretically be accessed while
> : it's unmapped.  This might become a problem if/when CONFIG_HIGHPTE becomes
> : available on riscv.
> :
> : Fix it by deferring pte_unmap() until page table checking is done.
>
> I'll retain the Fixes:.  This doesn't imply cc:stable in MM, and anyone
> who backports the original patchset will want to know about this fixup.
Makes sense.


> And I queued a fixup for the thing Matthew noticed.
Thank you Andrew.

Pasha