Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp1778440ioo; Fri, 27 May 2022 17:24:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXnNWjBL+deBKW9mM3eqG9kVFCQT4aS+O+m9pYnegfh4eA1ABHlW5FJ+5x43OE4qlHPzBM X-Received: by 2002:a63:6846:0:b0:3c6:cb42:cdb2 with SMTP id d67-20020a636846000000b003c6cb42cdb2mr39043815pgc.511.1653697492289; Fri, 27 May 2022 17:24:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653697492; cv=none; d=google.com; s=arc-20160816; b=KwfLyC7nNMSWWMPp1vNpQAW3Fgg1NuEXytdQWVBfR2Vy48yzbjcll2JbqPSxHYsQ4n YC6zq9uyZFbN2IGcuebLueV+zAAzuLHCvrOwu/h8/0ztl/9WTiSyEB4MVMpOTWkMT8Of 1JqK6JUKj4/icxHDt7fvjap/TX1CoFNzjAFB/xxsAiwZZsJbwatJ1ZNStpBmLfUf4xsu 5TdN77Qr+Gt8uRRP/X86RxnNQxCChl840s5Rak3NSAsVlo447mWGvDZD3i3UNfk+D+ZY ID/R0gBmnIvgDueYjpImQ2/4XTuqEreLxygKyCmjTAxEn5N/tj3A+gOUNvhacyw0/WI7 Oitw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=MdaCAYKPMrUNYugf6nu4OyxpClXSxPhr2HuLrA18wKs=; b=SEqD/e0g9ydFKfe5+yLSnEcH9W7vOWJsqLS24kwH1eEU8EZcpPDk/8jBvUuWXGPlL0 450W0JJIbgrT2N/MOHE5jyF5JKN5Zz1jx/fAGdFyq1ZLav1oqMq4PQsiSVN1TSAdNEol c/j+TSfGUstU0a1yn60bqLka/dZPwivB5RoUMWxYwixXzchqFMI7tMlLpU9XHXrJFoKm Oq1w7csvrBWEoJdnYVgpx5i0b657ZmqB/RC6DrbY3H6mD+AXlt2O7Qw3lN34qfsfK7Ez N7xSWCzNd+EnvW0YKN3ajd4K6m7KF0cFNs2BYrCBTqNCtc2ydf1OQdF4cTyV4+BbBbHg TPmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bRsdZbv9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d123-20020a636881000000b003f62669e1a7si7649638pgc.767.2022.05.27.17.24.39; Fri, 27 May 2022 17:24:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bRsdZbv9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239136AbiE0Dmf (ORCPT + 99 others); Thu, 26 May 2022 23:42:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229768AbiE0Dmd (ORCPT ); Thu, 26 May 2022 23:42:33 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B17610CD; Thu, 26 May 2022 20:42:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 187EA61DA0; Fri, 27 May 2022 03:42:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED3F3C385A9; Fri, 27 May 2022 03:42:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653622947; bh=MdaCAYKPMrUNYugf6nu4OyxpClXSxPhr2HuLrA18wKs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bRsdZbv9XmtCnV2EOek8DfArcBpbJDh/3IAd44eJJenVazyG/YImbSChLvLVPUvD/ rzNix7OgkF9JgQQWAZUDnTA4XQY64wZ/BMjnD2CgNZiRGRgU6GxzrF3TfQ2yaRsU1m Zy0+DmfGm4yKsqbSZbjVxLsajVfrBUuCh0SkP0whrmOU5yEse1Qpo2z+LbdRiG1bzr puHcv4hIHC1a/xyUCOj04F2LNXFDy3nyiglumUYMZB0REuef9aWqau/HUV9sOVmXVv Lbf3+r9rCakMW+6AdC5x4cDFbvyOdFqIDruBNC7kr6NCc6hlY/V7iwSE8akjJ15InZ TpwBSfslcMbAA== Date: Thu, 26 May 2022 20:42:25 -0700 From: Jakub Kicinski To: =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= Cc: Vladimir Oltean , Andrew Lunn , Pavel Skripkin , Claudiu Manoil , "alexandre.belloni@bootlin.com" , "UNGLinuxDriver@microchip.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] net: ocelot: fix wrong time_after usage Message-ID: <20220526204225.03b7804c@kernel.org> In-Reply-To: <20220523160004.6d285609@fixe.home> References: <20220520213115.7832-1-paskripkin@gmail.com> <20220521162108.bact3sn4z2yuysdt@skbuf> <20220523160004.6d285609@fixe.home> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 23 May 2022 16:00:04 +0200 Cl=C3=A9ment L=C3=A9ger wrote: > > If you're looking at me, I don't have the hardware to test, sorry. > > Frame DMA is one of the components NXP removed when building their DSA > > variants of these switches. But the function is called once or twice per > > NAPI poll cycle, so it's worth optimizing as much as possible. > >=20 > > Clement, could you please do some testing? The patch that Andrew is > > talking about is 35da1dfd9484 ("net: dsa: mv88e6xxx: Improve performance > > of busy bit polling"). =20 >=20 > Ok, I'll have to wake up that ocelot board but I'll try to do that. We can't hold it in PW for much longer, please repost once tested.