Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v2] coresight: etm4x: Add Support for HiSilicon ETM device
To:     Alexei Budankov <abudankov@huawei.com>,
        Linuxarm <linuxarm@huawei.com>, <gregkh@linuxfoundation.org>,
        <mathieu.poirier@linaro.org>, <suzuki.poulose@arm.com>,
        <mike.leach@linaro.org>
CC:     <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>,
        Alexey Budankov <alexey.budankov@huawei.com>
References: <1597323562-3706-1-git-send-email-liuqi115@huawei.com>
 <853b6d52-da86-1c06-3604-3085ece331a4@huawei.com>
 <5dd1bd83-232a-07e4-8fde-e4f6cd0e5b8c@huawei.com>
 <93b92859-2229-8766-09d2-df16e1ebd4e8@huawei.com>
From:   "liuqi (BA)" <liuqi115@huawei.com>
Message-ID: <50c25ce8-15bc-80a8-59dc-a20571a6460a@huawei.com>
Date:   Thu, 26 May 2022 15:47:51 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <93b92859-2229-8766-09d2-df16e1ebd4e8@huawei.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2022/5/26 15:23, Alexei Budankov wrote:
> Hi Qi,
> 
> On 26.05.2022 5:56, liuqi (BA) wrote:
>>
>> Hi Alexei,
>>
>> On 2022/5/25 23:10, Alexei Budankov wrote:
>>>
>>> Hi Qi Liu,
>>>
>>> On 13.08.2020 15:59, Qi Liu wrote:
>>>> Add ETMv4 periperhal ID for HiSilicon Hip08 and Hip09 platform. Hip08
>>>> contains ETMv4.2 device and Hip09 contains ETMv4.5 device.
>>>>
>>>> Signed-off-by: Qi Liu <liuqi115@huawei.com>
>>>> ---
>>>>    drivers/hwtracing/coresight/coresight-etm4x.c | 2 ++
>>>>    1 file changed, 2 insertions(+)
>>>
>>> Thanks for your patch.
>>> I would like to test HiSilicon ETM device feature on
>>> Kunpeng 920 based server.
>>> I applied the patch and booted the kernel with the changes.
>>> However I don't see any device files neither here:
>>> /sys/bus/coresight/devices/
>>
>> Thanks for your test :)
> 
> Thanks for quick reply. Appreciate it much. :)
> 
>>
>> Kunpeng 920 platform(Non-PG) support tracing CPU instruction, source device is coresight ETM, link device is coresight funnel and sink device is ultrasoc SMB. So you need to insmod coresight-* driver and SMB driver, which patch is :
>> Add support for UltraSoc System Memory Buffer
>> https://lore.kernel.org/linux-arm-kernel/20220416083953.52610-1-liuqi115@huawei.com/
> 
> I will try it shortly and let you know.
> 
>>
>> by the way, can you help to check /sys/bus/amba/devices/, and make sure that the firmware of your board has supported ETM, funnel and SMB devices?
> 
> Here we go:
> 
> huawei@armubuntu:~$ pwd
> /home/huawei
> huawei@armubuntu:~$ ls /sys/bus/amba/devices/
> huawei@armubuntu:~$
> 
> Look like our server firmware should be upgraded, right?

Yes, seems firmware should be upgraded first, and then you could test 
ETM device :)

Best regards,
Qi
> Your help and support is greatly appreciated.
> > Thanks,
> Alexei
> 
>>
>> Thanks,
>> Qi
>>
>>> nor here:
>>> /sys/bus/event_source/devices/cs_etm/sinks/
>>> What should a user expect new in os with this patch added?
>>
>>
>>>
>>> Thanks,
>>> Alexei
>>>
>>
>>
>>>
>>>>
>>>> diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c
>>>> index 6d7d216..7797a57 100644
>>>> --- a/drivers/hwtracing/coresight/coresight-etm4x.c
>>>> +++ b/drivers/hwtracing/coresight/coresight-etm4x.c
>>>> @@ -1587,6 +1587,8 @@ static const struct amba_id etm4_ids[] = {
>>>>        CS_AMBA_UCI_ID(0x000bb805, uci_id_etm4),/* Qualcomm Kryo 4XX Cortex-A55 */
>>>>        CS_AMBA_UCI_ID(0x000bb804, uci_id_etm4),/* Qualcomm Kryo 4XX Cortex-A76 */
>>>>        CS_AMBA_UCI_ID(0x000cc0af, uci_id_etm4),/* Marvell ThunderX2 */
>>>> +    CS_AMBA_UCI_ID(0x000b6d01, uci_id_etm4),/* HiSilicon-Hip08 */
>>>> +    CS_AMBA_UCI_ID(0x000b6d02, uci_id_etm4),/* HiSilicon-Hip09 */
>>>>        {},
>>>>    };
>>>>
>>>> -- 
>>>> 2.8.1
>>> .
>> .
> .
>