Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 27 May 2022 14:26:33 +0530
From:   Pavan Kondeti <quic_pkondeti@quicinc.com>
To:     Prashanth K <quic_prashk@quicinc.com>
CC:     Matthias Brugger <matthias.bgg@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Pavankumar Kondeti <quic_pkondeti@quicinc.com>,
        Pratham Pratap <quic_ppratap@quicinc.com>,
        <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: common: usb-conn-gpio: Allow wakeup from system
 suspend
Message-ID: <20220527085633.GB17518@hu-pkondeti-hyd.qualcomm.com>
References: <1653634146-12215-1-git-send-email-quic_prashk@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1653634146-12215-1-git-send-email-quic_prashk@quicinc.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk

On Fri, May 27, 2022 at 12:19:06PM +0530, Prashanth K wrote:
> Currently the VBUS/ID detection interrupts are disabled during system
> suspend. So the USB cable connect/disconnect event can't wakeup the
> system from low power mode. To allow this, we keep these interrupts
> enabled and configure them as wakeup capable. This behavior can be
> controlled through device wakeup source policy by the user space.
> 
> Signed-off-by: Prashanth K <quic_prashk@quicinc.com>
> ---
>  drivers/usb/common/usb-conn-gpio.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/drivers/usb/common/usb-conn-gpio.c b/drivers/usb/common/usb-conn-gpio.c
> index 395f9bb..b39c9f1c 100644
> --- a/drivers/usb/common/usb-conn-gpio.c
> +++ b/drivers/usb/common/usb-conn-gpio.c
> @@ -257,6 +257,7 @@ static int usb_conn_probe(struct platform_device *pdev)
>  	}
>  
>  	platform_set_drvdata(pdev, info);
> +	device_set_wakeup_capable(&pdev->dev, true);
>  
>  	/* Perform initial detection */
>  	usb_conn_queue_dwork(info, 0);
> @@ -286,6 +287,14 @@ static int __maybe_unused usb_conn_suspend(struct device *dev)
>  {
>  	struct usb_conn_info *info = dev_get_drvdata(dev);
>  
> +	if (device_may_wakeup(dev)) {
> +		if (info->id_gpiod)
> +			enable_irq_wake(info->id_irq);
> +		if (info->vbus_gpiod)
> +			enable_irq_wake(info->vbus_irq);
> +		return 0;
> +	}
> +
>  	if (info->id_gpiod)
>  		disable_irq(info->id_irq);
>  	if (info->vbus_gpiod)
> @@ -300,6 +309,14 @@ static int __maybe_unused usb_conn_resume(struct device *dev)
>  {
>  	struct usb_conn_info *info = dev_get_drvdata(dev);
>  
> +	if (device_may_wakeup(dev)) {
> +		if (info->id_gpiod)
> +			disable_irq_wake(info->id_irq);
> +		if (info->vbus_gpiod)
> +			disable_irq_wake(info->vbus_irq);
> +		return 0;
> +	}
> +
>  	pinctrl_pm_select_default_state(dev);
>  
>  	if (info->id_gpiod)

Looks good to me.

Thanks,
Pavan