Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f0b25e5f-5493-d4e2-5bc4-f90d47966c38@intel.com>
Date:   Thu, 26 May 2022 12:08:57 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.9.1
Subject: Re: [PATCH 0/2] bitops: __fls adjustments
Content-Language: en-US
To:     =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= 
        <amadeuszx.slawinski@linux.intel.com>,
        Vineet Gupta <vgupta@kernel.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>
CC:     <linux-snps-arc@lists.infradead.org>,
        <linux-m68k@lists.linux-m68k.org>, <linux-kernel@vger.kernel.org>
References: <20220525144844.1571705-1-amadeuszx.slawinski@linux.intel.com>
From:   Cezary Rojewski <cezary.rojewski@intel.com>
In-Reply-To: <20220525144844.1571705-1-amadeuszx.slawinski@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Si9LalBuT1l1UUtvaWVKV2JDVUtacEk0dUpQbGxLUjRyajJoSXA5cGtMN1NE?=
 =?utf-8?B?NDk2aFY0Z0U3aGV2SU1hdDR3Vk9LWDd3MStNSVFQczBSQ1hweFoyTThqYWwy?=
 =?utf-8?B?WVJjUERkTDdzaENTa0U1dEtvWHg5N2FNUHcrUjZXSkRDVzRhd1crekhtMEJv?=
 =?utf-8?B?TERWWC9zd294dS9QMWhWdUlSUVpZajlWbWZxM0tDU1paNkhSR2lzN2diUGRP?=
 =?utf-8?B?OWcyS3pMOGl4UGc4OWhrL0d5TmxPYkFzQnRIbjRpcGxiWU8zclFlRTJJM3Bo?=
 =?utf-8?B?Wkh3Y0VnTFlXZVZrbFEyRkdrNTN3bUluUXdxT0NXNG81aDd0TElkM21jL0Ix?=
 =?utf-8?B?SklrcmdrQ1YzQjNpMlp6Tmx6bE1qclUwbzVEb1N4eWdvRlhvUWNhQ05RRm5X?=
 =?utf-8?B?U0lJbVdjYUVRZlV4SVVLSVV0M1lGcklodW1sK2VLZ2lPVUpveXpYZFBpaHE3?=
 =?utf-8?B?YW5yOTFqMWN3RmcyUXZiNXo3cW5SYUFibDlVcHZ0eUxaT0ZadENWSWVEeWpl?=
 =?utf-8?B?L0xyNmZPdTB3V0Z5bXVHRlllTzJsT0tPV1YzanhKVFpiQjVxWEhDYUE4ODM5?=
 =?utf-8?B?a2RmbUx6aUZZL0FLSDhZLzhrSVd3RFdZdjBwL2kzelFtWWE4Y3kwTW5IZXdZ?=
 =?utf-8?B?OUt5VVlSc2t0NlM4VGhEMmdCTjRjb3p2Rm5oUXpvdUlmUWdVNGJNUS82VDBV?=
 =?utf-8?B?YU8yL2JjOUxDcXJZVUZDR1lzc21zbnpTeVg2RGd3NVE1QnZxNXR6MWlMTmFt?=
 =?utf-8?B?Z0llM1pSVkUzck0zUVN6cVduOGl5Mlh5RkdIV2liRDJNaDQ0ZDA2UEhOWmFh?=
 =?utf-8?B?UzZZbzVyQVhLZDU0Y2grN3c4WEc5MlB3NC9TUCtqWTgxcVRNT0szVXllVnVZ?=
 =?utf-8?B?cWdnTE41VDRvV245SlpwWGZySVdXbE95aFBPWDU5K3pwaklWZHh5aHNiQkk3?=
 =?utf-8?B?TFpiZWNVT2ZNRFY3MUhNVzBWZHVWUzB6ZUlhWVFPNXJKM2NHMHNsM1IxQWpQ?=
 =?utf-8?B?MUV5RGJtZkZYenBLNHBteWdtNVVVazVWRkRxT3R0TGlJOTU1Rm5JdTZHNGFm?=
 =?utf-8?B?ZEw2eE1HTDg0ZEdDVTZxTkJzWjN6dGp0Z1pzZWxkK2ZmVzA2bEVxRGpvcDR5?=
 =?utf-8?B?ZEZLNlNZSDJPUVY0QjJFbndXaDNQVkNqV1dDbytyS0wxRFZHeVdKeTVzOXdY?=
 =?utf-8?B?M05YTWdkeDMyc1ZZU1h0WnJHMGVTbHQ3eFVxb2NFVXFydVJ1N1hUU2h1ZXlM?=
 =?utf-8?B?UWpkZWx0Z0xjVitKMUdHMCtxalo2bzFFWklmcFpBb25LTm4yMHIydVlteklG?=
 =?utf-8?B?N0hwanNwWmo2b3UyTlRxRzhuSis1SmJxakd5Tm1vVzRpa3hVeHZkTkcrVThl?=
 =?utf-8?B?UE5aTk9YcStSdng3azNXcEVYaGxkRkJpZzRXcm1ZTHlaWHRmS0pIMWkrUVBz?=
 =?utf-8?B?YjY1U3libmlPV09PSXAzM3kweE13ZWwvMHhVVHZsOGRnOUxpL1dBdkVPSWNq?=
 =?utf-8?B?ampKZkNaSEd2QmNxa3lIanFXUS8zNjdBZjVSNzBZWTByMTRjeE9ydStRamRp?=
 =?utf-8?B?TGpFVTg5S3dMdW9VL3E2aVVROXlicWlBMGcvUmM2d3E1L2Z0K0ltRUJtdk0y?=
 =?utf-8?B?OUdpaTNoclZQRHZnd3lxbk5XZTZUTm01b0FHY2xBS1lmZWc2MUM0VlJwOE40?=
 =?utf-8?B?V09RUzlPdGNFQldhMnBwaTB0Sk1yV2RXZU1UVXNQaEE0aU1hUmx5Unk0NXQ5?=
 =?utf-8?B?dEJMTGxEUmI4Y2NBbjZ0WFRERlJ6Sjl3cmdrdkxxSXNWR1I5NHhHNDMzVkxW?=
 =?utf-8?B?ZGdDZXFYb0Q0eGJFcTh6UjA5aC9vV29PanV2Yi9XMjROU1pNRmRGODhjN2gr?=
 =?utf-8?B?THdrMTE0dWdOTjFNMTE4eDJhRG50WWlZcGQ1Yjh4dUwrWDF6aEo5dnlqRnhH?=
 =?utf-8?B?eW9hcHZxb25YYjUyNUdRQjQxM09SZUp5Z1NvQjJDL3FqbnlSNmovUnBIUmc1?=
 =?utf-8?B?UXAwbU5POGZTMXRBSGlvT2RpK2VUQ3dJQk9lN3ZMeCtjQ3cwN2oxc1Z5NXJT?=
 =?utf-8?B?MzVaVVRXd2psTmFES1BWeitrYzZjWG55YU9QMGg2R0Q3cDBRMWpySStFWXVZ?=
 =?utf-8?B?cm1kUUxHTzZsc1h1M3Rudmx2cGllS3N1OEcyOUhsbnB6clpTN1FrVUZrUVZr?=
 =?utf-8?B?ZnBidURET0dQVkNlOG1ZdlIxRDdrRk5HRlNpeTZGaFdONmY1Qm5iOThBSkQx?=
 =?utf-8?B?dGpYRFlqZFFYUWRjRVdqTk9yeEtWR0Q0ekYwdGJBVXN3ZTlKWWJaNG1sWkRE?=
 =?utf-8?B?VjRja3czTGJPd1R5UE8yY1ZNRlcxdFZsV01mZXVNcmwvcTJVeHRyUUcwZ1h0?=
 =?utf-8?Q?J5FcWKrbEekD05nk=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4326d692-ddbd-446b-3cab-08da3effc710
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB6375.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2022 10:09:10.4597
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +aRf0ezsH+G1RyS9h75S6+0oosxA40EouG4qykA/UQ0qy98183p6xWrKuqD8g8EGpse2Hs5TwJPMkVGvINSSjCiZDnUQOglcpHfVtFEVzFY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4010
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-05-25 4:48 PM, Amadeusz Sławiński wrote:
> Apparently on few architectures __fls is defined incorrectly. Fix this
> by adjusting declarations to asm-generic ones.
> 
> As far as I can tell there should be no functional changes, but I don't
> have devices to test it, so it was only compile tested.
> 
> Amadeusz Sławiński (2):
>    ARC: bitops: Change __fls to return unsigned long
>    m68k: bitops: Change __fls to return and accept unsigned long
> 
>   arch/arc/include/asm/bitops.h  | 2 +-
>   arch/m68k/include/asm/bitops.h | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 

Thanks for the fixes Amadeo!

I wonder if there are more places like this to address..
Not tested but I do not see any issues with the code so:

Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>


Regards,
Czarek