Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <133bcb8b-2321-6acb-ea2d-3ab82af19dcb@gmx.de>
Date:   Fri, 27 May 2022 17:31:46 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH] parisc: fix the exit status of arch/parisc/nm
Content-Language: en-US
To:     Masahiro Yamada <masahiroy@kernel.org>,
        linux-kbuild@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org,
        "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
References: <20220527143931.2161635-1-masahiroy@kernel.org>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <20220527143931.2161635-1-masahiroy@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 5/27/22 16:39, Masahiro Yamada wrote:
> Parisc overrides 'nm' with a shell script. I was hit by a false-positive
> error of $(NM) because this script returns the exit code of grep instead
> of ${CROSS_COMPILE}nm. (grep exits with 1 if no lines were selected)
>
> I tried to fix it, but in the code review, Helge suggested to remove it
> entirely. [1]
>
> This script was added in 2003. [2]
>
> Presumably, it was a workaround for old toolchains (but even the parisc
> maintainer does not know the detail any more).
>
> Hopefully recent tools should work fine.
>
> [1]: https://lore.kernel.org/all/1c12cd26-d8aa-4498-f4c0-29478b9578fe@gm=
x.de/
> [2]: https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git=
/commit/?id=3D36eaa6e4c0e0b6950136b956b72fd08155b92ca3
>
> Suggested-by: Helge Deller <deller@gmx.de>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Acked-by: Helge Deller <deller@gmx.de>

Thank you!
Helge

> ---
>
> I want to apply this to kbuild tree with Helge's Ack
>
>  arch/parisc/Makefile | 1 -
>  arch/parisc/nm       | 6 ------
>  2 files changed, 7 deletions(-)
>  delete mode 100644 arch/parisc/nm
>
> diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
> index aca1710fd658..e38d993d87f2 100644
> --- a/arch/parisc/Makefile
> +++ b/arch/parisc/Makefile
> @@ -18,7 +18,6 @@
>  boot :=3D arch/parisc/boot
>  KBUILD_IMAGE :=3D $(boot)/bzImage
>
> -NM		=3D sh $(srctree)/arch/parisc/nm
>  CHECKFLAGS	+=3D -D__hppa__=3D1
>
>  ifdef CONFIG_64BIT
> diff --git a/arch/parisc/nm b/arch/parisc/nm
> deleted file mode 100644
> index c788308de33f..000000000000
> --- a/arch/parisc/nm
> +++ /dev/null
> @@ -1,6 +0,0 @@
> -#!/bin/sh
> -##
> -# Hack to have an nm which removes the local symbols.  We also rely
> -# on this nm being hidden out of the ordinarily executable path
> -##
> -${CROSS_COMPILE}nm $* | grep -v '.LC*[0-9]*$'