Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9baa3f34-8ef7-cee2-f396-163b8206534d@intel.com>
Date:   Fri, 27 May 2022 12:22:15 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.9.1
Subject: Re: [PATCH V2 1/2] mmc: core: Define a new vendor ops to enable
 wakeup capability
Content-Language: en-US
To:     Sarthak Garg <quic_sartgarg@quicinc.com>, ulf.hansson@linaro.org
Cc:     linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, quic_kamasali@quicinc.com,
        quic_rampraka@quicinc.com, quic_pragalla@quicinc.com,
        quic_sayalil@quicinc.com,
        =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>,
        Thorsten Scherer <t.scherer@eckelmann.de>,
        Sergey Shtylyov <s.shtylyov@omp.ru>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        lizhe <sensor1010@163.com>
References: <20220526121215.25947-1-quic_sartgarg@quicinc.com>
 <20220526121215.25947-2-quic_sartgarg@quicinc.com>
From:   Adrian Hunter <adrian.hunter@intel.com>
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki
In-Reply-To: <20220526121215.25947-2-quic_sartgarg@quicinc.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 26/05/22 15:12, Sarthak Garg wrote:
> Define a new vendor ops to let vendor initialize card as wakeup source

Did you consider using the existing ->init_card() op?

> and enable wakeup capability specially for SDIO cards which supports
> waking host from system suspend through external dedicated pins.
> 
> Signed-off-by: Sarthak Garg <quic_sartgarg@quicinc.com>
> ---
>  drivers/mmc/core/bus.c   | 3 +++
>  include/linux/mmc/host.h | 7 +++++++
>  2 files changed, 10 insertions(+)
> 
> diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c
> index 58a60afa650b..6192a52288fd 100644
> --- a/drivers/mmc/core/bus.c
> +++ b/drivers/mmc/core/bus.c
> @@ -364,6 +364,9 @@ int mmc_add_card(struct mmc_card *card)
>  #endif
>  	card->dev.of_node = mmc_of_find_child_device(card->host, 0);
>  
> +	if (card->host->ops->card_init_wakeup)
> +		card->host->ops->card_init_wakeup(card);
> +
>  	device_enable_async_suspend(&card->dev);
>  
>  	ret = device_add(&card->dev);
> diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h
> index c193c50ccd78..3bd4374a64b8 100644
> --- a/include/linux/mmc/host.h
> +++ b/include/linux/mmc/host.h
> @@ -193,6 +193,13 @@ struct mmc_host_ops {
>  
>  	/* Initialize an SD express card, mandatory for MMC_CAP2_SD_EXP. */
>  	int	(*init_sd_express)(struct mmc_host *host, struct mmc_ios *ios);
> +
> +	/*
> +	 * Optional for vendor to initialize card as wakeup source and
> +	 * enable wakeup capability specially for SDIO cards which supports
> +	 * waking host from suspend through external dedicated pins.
> +	 */
> +	void    (*card_init_wakeup)(struct mmc_card *card);
>  };
>  
>  struct mmc_cqe_ops {