Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 27 May 2022 12:45:21 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Haowen Bai <baihaowen@meizu.com>
Cc:     Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xfs: drop the useless LIST_HEAD in
 __mtd_del_partition()
Message-ID: <20220527124521.15ac865e@xps-13>
In-Reply-To: <1653645678-29049-1-git-send-email-baihaowen@meizu.com>
References: <1653645678-29049-1-git-send-email-baihaowen@meizu.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Haowen,

baihaowen@meizu.com wrote on Fri, 27 May 2022 18:01:18 +0800:

> Drop LIST_HEAD where the variable it declares is never used.
>=20
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>

The title seems wrong. A fixes tag would be appropriate.

> ---
>  drivers/mtd/mtdpart.c | 1 -
>  1 file changed, 1 deletion(-)
>=20
> diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c
> index d442fa94c872..976e9c30244e 100644
> --- a/drivers/mtd/mtdpart.c
> +++ b/drivers/mtd/mtdpart.c
> @@ -326,7 +326,6 @@ static int __mtd_del_partition(struct mtd_info *mtd)
>  static int __del_mtd_partitions(struct mtd_info *mtd)
>  {
>  	struct mtd_info *child, *next;
> -	LIST_HEAD(tmp_list);
>  	int ret, err =3D 0;
> =20
>  	list_for_each_entry_safe(child, next, &mtd->partitions, part.node) {


Thanks,
Miqu=C3=A8l