Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 27 May 2022 14:38:21 +0800
From:   Leo Yan <leo.yan@linaro.org>
To:     James Clark <james.clark@arm.com>
Cc:     German Gomez <german.gomez@arm.com>, linux-kernel@vger.kernel.org,
        linux-perf-users@vger.kernel.org, acme@kernel.org,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH] perf test arm-spe: Check if perf-record hangs when
 recording workload with forks
Message-ID: <20220527063821.GB829807@leoy-ThinkPad-X240s>
References: <20220228165655.3920-1-german.gomez@arm.com>
 <95ede14c-8dc2-d285-9f5b-8d6ee6797f00@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <95ede14c-8dc2-d285-9f5b-8d6ee6797f00@arm.com>
Precedence: bulk

On Fri, May 13, 2022 at 02:03:52PM +0100, James Clark wrote:
> 
> 
> On 28/02/2022 16:56, German Gomez wrote:
> > Add shell test to check if perf-record hangs when recording an arm_spe
> > event with forks.
> > 
> > The test FAILS if the Kernel is not patched with Commit 961c391217 ("perf:
> > Always wake the parent event").
> > 
> > Unpatched Kernel:
> > 
> >   $ perf test -v 90
> >   90: Check Arm SPE doesn't hang when there are forks
> >   --- start ---
> >   test child forked, pid 14232
> >   Recording workload with fork
> >   Log lines = 90 /tmp/__perf_test.stderr.0Nu0U
> >   Log lines after 1 second = 90 /tmp/__perf_test.stderr.0Nu0U
> >   SPE hang test: FAIL
> >   test child finished with -1
> >   ---- end ----
> >   Check Arm SPE trace data in workload with forks: FAILED!
> > 
> > Patched Kernel:
> > 
> >   $ perf test -v 90
> >   90: Check Arm SPE doesn't hang when there are forks
> >   --- start ---
> >   test child forked, pid 2930
> >   Compiling test program...
> >   Recording workload...
> >   Log lines = 478 /tmp/__perf_test.log.026AI
> >   Log lines after 1 second = 557 /tmp/__perf_test.log.026AI
> >   SPE hang test: PASS
> >   Cleaning up files...
> >   test child finished with 0
> >   ---- end ----
> >   Check Arm SPE trace data in workload with forks: Ok
> > 
> > Signed-off-by: German Gomez <german.gomez@arm.com>
> 
> Reviewed-by: James Clark <james.clark@arm.com>

Thanks for review and popping up this patch, James.  LGTM:

Reviewed-by: Leo Yan <leo.yan@linaro.org>