Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <ea51a17e00a10f3ab25d94b9a5885eb9142aa12b.1653377840.git.geert@linux-m68k.org>
 <CAMj1kXEUiuSLLcuQ-H7A4djyJF_rdr9bD4JrCP_p98Qg3K=Fow@mail.gmail.com>
In-Reply-To: <CAMj1kXEUiuSLLcuQ-H7A4djyJF_rdr9bD4JrCP_p98Qg3K=Fow@mail.gmail.com>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Sat, 28 May 2022 11:39:20 +0200
Message-ID: <CAMj1kXF8XUGrLQq+A04_nNEBQzq=8AsyXGQ-ZJoVqxFUeAoH0A@mail.gmail.com>
Subject: Re: [PATCH v2] efi: EFI_DISABLE_RUNTIME should depend on EFI
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Javier Martinez Canillas <javierm@redhat.com>,
        linux-efi <linux-efi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, 28 May 2022 at 11:24, Ard Biesheuvel <ardb@kernel.org> wrote:
>
> On Tue, 24 May 2022 at 09:37, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> >
> > The EFI_DISABLE_RUNTIME config option controls the use of Extensible
> > Firmware Interface (EFI) runtime services, which matters only if EFI
> > support is enabled.
> >
> > Hence add a dependency on EFI, to prevent asking the user about this
> > control knob when configuring a kernel without EFI support.
> >
> > Fixes: a031651ff2144a3d ("efi: Allow to enable EFI runtime services by default on RT")
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Acked-by: Javier Martinez Canillas <javierm@redhat.com>
> > ---
> > v2:
> >   - Add Acked-by,
> >   - Fix typo s/with/without/.
> > ---
> >  drivers/firmware/efi/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
>
> Can we just move this option into the menu/endmenu scope that already
> depends on EFI?
>

We can, and there are other candidates as well. So I'll drop this
patch, and send out another one that covers some other options too.

Thanks,
Ard.


> > diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
> > index 4720ba98cec312e7..ff6e7bfa8355cfc2 100644
> > --- a/drivers/firmware/efi/Kconfig
> > +++ b/drivers/firmware/efi/Kconfig
> > @@ -299,6 +299,7 @@ config EFI_CUSTOM_SSDT_OVERLAYS
> >
> >  config EFI_DISABLE_RUNTIME
> >         bool "Disable EFI runtime services support by default"
> > +       depends on EFI
> >         default y if PREEMPT_RT
> >         help
> >           Allow to disable the EFI runtime services support by default. This can
> > --
> > 2.25.1
> >