Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp2368969ioo; Sat, 28 May 2022 11:30:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxNnCykf9S37oQ5JPap5L0TJvO0BjnL59qeKqFxMabvJ6DDcG4KGX3XNnA/Kse+sSdfsO8A X-Received: by 2002:a65:6045:0:b0:399:3a5e:e25a with SMTP id a5-20020a656045000000b003993a5ee25amr40821124pgp.139.1653762618649; Sat, 28 May 2022 11:30:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653762618; cv=none; d=google.com; s=arc-20160816; b=goaksxaeMB7K/hRrks/aQwq5UnzhyCorKTMo8Dg94yT92oMwG9SwrEp0RL9SgoB3+5 PJzH57ALlJa/sw7Q6Pd+fVM+JI7LEEs1gxeyRh8QvcuJyy/1dnSdwKxDsDL+cWbMkNUd agQB4CWUXywfztNtS2WyxmJStZc/742DSCsUd4vKu7Sjm2xgzNVfkszCepLN6XFCbFjG VZWf/I5aIUYNoMUTs5pRRBSL/ZYpuEAcR1ULobCj88rL/RF9+dtGAlFbJzLeFv8mcO95 BHu6P6yTDNsR6EhOItbGby+QJlHJaGk0rKNJA6smE/HRKGQ8fQO0h1xcXRHTz2T/N+yJ BPJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=+uKoFrA1MB7Px4Hceb9HtqBEm7hxyzDunzaSFZdZ65E=; b=rxS+SmScmfBk4kg2X3S9ql6QP+sTblYWLHjWMuHwWa6t+xNW/EGWBud7p/KexIVCTy bNyxWGqDSitL93DL6kAWX3qX5EYgAlXAiDM80NT5to9HufHG9AQEEYkVD5FUH2kHfaEJ PK/lZBSuBNjKtewqc7+t9txXzFyvwEFFgttHArms0lxSVDsOQJ6iRGod8+QMbLOO29VQ 4Zuy8mbeHiDUR7vm/ooEQGX1fRVgFEBfH8X6nk/+FcPEtKixDRGsKVjkcS7qOwlMj5BZ 3mp1bcqyuC+z0h4B74+3468bY5tubTKjl71fcSpUvvYsD4hbCFZF5gHc4OuAQEO8qWUY LPaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=JpMHO7nY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id t2-20020a170902e84200b0015c16a75912si11936684plg.552.2022.05.28.11.30.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 May 2022 11:30:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=JpMHO7nY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5D7411D306; Sat, 28 May 2022 11:27:53 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354634AbiE0UpO (ORCPT + 99 others); Fri, 27 May 2022 16:45:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354621AbiE0UpL (ORCPT ); Fri, 27 May 2022 16:45:11 -0400 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47B451339EE for ; Fri, 27 May 2022 13:45:07 -0700 (PDT) Received: by mail-pj1-x1031.google.com with SMTP id c10-20020a17090a4d0a00b001e283823a00so1903368pjg.0 for ; Fri, 27 May 2022 13:45:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+uKoFrA1MB7Px4Hceb9HtqBEm7hxyzDunzaSFZdZ65E=; b=JpMHO7nYYfFDaaxxq/wzIXsc4I/Z9xgwdZE0rzhnywmrdGZcUtKA/KrIyU0IeU6GnG 6cD89RcSRO+j9Xoo1ueLijOKuYZGA2nzUwHP9WwPfga0WnX/xc0QfCNn6vNII/OoLrWD KIRjgDhUVv807X+e9rHfxUjNc4U8RMrb5BBBA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+uKoFrA1MB7Px4Hceb9HtqBEm7hxyzDunzaSFZdZ65E=; b=uQnZgbor5O6WKLfCtAQOxXZeNfVscTx3ncqj72PN20imLLAKo80ofyQOtxw+W2GtD9 0RHqksfRmMEsTqpbWov6Z5OOGN4gbo6a3OeJRz7FmLgfs11J9CaAUp2WAAjmEZj1ncNJ kESsfB4gPUE8maPzKQOsUIrVCjJqz+dLf2rHy4ExP0kmJ7Gbp6RjQgr6Dm+OrbYZ3wXl eAFIdxbndIa33zVBd4fHJi57IaaQtnsKivrjBrKDaghRtP+hxHs/9M7aQPfeWSxtAv7C +BWzxr09xU2g8BOnniKMy29lZL9rBQVwU44ZAdLqroid+dnUuS8C0GBWv0psCZA0Prbs EmvA== X-Gm-Message-State: AOAM531twJYlT4pxieLhCw3/CgO15f/abIPKmb9rtaUdsxTlqGZl89zm ctcjYwsB7GOYBxrSgIvWZE+hkA== X-Received: by 2002:a17:90b:1c8f:b0:1b8:c6dc:ca61 with SMTP id oo15-20020a17090b1c8f00b001b8c6dcca61mr10068623pjb.13.1653684306778; Fri, 27 May 2022 13:45:06 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id o1-20020a170902d4c100b0015e8d4eb20esm141656plg.88.2022.05.27.13.45.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 May 2022 13:45:06 -0700 (PDT) Date: Fri, 27 May 2022 13:45:05 -0700 From: Kees Cook To: David Howells Cc: jlayton@kernel.org, Jonathan Corbet , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , Marc Dionne , Xiubo Li , Ilya Dryomov , Steve French , William Kucharski , "Matthew Wilcox (Oracle)" , linux-doc@vger.kernel.org, v9fs-developer@lists.sourceforge.net, linux-afs@lists.infradead.org, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-fsdevek@vger.kernel.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfs: Fix gcc-12 warning by embedding vfs inode in netfs_i_context Message-ID: <202205271344.75AC356A5@keescook> References: <202205190704.1DC660E5E@keescook> <165296786831.3591209.12111293034669289733.stgit@warthog.procyon.org.uk> <3598052.1653654453@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3598052.1653654453@warthog.procyon.org.uk> X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 27, 2022 at 01:27:33PM +0100, David Howells wrote: > Hi Kees, > > Is v2 good for you? I realise I left your R-b attached to it when I posted > it, but I can remove that if you don't have time to review it. Oh! Yes, it's good. Since you kept the R-b, I didn't reply. It looks good to me. Thanks! Reviewed-by: Kees Cook -- Kees Cook