Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220526204152.831948-1-krzysztof.kozlowski@linaro.org> <CA+H2tpGipB4faYDEdJZ82kjTak5ewW_cp=3LO+JkDa=hYiqZJw@mail.gmail.com>
In-Reply-To: <CA+H2tpGipB4faYDEdJZ82kjTak5ewW_cp=3LO+JkDa=hYiqZJw@mail.gmail.com>
From:   Orson Zhai <orsonzhai@gmail.com>
Date:   Fri, 27 May 2022 14:28:24 +0800
Message-ID: <CA+H2tpECYtgJAgJbwfgmu++ZVmk+nuoRmK=fX=4pquTFSFyzhg@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: sprd: adjust whitespace around '='
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
        arm@kernel.org, soc@kernel.org, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Baolin Wang <baolin.wang7@gmail.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>,
        DTML <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, May 27, 2022 at 12:35 PM Orson Zhai <orsonzhai@gmail.com> wrote:
>
> Hi Krzysztof,
>
> On Fri, May 27, 2022 at 4:42 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
>>
>> Fix whitespace coding style: use single space instead of tabs or
>> multiple spaces around '=' sign in property assignment.  No functional
>> changes (same DTB).
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>
> Thanks for your patch.
>
> We have a plan to reconstruct the device tree of SPRD into modular form.
> sc9836 has been in status of EOL for years and I believe no one will need to run it anymore.
> We want to remove it as well.
>
> But your patch is fine.
> It could be taken in advance.
>
> Reviewed-by: Orson Zhai <orsonzhai@gmail.com>

Sorry, re-send for my getting failure...

-Orson

>
>> ---
>>
>> Output compared with dtx_diff and fdtdump.
>> ---
>>  arch/arm64/boot/dts/sprd/sc9836.dtsi  | 10 +++++-----
>>  arch/arm64/boot/dts/sprd/sc9863a.dtsi |  4 ++--
>>  arch/arm64/boot/dts/sprd/whale2.dtsi  |  2 +-
>>  3 files changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/sprd/sc9836.dtsi b/arch/arm64/boot/dts/sprd/sc9836.dtsi
>> index 231436be0e3f..8bb8a70966d2 100644
>> --- a/arch/arm64/boot/dts/sprd/sc9836.dtsi
>> +++ b/arch/arm64/boot/dts/sprd/sc9836.dtsi
>> @@ -207,11 +207,11 @@ gic: interrupt-controller@12001000 {
>>         };
>>
>>         psci {
>> -               compatible      = "arm,psci";
>> -               method          = "smc";
>> -               cpu_on          = <0xc4000003>;
>> -               cpu_off         = <0x84000002>;
>> -               cpu_suspend     = <0xc4000001>;
>> +               compatible = "arm,psci";
>> +               method = "smc";
>> +               cpu_on = <0xc4000003>;
>> +               cpu_off = <0x84000002>;
>> +               cpu_suspend = <0xc4000001>;
>>         };
>>
>>         timer {
>> diff --git a/arch/arm64/boot/dts/sprd/sc9863a.dtsi b/arch/arm64/boot/dts/sprd/sc9863a.dtsi
>> index 8cf4a6575980..22d81ace740a 100644
>> --- a/arch/arm64/boot/dts/sprd/sc9863a.dtsi
>> +++ b/arch/arm64/boot/dts/sprd/sc9863a.dtsi
>> @@ -552,7 +552,7 @@ ap-ahb {
>>                         ranges;
>>
>>                         sdio0: sdio@20300000 {
>> -                               compatible  = "sprd,sdhci-r11";
>> +                               compatible = "sprd,sdhci-r11";
>>                                 reg = <0 0x20300000 0 0x1000>;
>>                                 interrupts = <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>;
>>
>> @@ -568,7 +568,7 @@ sdio0: sdio@20300000 {
>>                         };
>>
>>                         sdio3: sdio@20600000 {
>> -                               compatible  = "sprd,sdhci-r11";
>> +                               compatible = "sprd,sdhci-r11";
>>                                 reg = <0 0x20600000 0 0x1000>;
>>                                 interrupts = <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>;
>>
>> diff --git a/arch/arm64/boot/dts/sprd/whale2.dtsi b/arch/arm64/boot/dts/sprd/whale2.dtsi
>> index 79b9591c37aa..957b2658e1fb 100644
>> --- a/arch/arm64/boot/dts/sprd/whale2.dtsi
>> +++ b/arch/arm64/boot/dts/sprd/whale2.dtsi
>> @@ -132,7 +132,7 @@ ap_dma: dma-controller@20100000 {
>>                         };
>>
>>                         sdio3: sdio@50430000 {
>> -                               compatible  = "sprd,sdhci-r11";
>> +                               compatible = "sprd,sdhci-r11";
>>                                 reg = <0 0x50430000 0 0x1000>;
>>                                 interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>;
>>
>> --
>> 2.34.1
>>