Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <7c22e193-2a7b-2537-feff-c4656c022f31@linaro.org>
Date:   Fri, 27 May 2022 12:56:57 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH v2 -next] drm/display: Fix build error without CONFIG_OF
Content-Language: en-GB
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     YueHaibing <yuehaibing@huawei.com>, airlied@linux.ie,
        daniel@ffwll.ch, tzimmermann@suse.de, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org
References: <20220506123246.21788-1-yuehaibing@huawei.com>
 <CACRpkdZUwfVNZyS6RgcupJ+TRUZVM+1_3ABj_-f_3+v+wNE6mg@mail.gmail.com>
 <CACRpkdaKrk+cj9Yvpe3kmR1iJFczi-yckHiKeLGu9F=hRFiU9w@mail.gmail.com>
 <CAA8EJpq7_V7mZbN+G5fZdK0a4kTcxROAd_bGJtQ5mhzdYr6pNQ@mail.gmail.com>
 <CACRpkdYATkP2ONCxHq6+XsWM8949tXxd5r=OKM36dgwWp3Sxgg@mail.gmail.com>
From:   Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
In-Reply-To: <CACRpkdYATkP2ONCxHq6+XsWM8949tXxd5r=OKM36dgwWp3Sxgg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 26/05/2022 23:08, Linus Walleij wrote:
> On Wed, May 25, 2022 at 3:36 PM Dmitry Baryshkov
> <dmitry.baryshkov@linaro.org> wrote:
>> On Mon, 23 May 2022 at 15:55, Linus Walleij <linus.walleij@linaro.org> wrote:
> 
>>> Nope, failed:
>>>
>>> $ dim push-branch drm-misc-next
>>> dim: ac890b9eeb9b ("drm/display: Fix build error without CONFIG_OF"):
>>> Fixes: SHA1 in not pointing at an ancestor:
>>> dim:     f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support")
>>> dim: ERROR: issues in commits detected, aborting
>>>
>>> I don't know what to do with this, sorry. The other committers are maybe better
>>> with this kind of situations. I think it is designed to stop me from
>>> shooting myself
>>> in the foot.
>>
>> Linus, can we get an ack from you (or anybody else from DRM core) to
>> merge it through drm/msm tree?
> 
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> 
>> After a second thought, I think the patch contains wrong Fixes tag. It
>> should be:
>>
>> Fixes: 1e0f66420b13 ("drm/display: Introduce a DRM display-helper module")
>>
>> With that in place would we be able to merge it through drm-misc? Does
>> it needs to be resubmitted?
> 
> But it doesn't apply to drm-misc... that's my problem :/

I think it didn't apply because of the Fixes from msm-next.
If we change that to the mentioned commit (1e0f66420b13), then you 
should be able to push it.


-- 
With best wishes
Dmitry