Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <d115fd35-55fd-598f-1fd7-0e3d16da4301@oracle.com>
Date:   Fri, 27 May 2022 10:56:43 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.9.1
Subject: Re: [PATCH] drivers: scsi: Directly use ida_alloc()/free()
Content-Language: en-US
To:     keliu <liuke94@huawei.com>, jejb@linux.ibm.com,
        martin.petersen@oracle.com, lduncan@suse.com, cleech@redhat.com,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        open-iscsi@googlegroups.com
References: <20220527083049.2552526-1-liuke94@huawei.com>
From:   michael.christie@oracle.com
In-Reply-To: <20220527083049.2552526-1-liuke94@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eFhPdVhvYW9ZN3doMkd3VHVLejN5d2VmYmFoMmMzK0pzVGxDRXNIZkpQeEw0?=
 =?utf-8?B?THc2MmxZeVJwRkdYVlArM1R1cUkxcUhLMktMNWJkL3BHYUlEd05VdTRiQnRE?=
 =?utf-8?B?Y0ZzdXpWMS92M2pvdldtanU1VGlSdGplNkE0clZJRm5IYWZKUmxCOHdrTnVx?=
 =?utf-8?B?L0NBbFZuNHNVNmtPS1pweElvamJXVloveGRlRjlvUHNQclc3NmY5dWFVZXZy?=
 =?utf-8?B?aFVOMS9VZStlY2hlUUw1aHp6Y1l2U1VGUXlPeUI1QlVxMzVSS3ZmNkhkTmRh?=
 =?utf-8?B?N28rVlQrWVlxUDBOdGJjYnQ4L2toU0Z1T2Y3TWh3NktVOGI4MEhiZCt2RHRq?=
 =?utf-8?B?MGlFblBXb3NuWXkyaEZNNTdXWjZrb0psZEV1YmZzMy9id2NiWVVYR2haSlBF?=
 =?utf-8?B?eVZqN2FULy9JNWRmKzlRZkZlQkJ0YjNNM2I0ZURKaXUwdW90VnRLZEE1WTBU?=
 =?utf-8?B?aElVN2NoNWl6TTBveHV5V0laUlQ4OGlMdG92Q1QzYzR2WVpCWnFtbncySFhB?=
 =?utf-8?B?VTVGZFFoWUI1cGhTS1p2UXdqcEErSGYwWG9wQWxGbVRFdXNkMmVFY1RBWnQr?=
 =?utf-8?B?YnJab2U1VjkyL1lXODdob2RwODZmM290UGJkZ2xsNitQUy8vZ3VUcy80YlJi?=
 =?utf-8?B?OElaUkxnQllrRGtSc1pVcmFtQlhISHYxUnY5c1h1L0c5bG5PRHp3ZGowZ2NZ?=
 =?utf-8?B?UkNwQ1puNGg5MkJFY2Y1ZWRxOWd1cHFMaW5FekxTTjV0RUZvY1FYK0dXSDUy?=
 =?utf-8?B?UmpnZE05d1hCR0w3Wm12Z29lVUZYUHlhSGpLbk50UXFXWHFFRHN0WUlpbHNL?=
 =?utf-8?B?WGtlZko0eXdoTjVqMWIyRDZyditJTlg0VEVBWmpJUHJZNEtGQmNDWENKdExY?=
 =?utf-8?B?M1pLMkJZRUU4a1krZEhFdHArd0RMd1J3SWVBbWxMU2ZlMnJqSEEyZFBLV1Fu?=
 =?utf-8?B?YkFtZGY1YzZldVEvS2RNYm5pUHp1WWl4K21ndTFjUGdhMjhuYnNEZis2OVJr?=
 =?utf-8?B?Q3RlQUk4cTNGbjdUWkhhR21tcmZIamxMSDJSMHBFWG9qaDVmWXJHc0ZXRDU4?=
 =?utf-8?B?VnBPWmtWS3pTR2JpaHg4c3c3ZFRuK3VWSnR1L1JkYWExdzlpOWhqWFFNcnBV?=
 =?utf-8?B?eUdIMHMxb1hOWTh3VW5TWGU1ZjlyejVIUEd2ejM2SmNkM3Q2c0VaaHUzcWNC?=
 =?utf-8?B?dGphVjN0R1ZBTzMrMFo4VFdpSFRsaitVOHlRcTVRd1JrZmR5dXZRRC91RXhi?=
 =?utf-8?B?VklwSmhIdW1Qc0l0SXJOb0NDYUdJQ1NtM0NuenVhdUhuN1RHMzlydkp5TkRV?=
 =?utf-8?B?QmZtWE4yU253MjZGU1BKT2FqSURVcFJvQU43aERrdmNEbG1iMzdlcTB0V1cy?=
 =?utf-8?B?MFdqT1IyU3JvS2gyWVcxVDJPck1OTllwWEVYYWEyeEY3UWFTOEE5MTEzb01m?=
 =?utf-8?B?ZlBkOHYraHZ3NVpRS2xCdTVPRUlQZFhQaXVvSXlJT0Z1ME0wT013QXlrNGxx?=
 =?utf-8?B?WUlURUFFdWQ1OGxFRjZTMVppK1JCUEw4SWNuTS9wbVQrYzBLLzJQa3FuR3pE?=
 =?utf-8?B?UlJjVXAyNzcvVTgvaVhxbDhmQzhqVjRUdkIrUGJYVW9tU01TczZVbXVwOWxR?=
 =?utf-8?B?bjF1NzZHNklBTlFQYVlhdCsvMXBwVEsvWUhOMVhnT0I1eGdsZHBvV3E1V09J?=
 =?utf-8?B?bmlFc0IyNW9xV0NUck5NcWFrSDBtOUcrSmNmbDBwd2VpRlAyalArWmZIRmVI?=
 =?utf-8?B?UVBEOGFDNW5aMFdQdlBYcmlxM2gwL1o2Unc3VS9PUHcwRDU5UlhuWUFWakRy?=
 =?utf-8?B?bU9IS3hlOHRVTlU3enJUVU9IUndpRDJBbmRpVms4UXE4SHlGQWNVS3hZOWc5?=
 =?utf-8?B?ZldROFozdXNYNHZtQ0hCZURDT3FZdG9RcjBMc3NhSnU3OTNKMEZlOTNqODl6?=
 =?utf-8?B?RTgvNzNlQzZpTTJqYWVZbkZMR3Z2VzV4Q1FMN3Z6alNPUUFjeFJEZnFSRVhl?=
 =?utf-8?B?cmJzclNxUnRvTVc5OXlXQ2cwNDMxNnI0M0FUWTBEOXJyalFZMkdoRjIvcXoz?=
 =?utf-8?B?eGgzb0JxREVIUUN1TEZpN1dhRXJkSmlmeXA2UHc4QXJJallBbmFnN2twYUQr?=
 =?utf-8?B?ZTBxK1dvVS83YjhNM0lhZUs3MjRzazZCNEpvbUY4Z0RUd0k1eWliRXNadzhp?=
 =?utf-8?B?TXArT0taWVRVdmhxWDlqTWVqSTJJT25vUWFuaUc3eVg4QkVEb3M1V2dWckE0?=
 =?utf-8?B?RDVwYlZLRnpCVTRlSzNZaHovU3laaDFPcmxjclNvTmVtR2YrNmU4Z3hvalJL?=
 =?utf-8?B?dTR6VXdNb05UU1ZRUkFsVmhBbnVmaXRNM3lsMHNRZEZjbmVOejZHSFRFNVNm?=
 =?utf-8?Q?YrDeJXOd3QgaUCcw=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 82c09266-54ad-4376-558c-08da3ff98032
X-MS-Exchange-CrossTenant-AuthSource: CY4PR10MB1463.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2022 15:56:45.8722
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uZpo70Xwz2b+ELVcVAuz60TtCB51Aj30QnBAa5oNUOqpLlsDiA4wyhrjxrsWfBT4ZW+NAM4QnKOFocEhZf+SYpl8ME63omoa5js+mSCpAdc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB5506
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.874
 definitions=2022-05-27_04:2022-05-27,2022-05-27 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0
 malwarescore=0 phishscore=0 mlxlogscore=863 adultscore=0 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2205270077
X-Proofpoint-ORIG-GUID: 9EtN7duY85g23BPGpvM4iB8VzOHKGEQu
X-Proofpoint-GUID: 9EtN7duY85g23BPGpvM4iB8VzOHKGEQu
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/27/22 3:30 AM, keliu wrote:
> Use ida_alloc()/ida_free() instead of deprecated
> ida_simple_get()/ida_simple_remove() .
> 
> Signed-off-by: keliu <liuke94@huawei.com>
> ---
>  drivers/scsi/hosts.c                | 4 ++--
>  drivers/scsi/scsi_transport_iscsi.c | 6 +++---
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 

Reviewed-by: Mike Christie <michael.christie@oracle.com>