Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp2381985ioo; Sat, 28 May 2022 11:54:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyhf6Gp1/TLgRIYajX6qq3PWpIYw0gCp5iuXi3IOgUGrAm5zcc4lcSZ/0P7q3VdApOYzmkD X-Received: by 2002:a65:5688:0:b0:3c2:1015:988e with SMTP id v8-20020a655688000000b003c21015988emr42252985pgs.280.1653764053727; Sat, 28 May 2022 11:54:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653764053; cv=none; d=google.com; s=arc-20160816; b=u2CwtWlUZKQ0U7BcmQgR4DxvV5dk5tWhBjRhnP0xAPW/qcLRFA/gNKDRzWoB+Mw1Py ERd0CtOfQrzKMvWMPMtH+eY0241R12taQYsoQfafYtyTn6WYTvGI7GF34E+wJaU695c/ 7O6u81XsX7K4YTeKUxvvp8fWEg8cDiAdFhlG/6BubEazP4JT8deyScXY6iCB15xj0jtM G2MpiQpuPPEcHo0sd1wfk5gOe9gsuu0PNq45mTesRDh4YrDkb+zotwtWvYEbKdGsdY2y rdxreQ/xBAN4Mzw3Gn1f1KfYgO7tstjeg4A0LvTc3IiDK3g6DC8CDKmE7YO/km9tgayG 1SDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=FHMg2tAJOCenEiVm0R3x4NJY3ZvV5XmmBxrfAtuHiRM=; b=TD9TaUA6ox6TWHzeGTgqfGJv4YQq3dg6awtbjrcIhpdBHKFBzDfejoM0tI1cGh+Fdk Mb1ZOpC1V9zwOBKALUZPvkbQEZhjykYYiKuj3R7d3oEo22CsHmZe9CWrnMsJk96m+9Mj QYH3xLKCfzq1uCEpjMtTHK21zegYnM2FZQF2h7gTGb3m4OhodnKBuA/jZJP8LHXDiasj R1IYcwEv7dwL3//n6E2TX7T690RTNNCnng2XrscpGGJsGAUbHRo9Jtg43LNUWbPoK0ql lNwBHJ0cel7tvmJskA7RDM121RAPN2ouYrmTnGBcBETJlpVp1qCgKVZka1ppIY1EaTPK SzPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=KnBx9YtN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id y30-20020a056a001c9e00b0050d6ea9b033si8349739pfw.225.2022.05.28.11.54.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 May 2022 11:54:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=KnBx9YtN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C325334655; Sat, 28 May 2022 11:40:44 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346681AbiEZISX (ORCPT + 99 others); Thu, 26 May 2022 04:18:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346686AbiEZISL (ORCPT ); Thu, 26 May 2022 04:18:11 -0400 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6955148305 for ; Thu, 26 May 2022 01:18:04 -0700 (PDT) Received: by mail-pf1-x42d.google.com with SMTP id y189so1099113pfy.10 for ; Thu, 26 May 2022 01:18:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FHMg2tAJOCenEiVm0R3x4NJY3ZvV5XmmBxrfAtuHiRM=; b=KnBx9YtN4b+GHS/KrRRe1SpvKu6kRXIFzBpZd7W9JnOP9J8tVct8iNortVjqqF14aA 7Y7r5AcJR6yBjtzcjVkTOsdqQHuPcA64ml6RkKoanCxSAnp+OL7/goCls8BaRmHAnXy6 5say0/yA7Q9/ccwhzw8oQP9Kyeiv4TnPFeSIrn6TtI9cF3ZyHFP5sKzx56q0h5NzjFh2 2KTAVj7P2agyaO4zzY30snaN0dFpM/zUBo5uxyWcNrFiXn7G4dLNeQ6xVj+mq3gl1DW4 GgGiSn+DDC0eJDqPITF/TY4ucOzgVACUNMoQxJhXhqICIOkjsNGh0UKGmmaHsBZX3ETe ZsyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FHMg2tAJOCenEiVm0R3x4NJY3ZvV5XmmBxrfAtuHiRM=; b=tE0rn9bkx7YGxLSsTKY5iXUDleHzT4SECQbbdYv8MCtohs7PCwCs7yxx+fk9E/7tyo /CjGYhDNxgUrWRT0j6RQJB8DZikkrNTmI5epXdUcmzKtrAnk8pVOX+44KxWOqi0SqNhi fq7Z5ludT5z1ZedcWZD6G42xODkd2L++kFHH+42AxSt5W58TULaUiPA2iv5IXcaWiYuS PbY555kOxGSGuq5JgRZH9G89tEB7oXowpiYi9wUEwdcf7gradXCU2FbzFpqgGl+yImbu +gG+S2uyGr3cBJfjY1pqDerY2YVkPjLONB4MXYRi8M0yuNqc6cw8YrgGUax26VsE57yI 8eRQ== X-Gm-Message-State: AOAM532xSw+fa+ax5v+6XB3ujavy0MBol/ynHmjCr7J8/ibQWhyAjDUn BHEqVhbky8RdEJDoQDk7UgM= X-Received: by 2002:a65:5188:0:b0:3fa:6081:7393 with SMTP id h8-20020a655188000000b003fa60817393mr15297881pgq.72.1653553083916; Thu, 26 May 2022 01:18:03 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id u2-20020a17090ae00200b001dcf9fe5cddsm827824pjy.38.2022.05.26.01.18.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 May 2022 01:18:03 -0700 (PDT) From: Miaoqian Lin To: Linus Walleij , Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] ARM: integrator: Fix refcount leak in intcp_init_of Date: Thu, 26 May 2022 12:17:56 +0400 Message-Id: <20220526081756.32998-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,SUSPICIOUS_RECIPS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_find_matching_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: df36680f1a71 ("ARM: integrator: core module registers from compatible strings") Signed-off-by: Miaoqian Lin --- arch/arm/mach-integrator/integrator_cp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-integrator/integrator_cp.c b/arch/arm/mach-integrator/integrator_cp.c index b7eb4038798b..bb301ca8c7e1 100644 --- a/arch/arm/mach-integrator/integrator_cp.c +++ b/arch/arm/mach-integrator/integrator_cp.c @@ -126,6 +126,7 @@ static void __init intcp_init_of(void) return; intcp_con_base = of_iomap(cpcon, 0); + of_node_put(cpcon); if (!intcp_con_base) return; -- 2.25.1