Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934071AbXEQFD6 (ORCPT ); Thu, 17 May 2007 01:03:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760034AbXEQFDs (ORCPT ); Thu, 17 May 2007 01:03:48 -0400 Received: from mx2.suse.de ([195.135.220.15]:50005 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759200AbXEQFDq (ORCPT ); Thu, 17 May 2007 01:03:46 -0400 From: Neil Brown To: david@lang.hm Date: Thu, 17 May 2007 15:03:31 +1000 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17995.57891.56738.592100@notabene.brown> Cc: Jeff Zheng , Michal Piotrowski , Ingo Molnar , linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: RE: Software raid0 will crash the file-system, when each disk is 5TB In-Reply-To: message from david@lang.hm on Wednesday May 16 References: <659F626D666070439A4A5965CD6EBF406836C6@gazelle.ad.endace.com> <6bffcb0e0705151629j78920ca2r9337dccdfc1bb6a9@mail.gmail.com> <17994.19043.771733.453896@notabene.brown> <659F626D666070439A4A5965CD6EBF406B31C5@gazelle.ad.endace.com> <17995.42562.870806.396617@notabene.brown> <659F626D666070439A4A5965CD6EBF406B33ED@gazelle.ad.endace.com> <17995.49602.427417.500049@notabene.brown> X-Mailer: VM 7.19 under Emacs 21.4.1 X-face: [Gw_3E*Gng}4rRrKRYotwlE?.2|**#s9D On Thu, 17 May 2007, Neil Brown wrote: > > > On Thursday May 17, Jeff.Zheng@endace.com wrote: > >> > >>> The only difference of any significance between the working > >>> and non-working configurations is that in the non-working, > >>> the component devices are larger than 2Gig, and hence have > >>> sector offsets greater than 32 bits. > >> > >> Do u mean 2T here?, but in both configuartion, the component devices are > >> larger than 2T (2.25T&5.5T). > > > > Yes, I meant 2T, and yes, the components are always over 2T. > > 2T decimal or 2T binary? > Either. The smallest as actually 2.75T (typo above). Precisely it was 2929641472 kilobytes or 5859282944 sectors or 0x15D3D9000 sectors. So it is over 32bits already... Uhm, I just noticed something. 'chunk' is unsigned long, and when it gets shifted up, we might lose bits. That could still happen with the 4*2.75T arrangement, but is much more likely in the 2*5.5T arrangement. Jeff, can you try this patch? Thanks. NeilBrown Signed-off-by: Neil Brown ### Diffstat output ./drivers/md/raid0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff .prev/drivers/md/raid0.c ./drivers/md/raid0.c --- .prev/drivers/md/raid0.c 2007-05-17 10:33:30.000000000 +1000 +++ ./drivers/md/raid0.c 2007-05-17 15:02:15.000000000 +1000 @@ -475,7 +475,7 @@ static int raid0_make_request (request_q x = block >> chunksize_bits; tmp_dev = zone->dev[sector_div(x, zone->nb_dev)]; } - rsect = (((chunk << chunksize_bits) + zone->dev_offset)<<1) + rsect = ((((sector_t)chunk << chunksize_bits) + zone->dev_offset)<<1) + sect_in_chunk; bio->bi_bdev = tmp_dev->bdev; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/