Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Feedback-ID: i51094778:Fastmail
User-Agent: Cyrus-JMAP/3.7.0-alpha0-591-gfe6c3a2700-fm-20220427.001-gfe6c3a27
Mime-Version: 1.0
Message-Id: <a3636e0e-a804-4701-9240-225a3131b16a@www.fastmail.com>
In-Reply-To: <20220526014107.2871787-1-robh@kernel.org>
References: <20220526014107.2871787-1-robh@kernel.org>
Date:   Thu, 26 May 2022 15:48:15 +0200
From:   "Sven Peter" <sven@svenpeter.dev>
To:     "Rob Herring" <robh@kernel.org>,
        "Hector Martin" <marcan@marcan.st>,
        "Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
        "Bjorn Helgaas" <bhelgaas@google.com>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
        "Mark Kettenis" <kettenis@openbsd.org>
Cc:     linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: PCI: apple: Add missing 'power-domains' property
Content-Type: text/plain
Precedence: bulk

Hi,


On Thu, May 26, 2022, at 03:41, Rob Herring wrote:
> The 'unevaluatedProperties' schema checks is not fully working and doesn't
> catch some cases where there's a $ref to another schema. A fix is pending,
> but results in new warnings in examples.
>
> The Apple PCIe host has 3 power domains at least according to the example.
> Add the 'power-domains' property to the schema.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Ideally, we'd define what each power domain is, but I don't know what
> they are.
> ---

I think the example is just wrong (or outdated) and we only need a single
power-domain for pcie.

The hierarchy is ps_pcie_ref -> ps_apcie -> ps_apcie_gp and the pcie
node then only depends on ps_apcie_gp.


Sven