Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Thu, 26 May 2022 22:44:53 +0800
From:   Leo Yan <leo.yan@linaro.org>
To:     Joe Mario <jmario@redhat.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Ali Saidi <alisaidi@amazon.com>, linux-kernel@vger.kernel.org,
        linux-perf-users@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, german.gomez@arm.com,
        benh@kernel.crashing.org, Nick.Forrington@arm.com,
        alexander.shishkin@linux.intel.com, andrew.kilroy@arm.com,
        james.clark@arm.com, john.garry@huawei.com,
        Jiri Olsa <jolsa@kernel.org>, kjain@linux.ibm.com,
        lihuafei1@huawei.com, mark.rutland@arm.com,
        mathieu.poirier@linaro.org, mingo@redhat.com, namhyung@kernel.org,
        peterz@infradead.org, will@kernel.org
Subject: Re: [PATCH v8 0/4] perf: arm-spe: Decode SPE source and use for perf
 c2c
Message-ID: <20220526144453.GC795802@leoy-ThinkPad-X240s>
References: <20220517020326.18580-1-alisaidi@amazon.com>
 <YoQRg1r7HuwiO3bZ@kernel.org>
 <20220518041630.GD402837@leoy-ThinkPad-X240s>
 <32e5a3b7-9294-bbd5-0ae4-b5c04eb4e0e6@redhat.com>
 <20220522061533.GA715382@leoy-ThinkPad-X240s>
 <7bf021df-2755-6937-629f-b3ed9281804d@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7bf021df-2755-6937-629f-b3ed9281804d@redhat.com>
Precedence: bulk

Hi Joe,

On Mon, May 23, 2022 at 01:24:32PM -0400, Joe Mario wrote:

[...]

> Hi Leo:
> I figured out why my output was different than yours.
> 
> I did not have the slang-devel rpm installed on the host system.  
> 
> In my original perf build, I missed the this output in the build log:
>  > slang not found, disables TUI support. Please install slang-devel, libslang-dev or libslang2-dev
> 
> Once I installed slang-devel, rebuilt perf, and then reran my test, the pareto output looked fine.
> 
> When the TUI support is disabled, it shouldn't corrupt the resulting stdio output.  I don't believe this has anything to do with your commits.  

Thanks for taking time to hunt this issue.  I checked the code and
sent out a patch to fix the stdio interface if slang lib is not
installed.  Please see the patch:

https://lore.kernel.org/lkml/20220526143917.607928-1-leo.yan@linaro.org/T/#u

> Last, it looks like you should update the help text for the display flag options to reflect your new peer option.
> Currently it says:
>    -d, --display <Switch HITM output type>
>                           lcl,rmt
> 
> But since you added the "peer" display, shouldn't the output for that help text state:
>    -d, --display <Switch HITM output type>
>                           lcl,rmt,peer

Yeah, will fix.

Very appreciate for your detailed testing and suggestions.

Leo