Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Sat, 28 May 2022 18:45:47 +0800
From:   Xu Yilun <yilun.xu@intel.com>
To:     Basheer Ahmed Muddebihal 
        <basheer.ahmed.muddebihal@linux.intel.com>
Cc:     hao.wu@intel.com, trix@redhat.com, mdf@kernel.org,
        linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
        matthew.gerlach@linux.intel.com, marpagan@redhat.com,
        tianfei.zhang@intel.com
Subject: Re: [PATCH 1/3] fpga: dfl: Fix kernel-doc warning in dfl.h for
 revision
Message-ID: <20220528104547.GA178479@yilunxu-OptiPlex-7050>
References: <20220519221249.858873-1-basheer.ahmed.muddebihal@linux.intel.com>
 <20220519221249.858873-2-basheer.ahmed.muddebihal@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220519221249.858873-2-basheer.ahmed.muddebihal@linux.intel.com>
Precedence: bulk

On Thu, May 19, 2022 at 03:12:47PM -0700, Basheer Ahmed Muddebihal wrote:
> Fixed the following warning:

Please help specify which tool reports this issue here. Is it lkp?

> drivers/fpga/dfl.h:255: warning: Function parameter or member 'revision' not described in 'dfl_feature'
> 

Please add the 'Fixes' tag here.
Please also add the 'Reported-by' tag here.

> Signed-off-by: Basheer Ahmed Muddebihal <basheer.ahmed.muddebihal@linux.intel.com>
> ---
>  drivers/fpga/dfl.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/fpga/dfl.h b/drivers/fpga/dfl.h
> index 06cfcd5e84bb..766429e618f6 100644
> --- a/drivers/fpga/dfl.h
> +++ b/drivers/fpga/dfl.h
> @@ -231,6 +231,7 @@ struct dfl_feature_irq_ctx {
>   *
>   * @dev: ptr to pdev of the feature device which has the sub feature.
>   * @id: sub feature id.
> + * @revision: sub feature revision.
>   * @resource_index: each sub feature has one mmio resource for its registers.
>   *		    this index is used to find its mmio resource from the
>   *		    feature dev (platform device)'s resources.
> -- 
> 2.34.1