Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp2407191ioo; Sat, 28 May 2022 12:38:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxaD5XnNjjac5CfasrCLFuXqWWHQ/cgeHWhMeH1PDstA2U4mGpPfmeSjLN9gKt7SZpUFAAR X-Received: by 2002:a17:903:22c4:b0:163:6700:d27b with SMTP id y4-20020a17090322c400b001636700d27bmr16927002plg.37.1653766701873; Sat, 28 May 2022 12:38:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653766701; cv=none; d=google.com; s=arc-20160816; b=cmjbOOADdwWTXQXZNtzaBR3mrtbKSvWGcP6QRCymVc3hl0oKwOg+lwW0utIsyyF8U3 Be2opeW7kVreT3VwKtRMUjjU6HOJHjHCuJq2yBZKG1bV3hT0TfjfzWFzevYDtbHeUpm/ +E0z5eDjn+54ppxsm4G9t6SHEFPL9SHkcDJDL264d+qOhJXXgzA3KNUN9Bbqki29uLNQ bla96TuHmjtWeebr9b5iEEY0U8bBwg47NTZZ1r1xCn18PuFT8He7iyw6WmHF+mQ3PuLz Bvpz44WUd5np4kGrBRn88WvLWLGszR+5skN9R9u1eDu+TeDl+EtBlbgDT5rSIV1BR2Qu Pvyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=1aS94pv7M+2mpNrbIuhOKOs56VtcAuqv2W2MQSEudGw=; b=UkoKETcXdheF6oaU5JONBlHjP5lA3rAx3R/vB+2HS2UdYXS6WRa65koaTwFwmeypae Z3imPVmZs9NxsB/aM58HS8tFff3e+YhSU3yrBoe4DCAhjgelwrXCyp/Y4jEzOw48oVY2 15d9Iv6BknUKmw4j3NU18sZeOCR+tzk072cBwOWRAR3Sjlv65Vq7V5l7o7w6JomFqrAK k+3VU4NA+Y/thyq1gP2zpjOK1zJ6tJt72yrBhzkbjdSDoRa8+S47e4S3eVZMzRBWXR/k pAQ/IB2DfghH5cKby92zbdD13tmRCcaXnyCXGpu4xLNUUrOB7i80RAfHcSooAWj4WCK1 z2IQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=GmOpTbUz; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id d8-20020a056a0024c800b0050d690a7272si10209322pfv.57.2022.05.28.12.38.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 May 2022 12:38:21 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=GmOpTbUz; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7C4C95D5DE; Sat, 28 May 2022 12:03:12 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352886AbiE0N7R (ORCPT + 99 others); Fri, 27 May 2022 09:59:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236013AbiE0N7P (ORCPT ); Fri, 27 May 2022 09:59:15 -0400 Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 280C7167CD; Fri, 27 May 2022 06:59:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1653659954; x=1685195954; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=1aS94pv7M+2mpNrbIuhOKOs56VtcAuqv2W2MQSEudGw=; b=GmOpTbUzPz+oBh7f4j0b+BN0i735TPOn7DlHonLgtuVbf7nL4WtMTpgR Nd+KPi2+lkg9eGNopM01ntifyGFq78kiPCJperPiq7rNzaRMxqGFoZUKq GMlAcsAleCkVEcbzYF9xDYiReA00qZqmtC/K6Ytnx/kMxk+WVhXQnOAhF I=; Received: from unknown (HELO ironmsg03-sd.qualcomm.com) ([10.53.140.143]) by alexa-out-sd-02.qualcomm.com with ESMTP; 27 May 2022 06:59:13 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg03-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2022 06:59:13 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Fri, 27 May 2022 06:59:12 -0700 Received: from [10.216.26.43] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Fri, 27 May 2022 06:59:06 -0700 Message-ID: <0ebf352c-1613-aea5-16d9-40ba57d7765f@quicinc.com> Date: Fri, 27 May 2022 19:29:03 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH V7 0/4] mmc: add error statistics for eMMC and SD card Content-Language: en-US To: Adrian Hunter , , , , , , , , CC: , , , , , , , References: <1653481701-19642-1-git-send-email-quic_c_sbhanu@quicinc.com> <3c56166a-772a-4fbc-8e3a-5ec669fd8b5d@intel.com> From: "Sajida Bhanu (Temp)" In-Reply-To: <3c56166a-772a-4fbc-8e3a-5ec669fd8b5d@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/27/2022 3:15 PM, Adrian Hunter wrote: > On 25/05/22 15:28, Shaik Sajida Bhanu wrote: >> Changes since V6: >> - Rebased on Ulf's(Ulf Hansson) next branch as suggested by >> Adrain Hunter. > I think maybe you re-based on the "master" branch not the "next" branch, please check Sure got it Thank you.. will re-base on next branch and post > >> - Replaced debugfs_create_file() with debugfs_create_file_unsafe() >> as suggested by Adrain Hunter. >> - "[V6,5/5] mmc: cqhci: Capture eMMC and SD card errors" not included >> in this Patch series as we don't have cqhci changes on Ulf's(Ulf Hansson) >> next branch. > cqhci is in the "next" branch, please check Sure Thank you > >> Changes since V5: >> - Considered all error stats enums to set error state. >> - Added missed tuning error related code changes which was >> missed in patch set V5 as Adrain Hunter pointed. >> - Replaced DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE >> as suggested by Adrain Hunter. >> >> Changes since V4: >> - Defined new macro to increment err_stats members when error occurred >> as suggested by Adrain Hunter. >> - Called err_stats members increment function after printing the error >> as suggested by Adrain Hunter. >> - Considered INDEX and END_BIT errors same as CRC errors as suggested >> by Adrain Hunter. >> - Removed Null check for host in debug fs functions and Reordered >> err_stats declarationas suggested by Adrain Hunter. >> - Removed err_state variable stuff and updated err_state debug fs entry >> based on the err_stats members state as suggested by Adrain Hunter. >> >> Changes since V3: >> - Dropped error stats feature flag as suggested by Adrain Hunter. >> - Separated error state related changes in separate patches as >> suggested by Adrain Hunter. >> [PATCH V4 4/7] : error state debug fs >> [PATCH V4 5/7] : error state enable function >> [PATCH V4 6/7] : error state enable in error case >> - Note: we are enabling error state before calling sdhci_dumpregs >> we couldn't add the err state in error stats array as err state >> is not error type. >> - Corrected Signed-off-by order as suggested by Bjron Andersson. >> - Moved error state enable code from sdhci_dumpregs to error >> conditions as suggested by Adrain Hunter >> >> Changes since V2: >> - Removed userspace error stats clear debug fs entry as suggested >> by Adrain Hunter. >> - Split patch into 4 patches >> [PATCH V3 1/4] : sdhci driver >> [PATCH V3 2/4] : debug fs entries >> [PATCH V3 3/4] : core driver >> [PATCH V3 4/4] : cqhci driver >> - Used for loop to print error messages instead of using printf >> statements for all error messages as suggested by Adrain Hunter. >> - Introduced one flag to enable error stats feature, if any other >> client wants to use this feature, they need to enable that flag. >> - Moved reset command timeout error statement to card init flow >> as suggested by Adrain Hunter. >> >> Changes since V1: >> - Removed sysfs entry for eMMC and SD card error statistics and added >> debugfs entry as suggested by Adrian Hunter and Ulf Hansson. >> >> Shaik Sajida Bhanu (4): >> mmc: core: Capture eMMC and SD card errors >> mmc: sdhci: Capture eMMC and SD card errors >> mmc: debugfs: Add debug fs entry for mmc driver >> mmc: debugfs: Add debug fs error state entry for mmc driver >> >> drivers/mmc/core/core.c | 11 +++++-- >> drivers/mmc/core/debugfs.c | 81 ++++++++++++++++++++++++++++++++++++++++++++++ >> drivers/mmc/host/sdhci.c | 33 +++++++++++++++---- >> drivers/mmc/host/sdhci.h | 3 ++ >> include/linux/mmc/host.h | 26 +++++++++++++++ >> include/linux/mmc/mmc.h | 6 ++++ >> 6 files changed, 151 insertions(+), 9 deletions(-) >>