Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp2414252ioo; Sat, 28 May 2022 12:51:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzbPCtu3nL61GT9i3cUoHSqRwJkW+4wpSfvCfY/Z4wNkfuoaz88FdcYFRlrvixUvow61coJ X-Received: by 2002:a63:88c3:0:b0:3fa:aa4f:a09c with SMTP id l186-20020a6388c3000000b003faaa4fa09cmr20820454pgd.488.1653767502797; Sat, 28 May 2022 12:51:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653767502; cv=none; d=google.com; s=arc-20160816; b=zVU8JZxzit3xIvXNKd+ibkhX81LSt1E3GMoHhsatJhUvgh+2zy3gbanbbT2X1wZEUJ iTXalE3xHfSjc2d41s9Ciqcw5SS1BH9hEYedPH/tEefd5ySSl72sdxXklz+zMVLE3Pz5 VBWaGGTYxvHtxuVIisQo4CS/Wotprd9mppD1r8JF69FETFc/0wQeaKWXM7jlT02/Y8TE OlXPruMnZZHbYcVL9vwx1jXaqXMDD9w68yuDBLcA7NLL7WbJh6fQLKiB2usXOx5ZaGfI CmnsG//J74+Vw6mvuPEql02zLPitiJC0i048I4yXxriGCb1zZat2V78vGO28ZL8Gw6rQ mvdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=JdImCzgSPz0H+mIzVDv7OFJ66SmMuOrOg3W+mTgl2b8=; b=qzdQt4lXJxC9zVjUM05MqoqIQGsjvhD8a+DrlxVYMfJkXxrwT/BZLbpPBrYa4cCEZU 5PnSC5yoE/9gnewO5+7oovQakTfU6pQHUa+w1791R/f+SE0VT6mdMMBiyGm2C/8F5DZx 9Yrz3tf65YxEZNSpvIdqXKoms5TRBxLjgbqTCU0mRmAhRqK0+4L7XvHe4/U06UNgqX4v NzJGHxq+tvYdjvxFHA9rr2kfRVDzAADD54rlM6YHCNcoRfbT+17Ie3uAIWqLw2DIcRhk aJeGAXuCD+5oOflsoMzUIUdun7Nn/eEB00F/Uv7KmJxh7FnYYPIuqGSgUGWIzEmvHye+ +SIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=iyo4DkmN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id z16-20020a170902ccd000b0016356bd88e5si7950001ple.419.2022.05.28.12.51.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 May 2022 12:51:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=iyo4DkmN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3452E6EB13; Sat, 28 May 2022 12:11:53 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347986AbiEZSzJ (ORCPT + 99 others); Thu, 26 May 2022 14:55:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348563AbiEZSzE (ORCPT ); Thu, 26 May 2022 14:55:04 -0400 Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D4FBCC169; Thu, 26 May 2022 11:55:02 -0700 (PDT) Received: by mail-pg1-x52e.google.com with SMTP id 137so2029788pgb.5; Thu, 26 May 2022 11:55:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JdImCzgSPz0H+mIzVDv7OFJ66SmMuOrOg3W+mTgl2b8=; b=iyo4DkmN0bT2b6K66vlwNX8B0+jYAq4KpN+s1rvNcR6rzI68koNDIx7pAfkXhb9yPp TBZ3zkWl4mgRPOi7Cqc7gKvXu/8HNeQpxnxnY+mjwWqbFI+B/mV8WKWDWdNPLe1xNzix ZQNTk2uaN+a4ZPNPSH3SOmTbm6OJTOK24u1x+/0alfhkxLHzOXWZrDf+yrltDPwhayMu y5vrXBezGsB26WB2ivlwNSuXP08LsF7yTLW9+zxXlJ0MbwOVY+H3LyPuf+VF/4POoHRu 8OMZpNMvCITCIJ3qV1bIMAZCUY8O2eSx5+NlqQNqjkmMM+1wmGOMiUVNZk7hJYFKV5iQ fJtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=JdImCzgSPz0H+mIzVDv7OFJ66SmMuOrOg3W+mTgl2b8=; b=4pWaAdBaslQAgva20dGbo13FWLWrJfqKKqha2kVe/3FnF1XPCsJqChf/Wu9nzCqBFW M+Gx2ksJ8DL24ypc9Hbb9cSOWkNPAYbUMrQfLA3kCoSksha7LXyTt7fHoirTsgVeMN6F hPwNYtoUhGsToJUGWT7UEzA7xNbMKHlEpYm0lMiDYGjwu3NYOhUoda1VqPzS7kXuM3QO 0K3CI16wzebOp5kv+SYQTmsPSr0N87yaR8qRJVVFVBX1tHVmC6SNj3psmTsrml4K/p58 mDV5GaOtqTrij2tJqVTM9Y36P6X0kGoHvDQhkx/0INI+fKY9ZrvGPt5sekMI/iDlo3Kq 43sg== X-Gm-Message-State: AOAM530iiasmxKTEsjjGNlZw70uSrDUf0+LIHbANLzly4DXbqlohgFAk TTdYEfPX83w2mcZbdtm/GBI= X-Received: by 2002:a63:4758:0:b0:3f6:e04:2ba4 with SMTP id w24-20020a634758000000b003f60e042ba4mr33749043pgk.100.1653591301971; Thu, 26 May 2022 11:55:01 -0700 (PDT) Received: from localhost ([2620:10d:c090:400::4:aafd]) by smtp.gmail.com with ESMTPSA id 66-20020a621545000000b0051849bc0c23sm1843481pfv.23.2022.05.26.11.55.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 May 2022 11:55:01 -0700 (PDT) Sender: Tejun Heo Date: Thu, 26 May 2022 08:54:59 -1000 From: Tejun Heo To: Johannes Weiner Cc: Chen Wandun , lizefan.x@bytedance.com, surenb@google.com, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] psi: dont alloc memory for psi by default Message-ID: References: <20220526122656.256274-1-chenwandun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 26, 2022 at 12:10:05PM -0400, Johannes Weiner wrote: > On Thu, May 26, 2022 at 08:26:56PM +0800, Chen Wandun wrote: > > Memory about struct psi_group is allocated by default for > > each cgroup even if psi_disabled is true, in this case, these > > allocated memory is waste, so alloc memory for struct psi_group > > only when psi_disabled is false. > > > > Signed-off-by: Chen Wandun > > Looks good to me, > Acked-by: Johannes Weiner > > Tejun, would you mind taking this through the cgroup tree? Will do once rc1 drops. Thanks. -- tejun