Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Subject: Re: [PATCH] extcon: fsa9480: Drop no-op remove function
To:     =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>,
        MyungJoo Ham <myungjoo.ham@samsung.com>
Cc:     linux-kernel@vger.kernel.org, kernel@pengutronix.de
From:   Chanwoo Choi <cw00.choi@samsung.com>
Organization: Samsung Electronics
Message-ID: <3b785922-df17-3f5e-c3a2-be95cf3ea9c2@samsung.com>
Date:   Fri, 27 May 2022 18:09:56 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101
        Thunderbird/59.0
MIME-Version: 1.0
In-Reply-To: <20220526130754.1587373-1-u.kleine-koenig@pengutronix.de>
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <CGME20220526130812epcas1p272b572297501a35f98fa1c6656381cfa@epcas1p2.samsung.com>
        <20220526130754.1587373-1-u.kleine-koenig@pengutronix.de>
Precedence: bulk

On 5/26/22 10:07 PM, Uwe Kleine-König wrote:
> A remove callback that just returns 0 is equivalent to no callback at all
> as can be seen in i2c_device_remove(). So simplify accordingly.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/extcon/extcon-fsa9480.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/extcon/extcon-fsa9480.c b/drivers/extcon/extcon-fsa9480.c
> index 08bdedbcdb0d..7cff66c29907 100644
> --- a/drivers/extcon/extcon-fsa9480.c
> +++ b/drivers/extcon/extcon-fsa9480.c
> @@ -324,11 +324,6 @@ static int fsa9480_probe(struct i2c_client *client,
>  	return 0;
>  }
>  
> -static int fsa9480_remove(struct i2c_client *client)
> -{
> -	return 0;
> -}
> -
>  #ifdef CONFIG_PM_SLEEP
>  static int fsa9480_suspend(struct device *dev)
>  {
> @@ -376,7 +371,6 @@ static struct i2c_driver fsa9480_i2c_driver = {
>  		.of_match_table = fsa9480_of_match,
>  	},
>  	.probe			= fsa9480_probe,
> -	.remove			= fsa9480_remove,
>  	.id_table		= fsa9480_id,
>  };
>  
> 
> base-commit: 4b0986a3613c92f4ec1bdc7f60ec66fea135991f
> 

Applied it for v5.20-rc1. Thanks.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics