Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <bd25414c73fae85529568c6f5b88bfdad6df7b97.camel@HansenPartnership.com>
In-Reply-To: <bd25414c73fae85529568c6f5b88bfdad6df7b97.camel@HansenPartnership.com>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Wed, 25 May 2022 19:17:38 -0700
Message-ID: <CAHk-=wh5SyuAox3QXvmJLwV4VgN_EK4oaAkh5-73FVf36ZdHog@mail.gmail.com>
Subject: Re: [GIT PULL] first round of SCSI updates for the 5.18+ merge window
To:     James Bottomley <James.Bottomley@hansenpartnership.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        linux-scsi <linux-scsi@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, May 24, 2022 at 7:38 PM James Bottomley
<James.Bottomley@hansenpartnership.com> wrote:
>
> Max Gurtovoy (3):
>       scsi: target: iscsi: Rename iscsi_session to iscsit_session
>       scsi: target: iscsi: Rename iscsi_conn to iscsit_conn
>       scsi: target: iscsi: Rename iscsi_cmd to iscsit_cmd

People, there really isn't some incredible drought of letters in the
world. It's ok to write out "target" instead of just "t".

Done is done, and renaming things further is probably not worth it,
but when the commit talks about "more readable code" I really don't
know if "struct iscsit_session" and friends is conducive to "more
readable". It looks more like line noise.

Yeah, it's less typing, and maybe "struct iscsi_target_session" would
have been too long. But still, I had to do a double-take when looking
at the diff, and aside from it being line noise, having a structure
name that differs by just one character in the middle between target
and initiator feels like mistake.

Anyway, pulled despite what feels like an oddity.

                Linus