Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Fri, 27 May 2022 09:10:07 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Yu Zhe <yuzhe@nfschina.com>
Cc:     mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
        vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
        rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
        bristot@redhat.com, vschneid@redhat.com,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        liqiong@nfschina.com
Subject: Re: [PATCH] sched: change printk(KERN_<LEVEL>.. to pr_<level>()
Message-ID: <20220527061007.GJ2146@kadam>
References: <20220526091031.3741819-1-yuzhe@nfschina.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220526091031.3741819-1-yuzhe@nfschina.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4n0mTVyF8IOgx0PUSDRfHhfqgHunopGFWG5S2arhD/aW/tIVdsZFcC9j1wzb?=
 =?us-ascii?Q?nwHmAtwMZ5eqZuAjafEkxF89ckwbFZygEWPrmvyEQGC/wnbcXduE7ArAUGwc?=
 =?us-ascii?Q?PlGajynGA2YFwERiLEyrBSiO2ItUDoimTaTtlngGKL6fbszRQsStRQPBfCI7?=
 =?us-ascii?Q?xVTWXDgRyrx54W4GfRE1bRYwhvFFtQRVf22WjA/S6zjvIa45btXUemBDzNGM?=
 =?us-ascii?Q?CpoY7HbwQjS7keBsltuwIlk++VOpObLd4Mmp3NXZaI9myYrcCnweE4GtmrqK?=
 =?us-ascii?Q?z4i8ihNmYmnC63oQz/aC4RdidhBY8KhbXnuMIrIKjNkh5sFI935BMYFBEdiU?=
 =?us-ascii?Q?1nxrrPsTX2Fv3lNjCT0/R883BekzRvnIpntJXFUuf83Je+/MTbS6T+NVDYK2?=
 =?us-ascii?Q?yM4ulrsfDafT+HQHR1TrBFJC0Tp5A8cdllGJWyJ77TeXggOj6PMgPgZ3xybY?=
 =?us-ascii?Q?zyk3aUSjgHpn8Tla9Mk/VTIbMv795oeX6IPumSVcq9Qp8mYBy/ZerQ85+1Yv?=
 =?us-ascii?Q?GfS/fGBCmxScfSMuZfIptHrDHEYYkoDuY2rynphJooVowdQzJqm72D2rAzXQ?=
 =?us-ascii?Q?63ngEtGWCsRvtILmM+XvR/lumQfqec6SEMtGKYtBmqZbE0ANBeLBCe5SZxml?=
 =?us-ascii?Q?PHgEpUqe2kkIvGTtk2vQDXqsOAXCpvx1T7rRFWM5avIZ3rIrWAC+Rjzh5ldR?=
 =?us-ascii?Q?lRBHyR96SFWvrhmz+jHcahg+b/tqpLCfCohUKUqI569EDUwVx/80XdD8sE9Q?=
 =?us-ascii?Q?nRAwyAND8h+q5LkGJ2u5C+Iqjt8h25BopAR8WitP4GHFWp9JRmi4opYCgt8q?=
 =?us-ascii?Q?2XUEEaqFxrsjIHliOC8h/qy9qoqeO9Xj/OusL2pUuZxmW1EoHjYZgwhCsbpg?=
 =?us-ascii?Q?UiiU+uIKkr3wk84YDHXSp2NqdMBJAIKSvF1Y6qp7SAqKM+0hGkuDspWReBDD?=
 =?us-ascii?Q?dkHJAVApKPOSQjO51Pnr8JRxStwIIw82w/PrIjSBJ9ZBDNvP+mjVX4g67Z+s?=
 =?us-ascii?Q?UIk6CrKHa7mvEYvf6xVzTMhQ0SgUOEhKm+DJnxyHA+fg8VdISomO1ltlCq+y?=
 =?us-ascii?Q?F0mNT6eB+nppRG83qk6fcT3ru2yb2jvfxhXCiw9LRO8C6AfiSM2mF3RAaXt/?=
 =?us-ascii?Q?ygwJi1sMV8Ywq5C4tvdlTuZrx/jgG57qOSOwWWNfFmtzxwFKcCoSlBrQZ3a3?=
 =?us-ascii?Q?tAeyQP0dQBsoe/2n+fGmayX63S2zWn0wrDFN9ke4XFalb/rZBcnCGejT1E4W?=
 =?us-ascii?Q?MPmyoaSfhwDvfQW0Dw8ggfqf1H+MYcwgFJ/YStYvp7HadTsJc+lnf+2lFjBD?=
 =?us-ascii?Q?1XNr4At/lJ+qw94dQNHsE5NmvTjoH5m+aWbesQkdZdUQjlBLTGwHLxevf4Fn?=
 =?us-ascii?Q?vCCcYpQAeQxrspGAuvch4WHWbpFEtzl0N3uMJPmlABW0p+QUYm3XanBJKFmH?=
 =?us-ascii?Q?xuPl7SZVVgAwmNf6KfyxNvVmDyqAU47WRLbYOZE9t/uH6OpTAx984gA+aftg?=
 =?us-ascii?Q?ITBEhWa+GNH7SFFcfnEI4Ep7fkPbfhoxJoP7TG+z97mr3RW4OIlJUD7gXGjq?=
 =?us-ascii?Q?PCYTWtuC1QFbjKHXVoS/XvYEm/aTmnNyILtfBQeeGquRH29aIZA5gdueCcfR?=
 =?us-ascii?Q?xNBx0SlIxZOvW1BjpBYISPl0iMycS4YXWOlVV1v5Xmdiqcj+tMCM83AAvAXe?=
 =?us-ascii?Q?/1Y2jqyY94IPkDwCn38cZC0+DzdBf8GO93IyE7dzkXhNTDbQjCGJ4b1Jm/kE?=
 =?us-ascii?Q?k5QkqAznmmJoHJn3rbpUTPm6jkaBccI=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 11a06fed-ff6c-4a6d-fa24-08da3fa7995d
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2022 06:10:29.3538
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 42VOe87lc4AQlLLNfvlmiDrjPtPhCJ4Gv01fYOrHwnsUFrbLidbPOOwMTFdG6sZ9+vcFfXySkr16ou9ECGp3zxFSAp8Ta5IMFtEFgs05yjM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5645
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.874
 definitions=2022-05-27_02:2022-05-25,2022-05-27 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0
 malwarescore=0 phishscore=0 mlxlogscore=999 adultscore=0 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2205270030
X-Proofpoint-ORIG-GUID: FKkL_Iv7uMhS3eaj8Oj69BDkCacLo1OC
X-Proofpoint-GUID: FKkL_Iv7uMhS3eaj8Oj69BDkCacLo1OC
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 26, 2022 at 02:10:31AM -0700, Yu Zhe wrote:
> @@ -9370,7 +9370,7 @@ static void dump_rq_tasks(struct rq *rq, const char *loglvl)
>  
>  	lockdep_assert_rq_held(rq);
>  
> -	printk("%sCPU%d enqueued tasks (%u total):\n", loglvl, cpu, rq->nr_running);
> +	pr_warn("%sCPU%d enqueued tasks (%u total):\n", loglvl, cpu, rq->nr_running);
                                                        ^^^^^^

Your patch is wrong.  The code aready has loglvl but as a variable.

Don't start sending checkpatch stuff to kernel/sched.  Better to get
some experience in drivers/staging/ because Greg deliberately leaves a
lot of garbage code for people to clean up and get experience.

regards,
dan carpenter