Received: by 2002:ac2:464d:0:0:0:0:0 with SMTP id s13csp1992182lfo; Sat, 28 May 2022 12:59:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxB9l9iinMU8RLfr7Nv9KYLmOyPu8kXS5FaoAePWB7RaGwJImkxiHvp0cNkFQRG3jrG1Nyh X-Received: by 2002:a17:902:d549:b0:163:7f27:f748 with SMTP id z9-20020a170902d54900b001637f27f748mr13430756plf.116.1653767995827; Sat, 28 May 2022 12:59:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653767995; cv=none; d=google.com; s=arc-20160816; b=civzCOeV3OlBBbgTdFs6gRXkkIMZZf0ueyLsODhmTUvVZVafned//N/iwz+gQBSzeo Cvl6xmoYMwj+8u1qugvI/2S5/SffIGwsOmRSxZ7aJZ10alVvvypTXTgCFHq6sSFhJnFR 6AlnKV8Hd6n6EyqVdhX0d70KHAS0JyyNw5CViw98QmvzS1wetuBZI5ojIMY4k2mu8s1U F23jJuFvXN3cCDaYd3d8V70AolRkYzguDN1Ka8b9slfzusXKJbtm5/zHBq/uB5VLRxgI c3j0RO2OrCl/UDEEilRT0pYDwmKUVsx0w5l1Yg9glVlIboJ+UX058fpiA0wNgrnChB/5 /xYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=+u8JHoqLLvsvRVRBUuvCk5vOU0EPwCFY9Y54KiKuKVk=; b=uqEtkPSaq8kG/DmVFKHSlkOd8juXKYyA8Wa7NrproCF2q6Zoth88xmr1tRgT195lcC jUVxkhg1+z9J8n2YXhOmD7qNnhrpBTSI9lsFusSBA1AgaERL/8vC6FZQmcqH9iSk/jLs s16wjNB120u5pnUHPhEHd4wFRYPMg2Mj59yOeswnIbOZRkRWtj9LoMzdbFYO3kSHVMxn JICUwD2M5xVpldF6PSDDwWZmFQOXHWoY3KIf6xpT7rT/7V8OqMtbsFqKcrYRV5+p4Jvu AMTCGSCJlCFArPHBEvJf2FmDwvjZH+hge8wU3twkuL3veAhfDsUgo+Xzfwn/0cUO3jEy HGsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=hsMieLIn; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id j8-20020a170902758800b0015852e64a54si9174155pll.278.2022.05.28.12.59.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 May 2022 12:59:55 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=hsMieLIn; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 436A7C9ECB; Sat, 28 May 2022 12:18:16 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349560AbiE0Qyf (ORCPT + 99 others); Fri, 27 May 2022 12:54:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240866AbiE0Qye (ORCPT ); Fri, 27 May 2022 12:54:34 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24E9DED70C; Fri, 27 May 2022 09:54:32 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CFCCA21ADA; Fri, 27 May 2022 16:54:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1653670470; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+u8JHoqLLvsvRVRBUuvCk5vOU0EPwCFY9Y54KiKuKVk=; b=hsMieLInNRiAFgba/ZyPJYd4fTnZWpaKHkD81x/3sHXl8J57s/mbfM10cJZ/tgrYCx4GU3 E4pweojjXyzWX8ILfLZZqX2DYyZNLolbQgy+7oLilvuFWqBXX/VnIgybG3/7ew2v/tY2c2 LC18jfjBjXvsIReeB0Qutu1x07qBcYw= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A639813A84; Fri, 27 May 2022 16:54:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ldeHJ0YCkWL1KAAAMHmgww (envelope-from ); Fri, 27 May 2022 16:54:30 +0000 Date: Fri, 27 May 2022 18:54:29 +0200 From: Michal =?iso-8859-1?Q?Koutn=FD?= To: Tadeusz Struk Cc: Tejun Heo , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Zefan Li , Johannes Weiner , Bui Quang Minh Subject: Re: [PATCH 2/2] cgroup: Use separate work structs on css release path Message-ID: <20220527165429.GJ11007@blackbody.suse.cz> References: <20220525151517.8430-1-mkoutny@suse.com> <20220525151517.8430-3-mkoutny@suse.com> <20220525161455.GA16134@blackbody.suse.cz> <904ef8af-13a5-e566-b760-74519f70fa62@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <904ef8af-13a5-e566-b760-74519f70fa62@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Tadeusz. On Fri, May 27, 2022 at 09:39:20AM -0700, Tadeusz Struk wrote: > As far as I can see we are trying to test the same thing suggested by Tejun. > I just sent a test request to try this: > https://github.com/tstruk/linux/commit/master Yup, I've added few more prints to get more fine-grained resolution. Also, I decided to use ftrace printk not to interfere with timing too much (due to the original race hypothesis). > Let me know if you have any more tests to run and I will hold off until > you are done. My latest attempt is [1] (tip 5500e05d82fd5b5db2203eedb3f786857d3ccbea). So far, I'm not convinced, I extract the complete ftrace buffer from the syzbot runs, so I'm not drawing any conclusions from the traces I've got. I'm not going to continue today. You may have more luck with your plain printk (if it's just imbalance and it avoids printk locking sensitive paths). HTH, Michal [1] https://github.com/Werkov/linux/tree/cgroup-ml/css-lifecycle-b2