Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Claudiu Manoil <claudiu.manoil@nxp.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH] net: enetc: Use pci_release_region() to release some
 resources
Thread-Topic: [PATCH] net: enetc: Use pci_release_region() to release some
 resources
Thread-Index: AQHYcavCsFlf4vEGkk+HPnY37e6cTK0y/S5A
Date:   Fri, 27 May 2022 17:51:08 +0000
Message-ID: <AM9PR04MB8397145BCF0042D9148417E196D89@AM9PR04MB8397.eurprd04.prod.outlook.com>
References: <b0dcb6124717d13900e48b2f1fa697b922f672b2.1653643529.git.christophe.jaillet@wanadoo.fr>
In-Reply-To: <b0dcb6124717d13900e48b2f1fa697b922f672b2.1653643529.git.christophe.jaillet@wanadoo.fr>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?L3N1NAMTgiMynfXnkqXkAltQA3o2VfiaUuuRHop+KVYMZaErGMnL1BUsUUmK?=
 =?us-ascii?Q?QrCW1paNiLjsrrItkBq/ADlLyIJH/FqYfZDq9AJ2ZKK5HkOT+LLC38sqmTv6?=
 =?us-ascii?Q?dFVHkOls0wHIIAwlv1e22pzQGeLkBF/ZVVcRKt80l16E1KyC2Mb4ssEjeJaN?=
 =?us-ascii?Q?yFWO73IHCg9kXlJa9XUPDcyGlvAhLnoMbYX0WF9YLlCkZB06h5dVD49AJzUf?=
 =?us-ascii?Q?IdGCiLoKPYMgJo2K9tnFyzw0kjUsGlERR+mKb5IeRjpi1CGsY20guNGEQD0E?=
 =?us-ascii?Q?xYfMJdpRmBMqfADwxaDUX4CLOiMcyqQEj5byb8hycSs4x+FjkMcBVczB0dhM?=
 =?us-ascii?Q?cVi8diJFUdaFzf+DDwT8EAsLqcRFBoGPqaaiS9kpGyTSNsEhHwDCLR1ZVZlA?=
 =?us-ascii?Q?9O28rc0jvjnuuKjk+pjBMNJSkTgQAT5zmrAe0TjNzKOROwui9nCvyG/4fhC3?=
 =?us-ascii?Q?IZrkD3vdyZQ4nQqCPnT/NVoM7d+FOF/2WlA52siQTunXcj77GnpiJ72YDJcd?=
 =?us-ascii?Q?MkRT4lNaEx1TBVq4ul84YJnVEWC7qpMenPI1ctdi+HSbGjIEExrNjnzFrkuZ?=
 =?us-ascii?Q?oS7r0A92+qNLdV1jG5i5ZB+ycj6t30J1MWYuvwH6/EwdLzuCs0TGW/A0BR4R?=
 =?us-ascii?Q?TcUz7qbwY1h9R3ibrqz5Pd3gi4mVkDaJdeixDOVU9n1YPPIrqIAuD+wDjkaW?=
 =?us-ascii?Q?kPWUfl2XBdwuVc+11W0neg/wfZNAH4chPoVH3oEawAYrWLTVZUHo/xokqG6h?=
 =?us-ascii?Q?/cND6rmp30pZ19Px7z/5Lh37oNM2+OdZTrOUghNnM3OIRwdhhhpol6q2iv1k?=
 =?us-ascii?Q?YMnyQ7meMlKTkyCGa37Jl74Mn9qM6pahyFyKxUb0IcRVgZhYMA0ipYloHABV?=
 =?us-ascii?Q?ZgddaJ3SOrJoUMc/DeGudu8+VTrrjGXW5X2RIP7TZhybJnVM3v6kFJBJHu3g?=
 =?us-ascii?Q?8PTYDyhVcu7jKt9GO2rwsuFO8AYVTAkubLvvUr54Uu7juGk3By4VuhxP85H6?=
 =?us-ascii?Q?o7k1phQJKFydsY/JyX3ABMfL7sT80n9QqoLsY8CtmBVjaNKdYfiILpvQx1AH?=
 =?us-ascii?Q?vL0r4DwUctx3CR6MIx3dAekpgd8nXHxZhluIb5OlUIvYyqn2nBtTvtxmehOZ?=
 =?us-ascii?Q?EbxLjOGle93qlVIV9pRiGReP5tWCy2zncWGAkDqlX9/29wBHaqBVACUePula?=
 =?us-ascii?Q?OUi2+chdqiojAGE4IEANAyLUp531iufjo74wP+CJ4rVtrf74JkaZhoVFSeh+?=
 =?us-ascii?Q?6cOXKUX18DRHD41NxAwtCA1sZBggaFQz1TtOQnH2TySY/v3RII8ubtT425nW?=
 =?us-ascii?Q?41rYNZ2tmoNxBsWVQMIrT+i2HKIgPcWVTXiReIQG/Eawhuy4EuE4sX7kPo/T?=
 =?us-ascii?Q?A8FREtJg8efXGDnGBfubxg9qYOpcHJ1LhgVuVU8mZTWM7/yPmS7Ty52VTptK?=
 =?us-ascii?Q?oqyVL+DkW033UPeMJhOTSeCSeniN3u9gwJ8mK77gFkEB2X8VZa9EQug8yu4f?=
 =?us-ascii?Q?sdhYNhys1YMy+vZzePhke1DRompqVRzXb01sfEC0ox7sZXtFalGKelln7hfG?=
 =?us-ascii?Q?IDS++A8+qQsI0vToDh2NrbG/5smekyrI2V0VCpeUPMv7u+h1WiXtCD8Y1pGB?=
 =?us-ascii?Q?A6BmtB063+r1Wv6dfr2/EoYIpaKVzwz1x85+fZ66YRXdXlbzd+/eOeChMYZu?=
 =?us-ascii?Q?69Q/batEh0JjZSKooFAMK4nPHrORmVVIlnedM6KHGLS89wafcU8mw3JjyHQj?=
 =?us-ascii?Q?36irSwwO4A=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8397.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 092463fc-2cb9-4490-0f40-08da40097af2
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 May 2022 17:51:08.7288
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fJlLjxULo5CmS301IXF44QoVhhELzPrw4+pwTRdc3JBFbDFVnwnRHMc5P6oDiebYrbBVg0ANNRL8sTTl6McDdg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8499
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Sent: Friday, May 27, 2022 12:26 PM
[...]
> Subject: [PATCH] net: enetc: Use pci_release_region() to release some
> resources
>=20
> Some resources are allocated using pci_request_region().
> It is more straightforward to release them with pci_release_region().
>=20
> Fixes: 231ece36f50d ("enetc: Add mdio bus driver for the PCIe MDIO
> endpoint")
>=20
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> This patch is speculative, mainly based on the inconsistency between some
> function's names.
> Using pci_request_mem_regions() would also have things look consistent.
>=20
> Review with care.
> ---

Since the external MDIO registers are located in BAR 0 of the PCIe endpoint=
 device,
the driver requests specifically the BAR 0 mem region and should release th=
e same
region. So the fix is valid. Thanks.

Reviewed-by: Claudiu Manoil <claudiu.manoil@nxp.com>