Received: by 2002:ac2:464d:0:0:0:0:0 with SMTP id s13csp1998524lfo; Sat, 28 May 2022 13:15:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyaRVB60fM7NkqypWCg4eLe+6mRIAN4Zwu0w1K3U5o63AEyzr+Q/UIgHjO1/GGhdYO3V//V X-Received: by 2002:a65:488e:0:b0:3fa:289e:882b with SMTP id n14-20020a65488e000000b003fa289e882bmr28511626pgs.393.1653768924726; Sat, 28 May 2022 13:15:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653768924; cv=none; d=google.com; s=arc-20160816; b=QBlvJkXXPwMa0JvCSbY/v8+GXyLQ+YlzMeJACbcQYsyim3SGiNIjBaCVy2QKj3K/c/ VDOqXCvSjesYEwkXFmpNlhTyJSVdBAPB16FR2qlMYG+fe0c06+o+0m/H/TWJQXgkJ0Zi FSCUCK17fVc/NxVJFpFnEU3dJLHhFOm6sDWYT7V9diQmIswM9evsSw7OFPfylp+le31K e9PFisgov0LJVU03AsFK/uYDbTMjpfC+fRF+LrfRamMH0fzCnszvzJh411ua9t/0BsSJ 880GnO19BcV23jHestkc7WsJty/1WUXVM0Wr29/B+jecjrPbH9T9eRypD6XD6Whk6ZvF RcUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=nU2UQDrRrTNgZCGlx3+Juyg9gJKqa9hFvsLcatF4nYk=; b=Q8qCOMgvuq6GbDF6iV6rgJEJf76Dx9/o6BXTdJcUPp2L41wNMHhGOMnmYAVRzD9bsu wTuI///SJlYov0NdHNBgrMxst2M9Cq+iSSMC/FK46MgqLgc94YZZWQNlLqamctay4H5C ZafBjNlBL6gzqv+5OIGuYpjMEOsHESAMjYmIH/iqbqnQDkHTc6R2VQr7usKgjyzYyG/Q EhMawa3WujstFODjE602Po82HN+ntA3w/sZwvoWLCeKjwh57uVkyeaVbNmCj1AiwH7iC 8n8IKjgVeKct9Pa3fYAE9NPgwefK8wBKb0TU3ocp5ND8xt4q6pua5rsj7HNdatevnQlQ CiNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=HqAA4Mkt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id b6-20020aa78ec6000000b0050a73a14910si6991482pfr.218.2022.05.28.13.15.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 May 2022 13:15:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=HqAA4Mkt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 74B51146753; Sat, 28 May 2022 12:26:10 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355784AbiE1FDO (ORCPT + 99 others); Sat, 28 May 2022 01:03:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235749AbiE1FDN (ORCPT ); Sat, 28 May 2022 01:03:13 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4FB2C3D00; Fri, 27 May 2022 22:03:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=nU2UQDrRrTNgZCGlx3+Juyg9gJKqa9hFvsLcatF4nYk=; b=HqAA4MktGO1WMudvYma9Q5OBoR WgN6YSaxtPq6Naw9oAM/KxoqZkaAB0g/rKEE5aSlqLTCiRokm7eYH+PU+AxrxvTIAZ+gLY10zgbzN x0iaC+BgxU2ZAqsRHsswWxy9XrcEsKHFH38ftS1MaXged/qeSavGaRzSbR4rAuR4X4nUgKxJPErG9 Y9nNFyEWEkO3DFJrt1tTyZ75poO8I4sJtdOUu86PGLF6YHA49WPSztat8ddJ58nRfjZS9WhsCBJJS wU16/5hH37wJKBAdlbbOw063jkQ7LCrTPDG/jt68ZFrdHa55r99Z0dChsVNMNsm9AFKABdG0F69Q6 FgnVpuFA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuobW-001SZy-Fk; Sat, 28 May 2022 05:03:10 +0000 Date: Fri, 27 May 2022 22:03:10 -0700 From: Christoph Hellwig To: Jaegeuk Kim Cc: Eric Biggers , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-block@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH] f2fs: add sysfs entry to avoid FUA Message-ID: References: <20220527205955.3251982-1-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 27, 2022 at 06:06:08PM -0700, Jaegeuk Kim wrote: > I think there's still some benefit to use FUA such as small chunk writes > for checkpoint. Did you measure if there is? Because some SSDs basically implemented FUA as an implied flush after the write, in which case it would not really help there either (but also not hurt). But as the previous two maintainers already said - this needs quirking at the driver layer, not in the submitter.